Summary

Refactor e-mail information saving into a single location

Review Request #8897 — Created April 12, 2017 and submitted May 22, 2017, 10:39 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

~~8896~~

Blocks

8885

Reviewers

Groups

reviewboard

People

Description

Each mail_{foo} function was saving review request and review

information identically in each function. It has now been refactored

into a single function that also ensures that only the relevant fields

are updated.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Extra space before "e-mail" "will be updated."	chipx86	April 24, 2017, 7:03 p.m.

JSHint passed.

PEP8 Style Checker internal error.

Pyflakes passed.

Depends On:: ~~8896 - Deprecate the type argument of review request signals~~

Ship it!

```
Ship It!
```

Ship it!

reviewboard/notifications/email/callbacks.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Extra space before "e-mail"
"will be updated."
```

Diff:

Revision 2 (+29 -14)

Show changes

reviewboard/notifications/email/signal_handlers.py

Checks run (3 succeeded)

JSHint passed.

PEP8 Style Checker passed.

Pyflakes passed.

Status:: Completed
Change Summary:: Pushed to release-3.0.x (e5ab703)