Prefer get_server_url() in notifications templates
Review Request #8889 — Created April 7, 2017 and submitted — Latest diff uploaded
We build the site URL manually in the majority of the e-mail templates.
However, we have a utility method which does this exact logic, so we can
just pass the result of that in instead.Additionally, the API token preference URL has been refactored to use
thebuild_server_url().
Previewed e-mails. They looked correct and links still worked.
Diff Revision 3 (Latest)
orig
1
2
3
| reviewboard/notifications/email/callbacks.py |
|---|
| reviewboard/templates/notifications/api_token_created.html |
|---|
| reviewboard/templates/notifications/api_token_created.txt |
|---|
| reviewboard/templates/notifications/api_token_deleted.html |
|---|
| reviewboard/templates/notifications/api_token_deleted.txt |
|---|
| reviewboard/templates/notifications/api_token_updated.html |
|---|
| reviewboard/templates/notifications/api_token_updated.txt |
|---|
| reviewboard/templates/notifications/email_base.html |
|---|
| reviewboard/templates/notifications/email_diff_comment_fragment.html |
|---|
| reviewboard/templates/notifications/new_user_email.html |
|---|
| reviewboard/templates/notifications/new_user_email.txt |
|---|
| reviewboard/templates/notifications/reply_email.html |
|---|
| reviewboard/templates/notifications/reply_email.txt |
|---|
| reviewboard/templates/notifications/review_email.html |
|---|
| reviewboard/templates/notifications/review_email.txt |
|---|
| reviewboard/templates/notifications/review_request_email.html |
|---|
| reviewboard/templates/notifications/review_request_email.txt |
|---|