JSHint
passed.
PEP8 Style Checker
passed.
Pyflakes
passed.
Prefer get_server_url() in notifications templates
Review Request #8889 — Created April 7, 2017 and submitted
We build the site URL manually in the majority of the e-mail templates.
However, we have a utility method which does this exact logic, so we can
just pass the result of that in instead.Additionally, the API token preference URL has been refactored to use
thebuild_server_url().
Previewed e-mails. They looked correct and links still worked.
Checks run (2 succeeded, 1 failed with error)
JSHint
passed.
PEP8 Style Checker
internal error.
Pyflakes
passed.
Testing Done: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+45 -58)
|
Checks run (3 succeeded)
JSHint
passed.
PEP8 Style Checker
passed.
Pyflakes
passed.