Prefer get_server_url() in notifications templates

Review Request #8889 - Created April 7, 2017 and submitted

Barret Rennie
Review Board
release-3.0.x
8829
8894
reviewboard

We build the site URL manually in the majority of the e-mail templates.
However, we have a utility method which does this exact logic, so we can
just pass the result of that in instead.

Additionally, the API token preference URL has been refactored to use
the build_server_url().

Previewed e-mails. They looked correct and links still worked.

  • 0
  • 0
  • 2
  • 0
  • 2
Description From Last Updated
Christian Hammond
  1. Really nice cleanup!

  2. api_token_url

  3. 
      
Barret Rennie
Barret Rennie
David Trowbridge
  1. 
      
  2. Alignment isn't quite right.

  3. 
      
Barret Rennie
David Trowbridge
  1. Ship It!
  2. 
      
Christian Hammond
  1. Ship It!
  2. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (3fac7a1)
Loading...