Prefer get_server_url() in notifications templates

Review Request #8889 — Created April 7, 2017 and submitted

Information

Review Board
release-3.0.x

Reviewers

We build the site URL manually in the majority of the e-mail templates.
However, we have a utility method which does this exact logic, so we can
just pass the result of that in instead.

Additionally, the API token preference URL has been refactored to use
the build_server_url().

Previewed e-mails. They looked correct and links still worked.

Description From Last Updated

api_token_url

chipx86chipx86

Alignment isn't quite right.

daviddavid
chipx86
  1. Really nice cleanup!

  2. Show all issues

    api_token_url

  3. 
      
brennie
brennie
david
  1. 
      
  2. Show all issues

    Alignment isn't quite right.

  3. 
      
brennie
david
  1. Ship It!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-3.0.x (3fac7a1)