Summary

Ensure an absolute URL is returned from the file upload service

Review Request #8858 — Created March 29, 2017 and submitted March 29, 2017, 4:08 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

~~8843~~

Commit

361761c...

Reviewers

Groups

reviewboard

People

Description

The FileUploadService in Djblets cannot determine the full URL of

media hosted locally and so will return relative URLs. We specialize

this service in Review Board to prepend the request method and domain to

relative URLs to make them absolute.

Testing Done


Ran unit tests.
Manually tested uploading avatars.

Issues

Description	From	Last Updated
Too many blank lines.	chipx86	March 29, 2017, 4:05 p.m.
This is probably best on the class.	chipx86	March 29, 2017, 4 p.m.
Let's change this to say "Return an absolute URL for the given URL" or something. "Ensure" doesn't really say that …	chipx86	March 29, 2017, 4 p.m.
Missing backtick at the end of the reference.	chipx86	March 29, 2017, 4 p.m.
Swap these.	chipx86	March 29, 2017, 4:01 p.m.

JSHint passed.

PEP8 Style Checker passed.

Pyflakes passed.

reviewboard/avatars/services.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This is probably best on the class.
```

reviewboard/avatars/services.py (Diff revision 1)

The issue has been resolved. Show all issues

Let's change this to say "Return an absolute URL for the given URL" or something. "Ensure" doesn't really say that it's going to normalize and return something. It could be validating or wanting to modify something in-place.

reviewboard/avatars/services.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Missing backtick at the end of the reference.
```
reviewboard/avatars/tests.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Swap these.
```

Commit:

0beb3d63903788bc5793dd1e533ce28b6edfd90f

361761c9b92ec939c863e4885808f84903c6e4ba

Diff:

Revision 2 (+118 -5)

Show changes

	reviewboard/avatars/registry.py
	reviewboard/avatars/services.py
	reviewboard/avatars/tests.py

Checks run (2 succeeded, 1 failed with error)

JSHint passed.

PEP8 Style Checker internal error.

Pyflakes passed.

Ship it!

reviewboard/avatars/services.py (Diff revisions 1 - 2)

The issue has been resolved. Show all issues

Too many blank lines.

Status:: Completed
Change Summary:: Pushed to release-3.0.x (fda91a7)