Always compute absolute URL of uploaded avatars

Review Request #8843 — Created March 25, 2017 and submitted

brennie
Djblets
release-0.10.x
8841
8858
djblets

Previously we were caching the location of uploaded avatars. However, if
a consumer switched storage backends (e.g., local host to S3), the
absolute URL would not update. Now we always compute the absolute URL of
avatars.

Tested with /r/8858/.

Description From Last Updated

In other places (for example, ImageReviewUI.get_comment_thumbnail), we check to see if the URL returned by the storage backend includes a ...

daviddavid
brennie
david
  1. 
      
  2. djblets/avatars/services/file_upload.py (Diff revision 1)
     
     

    In other places (for example, ImageReviewUI.get_comment_thumbnail), we check to see if the URL returned by the storage backend includes a netloc, and if not, we call build_server_url. If we at all anticipate including avatars in things like e-mails, we should do that here, too.

    1. We can't really do this in Djblets, so I will move that functionality to rb.

  3. 
      
chipx86
  1. Ship It!
  2. 
      
brennie
brennie
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (dc7c153)
Loading...