Summary

Always compute absolute URL of uploaded avatars

Review Request #8843 — Created March 25, 2017 and submitted March 29, 2017, 4:07 p.m.

Information

Owner

brennie

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

~~8841~~

Blocks

8858

Reviewers

Groups

djblets

People

Description

Previously we were caching the location of uploaded avatars. However, if
a consumer switched storage backends (e.g., local host to S3), the
absolute URL would not update. Now we always compute the absolute URL of
avatars.

Testing Done

Tested with /r/8858/.

Issues

Description	From	Last Updated
In other places (for example, ImageReviewUI.get_comment_thumbnail), we check to see if the URL returned by the storage backend includes a …	david	March 28, 2017, 9 p.m.

JSHint passed.

PEP8 Style Checker passed.

Pyflakes passed.

Depends On:

+	~~8841 - Make the upload location of avatars configurable~~

djblets/avatars/services/file_upload.py (Diff revision 1)

The issue has been dropped. Show all issues

In other places (for example, ImageReviewUI.get_comment_thumbnail), we check to see if the URL returned by the storage backend includes a netloc, and if not, we call build_server_url. If we at all anticipate including avatars in things like e-mails, we should do that here, too.