Fix cache issues with status updates.
Review Request #8856 — Created March 28, 2017 and submitted
If a status update is updated (for example, going from starting -> done)
without an associated review, timestamps wouldn't be updated such that the
review request ETag would change. To fix that, I've addedauto_now
to the
timestamp field so that it gets updated whenever the status update is changed,
and fixed the ETag calculation to look at all the status update timestamps.
Posted a review and had Review Bot start. Saw that the initial status update
was marked as "starting", and then reloaded. Whereas before it would still show
as starting (without a shift+reload), now it showed that the tool ran
sucessfully.
Change Summary:
Don't stick the wrong timestamp into the review request data.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+15 -8) |