Summary

Fix the display of the Add Comment button in the Review Dialog.

Review Request #8855 — Created March 28, 2017 and submitted March 28, 2017, 10:25 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

fb33fc4...

Reviewers

Groups

reviewboard

People

Description

The Review Dialog's Add Comment button (used for general comments)
required a flag to be passed during construction. The "Review" action on
the review request passed this action in, but the "Edit Review" button
on the review banner did not.

Rather than fix up the review banner (plumbing the state through several
more objects), we now have a RB.EnabledFeatures dictionary where we can
set the enabled state for features we care about. The Review Dialog
accesses this directly, instead of taking in an option during
construction.

The dialog also no longer tries to load general comments if the feature
is disabled. This was causing an error before, given that the API would
not be accessible.

Unit tests were added to test both the enabled and disabled states.

Testing Done

Tested with the feature enabled and disabled. I only saw the Add Comment
dialog when the feature was enabled, and loading comments no longer
failed when disabled.

Unit tests pass with the feature enabled and disabled.

Issues

Description	From	Last Updated
"they are shown first"	brennie	March 28, 2017, 6:52 a.m.
Col: 2 Expected a string and instead saw %.	reviewbot	March 28, 2017, 6:27 a.m.
Col: 4 Expected ':' and instead saw 'load'.	reviewbot	March 28, 2017, 6:27 a.m.
Col: 9 Expected a JSON value.	reviewbot	March 28, 2017, 6:27 a.m.
Col: 9 Expected '}' and instead saw 'djblets_js'.	reviewbot	March 28, 2017, 6:27 a.m.
Col: 9 Unrecoverable syntax error. (0% scanned).	reviewbot	March 28, 2017, 6:27 a.m.
Col: 9 Unrecoverable syntax error. (0% scanned).	reviewbot	March 28, 2017, 6:54 a.m.
Col: 9 Expected '}' and instead saw 'djblets_js'.	reviewbot	March 28, 2017, 6:54 a.m.
Col: 9 Expected a JSON value.	reviewbot	March 28, 2017, 6:54 a.m.
Col: 4 Expected ':' and instead saw 'load'.	reviewbot	March 28, 2017, 6:54 a.m.
Col: 2 Expected a string and instead saw %.	reviewbot	March 28, 2017, 6:54 a.m.

JSHint failed.

PEP8 Style Checker passed.

Pyflakes passed.

JSHint

reviewboard/templates/reviews/reviewable_page_data.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 2
 Expected a string and instead saw %.
```
reviewboard/templates/reviews/reviewable_page_data.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 4
 Expected ':' and instead saw 'load'.
```
reviewboard/templates/reviews/reviewable_page_data.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 9
 Expected a JSON value.
```
reviewboard/templates/reviews/reviewable_page_data.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 9
 Expected '}' and instead saw 'djblets_js'.
```
reviewboard/templates/reviews/reviewable_page_data.js (Diff revision 1)
The issue has been dropped. Show all issues
```
Col: 9
 Unrecoverable syntax error. (0% scanned).
```

Ship it!

reviewboard/static/rb/js/views/reviewDialogView.es6.js (Diff revision 1)
The issue has been resolved. Show all issues
```
"they are shown first"
```

Change Summary:

Made gooder a strings.

Commit:

-	ecb239fc747cc026e3f9311b34f6b030acb6c55b
+	fb33fc42de73369a3994c8ebbf23451b3befeaff

Diff:

Revision 2 (+108 -62)

Show changes

	reviewboard/static/rb/js/pages/views/reviewablePageView.es6.js
	reviewboard/static/rb/js/views/reviewDialogView.es6.js
	reviewboard/static/rb/js/views/tests/reviewDialogViewTests.js
	reviewboard/templates/base.html
	reviewboard/templates/reviews/reviewable_page_data.js

Checks run (1 failed, 2 succeeded)

JSHint failed.

PEP8 Style Checker passed.

Pyflakes passed.

JSHint

reviewboard/templates/reviews/reviewable_page_data.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 9
 Unrecoverable syntax error. (0% scanned).
```
reviewboard/templates/reviews/reviewable_page_data.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 9
 Expected '}' and instead saw 'djblets_js'.
```
reviewboard/templates/reviews/reviewable_page_data.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 9
 Expected a JSON value.
```
reviewboard/templates/reviews/reviewable_page_data.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 4
 Expected ':' and instead saw 'load'.
```
reviewboard/templates/reviews/reviewable_page_data.js (Diff revision 2)
The issue has been dropped. Show all issues
```
Col: 2
 Expected a string and instead saw %.
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (f0a7dee)