Summary

Serialize the status field in the FileDiff API

Review Request #8828 — Created March 20, 2017 and submitted April 4, 2017, 12:22 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

b445012...

Reviewers

Groups

reviewboard

People

Description

The FileDiff API has historically not included the status field,
which indicates if the file was newly created, moved, etc. in the
change. We now serialize it as a human readable string in the API.

Additionally basic unit tests have been added for the FileDiff API, as
they did not previously exist.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
'logging' imported but unused	reviewbot	March 20, 2017, 4:58 p.m.
Col: 17 E126 continuation line over-indented for hanging indent	reviewbot	March 20, 2017, 4:58 p.m.
Col: 1 W391 blank line at end of file	reviewbot	March 20, 2017, 4:58 p.m.
This needs a real description.	david	March 21, 2017, 5:37 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/tests/test_filediff.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/tests/test_filediff.py

reviewboard/webapi/resources/filediff.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 'logging' imported but unused
```
reviewboard/webapi/tests/test_filediff.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 17
 E126 continuation line over-indented for hanging indent
```
reviewboard/webapi/tests/test_filediff.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 W391 blank line at end of file
```

Commit:

-	4142a65cbefc6c67202f426d01aad101fb265034
+	6b6bc52481de2ea76590ccfa639dfc4d9e52db15

Diff:

Revision 2 (+154)

Show changes

	reviewboard/diffviewer/models.py
	reviewboard/webapi/resources/filediff.py
	reviewboard/webapi/tests/test_filediff.py

Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/tests/test_filediff.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/tests/test_filediff.py

reviewboard/webapi/resources/filediff.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This needs a real description.
```

Commit:

-	6b6bc52481de2ea76590ccfa639dfc4d9e52db15
+	b445012a50d81b5a4f4ff332613c428fb22526c7

Diff:

Revision 3 (+155)

Show changes

	reviewboard/diffviewer/models.py
	reviewboard/webapi/resources/filediff.py
	reviewboard/webapi/tests/test_filediff.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/tests/test_filediff.py



Tool: Pyflakes
Processed Files:
    reviewboard/diffviewer/models.py
    reviewboard/webapi/resources/filediff.py
    reviewboard/webapi/tests/test_filediff.py

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (732ac0f)