Serialize the status field in the FileDiff API

Review Request #8828 — Created March 20, 2017 and submitted

brennie
Review Board
release-2.5.x
b445012...
reviewboard

The FileDiff API has historically not included the status field,
which indicates if the file was newly created, moved, etc. in the
change. We now serialize it as a human readable string in the API.

Additionally basic unit tests have been added for the FileDiff API, as
they did not previously exist.

Ran unit tests.

Description From Last Updated

'logging' imported but unused

reviewbotreviewbot

Col: 17 E126 continuation line over-indented for hanging indent

reviewbotreviewbot

Col: 1 W391 blank line at end of file

reviewbotreviewbot

This needs a real description.

daviddavid
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/models.py
        reviewboard/webapi/resources/filediff.py
        reviewboard/webapi/tests/test_filediff.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/models.py
        reviewboard/webapi/resources/filediff.py
        reviewboard/webapi/tests/test_filediff.py
    
    
  2.  'logging' imported but unused
    
  3. Col: 17
     E126 continuation line over-indented for hanging indent
    
  4. Col: 1
     W391 blank line at end of file
    
  5. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/models.py
        reviewboard/webapi/resources/filediff.py
        reviewboard/webapi/tests/test_filediff.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/models.py
        reviewboard/webapi/resources/filediff.py
        reviewboard/webapi/tests/test_filediff.py
    
    
  2. 
      
david
  1. 
      
  2. This needs a real description.

  3. 
      
brennie
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/diffviewer/models.py
        reviewboard/webapi/resources/filediff.py
        reviewboard/webapi/tests/test_filediff.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/diffviewer/models.py
        reviewboard/webapi/resources/filediff.py
        reviewboard/webapi/tests/test_filediff.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
  1. Ship It!
  2. 
      
brennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (732ac0f)
Loading...