Adding custom message in banner
Review Request #8824 — Created March 18, 2017 and submitted
| Information | |
|---|---|
| khp | |
| Review Board | |
| master | |
|
|
|
| 8861, 8847 | |
| Reviewers | |
| reviewboard, students | |
Read-only mode is a feature that can be enabled by the admin to disable
most backend changes by regular users. This commit adds a custom
message for the banner when in read-only mode. The message can be
optionally added through the admin panel right under where the admin
would enable/disable read-only mode.
Ran js-tests - passed
Ran python tests - most passed, some failures fixed in future commit
Checked changing value in admin panel reflects in banner
| Description | From | Last Updated |
|---|---|---|
|
Mind wrapping your description & testing done at 72 characters? |
 brennie
|
|
|
Care to add the keys to this? |
brennie
|
|
|
How about "A custom message displayed when the site is in read-only mode." |
brennie
|
|
|
<b> is deprecated. Since you're making this a header, how about just using h2 (since its not the main header … |
brennie
|
|
|
"dictionary will" |
brennie
|
|
|
:py:class:`bool` |
brennie
|
|
|
Blank line between these. |
brennie
|
|
|
string is not a type, you mean unicode. Also, this won't auto link to the correct type. Use: :py:class:`unicode` |
brennie
|
-
-
-
reviewboard/admin/forms.py (Diff revision 1) How about "A custom message displayed when the site is in read-only mode."
-
reviewboard/templates/base.html (Diff revision 1) <b>is deprecated. Since you're making this a header, how about just usingh2(since its not the main header of the page, which is whath1should usually be used for) instead of<span><b>
KH
Diff: |
Revision 2 (+34 -5) |
|---|
Checks run (2 succeeded, 1 failed with error)
JSHint
passed.
PEP8 Style Checker
internal error.
Pyflakes
passed.
KH
Summary: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||
Testing Done: |
|
|||||||||
Depends On: |
-
Minor nitpicks. Looks good to me!
-
-
-
-
reviewboard/admin/context_processors.py (Diff revision 2) stringis not a type, you meanunicode.Also, this won't auto link to the correct type. Use:
:py:class:`unicode`
KH
Change Summary:
Update according to comments + fix description line wrapping
Description: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Diff: |
Revision 3 (+35 -5) |
Checks run (2 succeeded, 1 failed with error)
JSHint
passed.
PEP8 Style Checker
internal error.
Pyflakes
passed.
Tool: Pyflakes Processed Files: reviewboard/admin/context_processors.py reviewboard/admin/forms.py Ignored Files: reviewboard/static/rb/css/pages/base.less reviewboard/static/rb/css/defs.less reviewboard/templates/base.html Tool: PEP8 Style Checker Processed Files: reviewboard/admin/context_processors.py reviewboard/admin/forms.py Ignored Files: reviewboard/static/rb/css/pages/base.less reviewboard/static/rb/css/defs.less reviewboard/templates/base.html