easy scm control - make it easier to modify (add, remove, reorder) SCM used in post-review

Review Request #882 — Created June 5, 2009 and submitted


Review Board SVN (deprecated)


Moved list (well tuple) of SCM client's out of determine_client() and into a global variable. This variable is now written one SCM per line (with a trailing comma on the last SCM). The aim of this is easier modification of post-review, either from monkey patching externally or with customized copies that are used for internal projects. This also makes it easier for a developer to add support for an SCM, track trunk and once they are ready publish their diffs so the new SCM support can be added easily.

See mailing list discussion thread;


  2. Space on both sides of =.
    Also, this should be named SCMCLIENTS, and should appear near the top of the file, after configuration.
    1. Thanks for the white space comments.
      Because this is dependent on the XXXXClient implmentation the earliest this can be defined is after they are defined (unless we switch to a list of names [i.e. strings]). I have moved it as early as possible though. New diff posted.
  3. Trailing whitespace.
Review request changed
Change Summary:
Moved location, renamed client list, white space clean up
  1. Looks good, thanks. Committed as r2045.