Summary

easy scm control - make it easier to modify (add, remove, reorder) SCM used in post-review

Review Request #882 — Created June 5, 2009 and submitted

Information

Owner

clach04

Repository

Review Board SVN (deprecated)

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Moved list (well tuple) of SCM client's out of determine_client() and into a global variable. This variable is now written one SCM per line (with a trailing comma on the last SCM). The aim of this is easier modification of post-review, either from monkey patching externally or with customized copies that are used for internal projects. This also makes it easier for a developer to add support for an SCM, track trunk and once they are ready publish their diffs so the new SCM support can be added easily.

See mailing list discussion thread;

http://groups.google.com/group/reviewboard/t/fcf9bf3e6c87d2f0

Testing Done

http://reviewboard.googlecode.com/svn/trunk/rbtools/scripts/post-review (Diff revision 2)

Space on both sides of =.

Also, this should be named SCMCLIENTS, and should appear near the top of the file, after configuration.

clach04 July 17, 2009, 4:51 a.m.

Thanks for the white space comments.

Because this is dependent on the XXXXClient implmentation the earliest this can be defined is after they are defined (unless we switch to a list of names [i.e. strings]). I have moved it as early as possible though. New diff posted.

http://reviewboard.googlecode.com/svn/trunk/rbtools/scripts/post-review (Diff revision 2)

Trailing whitespace.

Change Summary:

Moved location, renamed client list, white space clean up

Diff:

Revision 3 (+10 -2)

Show changes

http://reviewboard.googlecode.com/svn/trunk/rbtools/scripts/post-review

Ship it!

```
Looks good, thanks. Committed as r2045.
```