Improve naming and allow for custom keys in our AES encryption methods.

Review Request #8814 - Created March 12, 2017 and updated

Christian Hammond
Review Board
release-2.5.x
7d03724...
reviewboard
Our AES encryption/decryption methods were primarily intended for
internal use, but a use case has cropped up that requires using a custom
encryption key. This change adds that support, and improves the naming
of our encryption/decryption methods to spell out that they're for AES
specifically. The old methods remain but raise deprecation warnings.

There's also a new method for getting the default AES encryption key,
preventing callers from having to do their own logic here if they want
to supply the same key to an encryption method.

Unit tests pass.

  • 1
  • 0
  • 0
  • 1
Description From Last Updated
If key is actually bytes, it's not correct to call encode here. You're also doing the encode inside get_default_aes_encryption_key. David Trowbridge David Trowbridge
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/tests/test_crypto_utils.py
        reviewboard/scmtools/crypto_utils.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/tests/test_crypto_utils.py
        reviewboard/scmtools/crypto_utils.py
    
    
David Trowbridge
  1. 
      
  2. reviewboard/scmtools/crypto_utils.py (Diff revision 1)
     
     

    If key is actually bytes, it's not correct to call encode here. You're also doing the encode inside get_default_aes_encryption_key.

Loading...