Improve naming and allow for custom keys in our AES encryption methods.
Review Request #8814 — Created March 12, 2017 and submitted
Our AES encryption/decryption methods were primarily intended for internal use, but a use case has cropped up that requires using a custom encryption key. This change adds that support, and improves the naming of our encryption/decryption methods to spell out that they're for AES specifically. The old methods remain but raise deprecation warnings. There's also a new method for getting the default AES encryption key, preventing callers from having to do their own logic here if they want to supply the same key to an encryption method.
Unit tests pass.
| Description | From | Last Updated |
|---|---|---|
|
If key is actually bytes, it's not correct to call encode here. You're also doing the encode inside get_default_aes_encryption_key. |
 david
|
-
-
reviewboard/scmtools/crypto_utils.py (Diff revision 1) If
keyis actuallybytes, it's not correct to callencodehere. You're also doing theencodeinsideget_default_aes_encryption_key.
Change Summary:
- Added validation to require all keys to be
bytes. - Removed the
encodein_create_cipher.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+205 -20) |
Checks run (3 succeeded)
JSHint
passed.
PEP8 Style Checker
passed.
Pyflakes
passed.
Tool: Pyflakes Processed Files: reviewboard/scmtools/tests/test_crypto_utils.py reviewboard/scmtools/crypto_utils.py Tool: PEP8 Style Checker Processed Files: reviewboard/scmtools/tests/test_crypto_utils.py reviewboard/scmtools/crypto_utils.py