Fix a couple tiny definition errors in the user file attachments resource.

Review Request #8808 — Created March 9, 2017 and submitted

Information

Review Board
release-3.0.x
bf90c28...

Reviewers

This change fixes an error in the resource name for the
UserFileAttachmentResource (which was causing the resource to not appear
correctly in the URL templates), as well as updates the item serialization to
look more like the regular FileAttachment does.

Was able to use the user file attachments resource via the RBTools Python API.

Description From Last Updated

Actually, do we really not have any unit test that was caught by this? Can we update them to make …

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/user_file_attachment.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/user_file_attachment.py
    
    
  2. 
      
chipx86
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. Show all issues

    Actually, do we really not have any unit test that was caught by this? Can we update them to make sure they're seeing the correct object?

    1. The unit tests don't use the URI templates

  3. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (52698f7)
Loading...