Fix the integration and extension pages on default Django setups.

Review Request #8791 - Created March 1, 2017 and submitted

Christian Hammond
Djblets
release-0.10.x
aeb8a78...
djblets
The integration and extension pages weren't styled in a way that worked
in the default Django administration UI. There are CSS classes we should
have been working with that would handle some of the important styling
for us, but we were ignoring those and doing the work ourselves, which
only ended up looking correct in Review Board.

The integration listings template in particular was very wrong,
inheriting from the admin change page template, which brought with it
some unwanted static media, elements, and class names.

The extension management scripts were also assuming the presence of a
SITE_ROOT variable, which is defined in Review Board. It also assumed
the API would be in a certain location. Now the API URL is looked up in
the template and passed to the JavaScript, which handles it through
normal Backbone means.

This ends up fixing these pages on Review Board and on default Django
installs, and will help with future administration UI styling work.

Tested the extension and integration pages on Review Board and on a
plain Django administration UI.

Loading file attachments...

  • 0
  • 0
  • 1
  • 0
  • 1
Description From Last Updated
Review Bot
  1. Tool: PEP8 Style Checker
    Ignored Files:
        djblets/integrations/templates/integrations/integration_list.html
        djblets/static/djblets/css/integrations.less
        djblets/static/djblets/css/extensions.less
        djblets/extensions/templates/extensions/extension_list.html
        djblets/static/djblets/js/extensions/models/extensionManagerModel.js
    
    
    
    Tool: Pyflakes
    Ignored Files:
        djblets/integrations/templates/integrations/integration_list.html
        djblets/static/djblets/css/integrations.less
        djblets/static/djblets/css/extensions.less
        djblets/extensions/templates/extensions/extension_list.html
        djblets/static/djblets/js/extensions/models/extensionManagerModel.js
    
    
  2. 
      
David Trowbridge
  1. Screenshot?

  2. Are we doing one or two blank lines between blocks? In the file above this you did two.

  3. 
      
Christian Hammond
Review Bot
  1. Tool: Pyflakes
    Ignored Files:
        djblets/static/djblets/css/integrations.less
        djblets/integrations/templates/integrations/configure_integration.html
        djblets/static/djblets/css/extensions.less
        djblets/extensions/templates/extensions/extension_list.html
        djblets/integrations/templates/integrations/integration_list.html
        djblets/static/djblets/js/extensions/models/extensionManagerModel.js
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        djblets/static/djblets/css/integrations.less
        djblets/integrations/templates/integrations/configure_integration.html
        djblets/static/djblets/css/extensions.less
        djblets/extensions/templates/extensions/extension_list.html
        djblets/integrations/templates/integrations/integration_list.html
        djblets/static/djblets/js/extensions/models/extensionManagerModel.js
    
    
  2. 
      
David Trowbridge
  1. Ship It!
  2. 
      
Christian Hammond
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (ed2e194)
Loading...