Fix the integration and extension pages on default Django setups.
Review Request #8791 — Created March 1, 2017 and submitted
The integration and extension pages weren't styled in a way that worked in the default Django administration UI. There are CSS classes we should have been working with that would handle some of the important styling for us, but we were ignoring those and doing the work ourselves, which only ended up looking correct in Review Board. The integration listings template in particular was very wrong, inheriting from the admin change page template, which brought with it some unwanted static media, elements, and class names. The extension management scripts were also assuming the presence of a SITE_ROOT variable, which is defined in Review Board. It also assumed the API would be in a certain location. Now the API URL is looked up in the template and passed to the JavaScript, which handles it through normal Backbone means. This ends up fixing these pages on Review Board and on default Django installs, and will help with future administration UI styling work.
Tested the extension and integration pages on Review Board and on a
plain Django administration UI.
| Description | From | Last Updated |
|---|---|---|
|
Are we doing one or two blank lines between blocks? In the file above this you did two. |
 david
|
-
Screenshot?
-
djblets/integrations/templates/integrations/integration_list.html (Diff revision 1) Are we doing one or two blank lines between blocks? In the file above this you did two.
Change Summary:
- Fixed a breakage I missed on a standard Djblets install. We need additional scripts in the integration list page.
- Additional CSS fixes for the extension listing.
- Switched to two blank lines between blocks in
integration_list.html.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+98 -71) |
||||
Added Files: |
-
Tool: Pyflakes Ignored Files: djblets/static/djblets/css/integrations.less djblets/integrations/templates/integrations/configure_integration.html djblets/static/djblets/css/extensions.less djblets/extensions/templates/extensions/extension_list.html djblets/integrations/templates/integrations/integration_list.html djblets/static/djblets/js/extensions/models/extensionManagerModel.js Tool: PEP8 Style Checker Ignored Files: djblets/static/djblets/css/integrations.less djblets/integrations/templates/integrations/configure_integration.html djblets/static/djblets/css/extensions.less djblets/extensions/templates/extensions/extension_list.html djblets/integrations/templates/integrations/integration_list.html djblets/static/djblets/js/extensions/models/extensionManagerModel.js
Tool: PEP8 Style Checker Ignored Files: djblets/integrations/templates/integrations/integration_list.html djblets/static/djblets/css/integrations.less djblets/static/djblets/css/extensions.less djblets/extensions/templates/extensions/extension_list.html djblets/static/djblets/js/extensions/models/extensionManagerModel.js Tool: Pyflakes Ignored Files: djblets/integrations/templates/integrations/integration_list.html djblets/static/djblets/css/integrations.less djblets/static/djblets/css/extensions.less djblets/extensions/templates/extensions/extension_list.html djblets/static/djblets/js/extensions/models/extensionManagerModel.js