Allowing forms to submit responses

Review Request #8784 — Created Feb. 26, 2017 and discarded

DanielPBak
Djblets
master
djblets, students

In a case that we want a form to submit its own response (with different headers or a different return path).

This is necessary for python-social-auth disconnects, as those require a POST request to a specific URL.

None, except that it seems to work.

Description From Last Updated

"Submit" should be "return"

brenniebrennie

Please add documentation to save() to indicate that it can return either HttpResponse or None.

brenniebrennie

This should be response or form_response. Python variable names (except constants) are always snake_case.

brenniebrennie

Blank line between these.

brenniebrennie

No parenthesis needed.

brenniebrennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/configforms/views.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/configforms/views.py
    
    
  2. 
      
brennie
  1. 
      
  2. "Submit" should be "return"

  3. Please add documentation to save() to indicate that it can return either HttpResponse or None.

  4. djblets/configforms/views.py (Diff revision 1)
     
     

    This should be response or form_response. Python variable names (except constants) are always snake_case.

  5. djblets/configforms/views.py (Diff revision 1)
     
     
     

    Blank line between these.

  6. djblets/configforms/views.py (Diff revision 1)
     
     

    No parenthesis needed.

  7. 
      
brennie
david
Review request changed

Status: Discarded

Loading...