Add an optional Review Bot worker config file, use for PMD.

Review Request #8769 — Created Feb. 21, 2017 and discarded

Information

ReviewBot
master

Reviewers

I had written the PMD tool for Review Bot to configure the path to the
executable via the UI, but that approach is a little problematic in the case
where there are multiple workers running. In that case, a worker that didn't
have a valid PMD installation would take the task off the queue and then report
an error (even if there was a worker that could handle it).

I've added an optional config file for the worker, which can be used to
configure the path. If the path is unconfigured, or misconfigured, the worker
will not listen for PMD changes.

This config file will be used for more stuff in the future.

Ran the worker and saw that it loaded the config file correctly.

Description From Last Updated

'logging' imported but unused

reviewbotreviewbot

'ToolExecutionError' imported but unused

reviewbotreviewbot
reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        bot/reviewbot/tools/__init__.py
        bot/reviewbot/tools/pmd.py
        bot/reviewbot/tools/cpplint.py
        bot/setup.py
        bot/reviewbot/tools/buildbot.py
        bot/reviewbot/celery.py
        bot/reviewbot/tools/pep8.py
        bot/reviewbot/config.py
    
    Ignored Files:
        README.md
    
    
    
    Tool: Pyflakes
    Processed Files:
        bot/reviewbot/tools/__init__.py
        bot/reviewbot/tools/pmd.py
        bot/reviewbot/tools/cpplint.py
        bot/setup.py
        bot/reviewbot/tools/buildbot.py
        bot/reviewbot/celery.py
        bot/reviewbot/tools/pep8.py
        bot/reviewbot/config.py
    
    Ignored Files:
        README.md
    
    
  2. bot/reviewbot/config.py (Diff revision 1)
     
     
    Show all issues
     'logging' imported but unused
    
  3. bot/reviewbot/tools/pmd.py (Diff revision 1)
     
     
    Show all issues
     'ToolExecutionError' imported but unused
    
  4. 
      
david
Review request changed

Status: Discarded

Loading...