Implemented Djblet's rate-limiting feature in ReviewBoard's authentication form.

Review Request #8768 - Created Feb. 20, 2017 and updated

Raman Dhatt
Review Board
master
8698
1f42f5e...
reviewboard, students

There has been a request to implement a rate-limiting feature in ReviewBoard's authentication form by tracking the number of failed login attempts per IP/username in the cache, along with the last login time, and prevent further logins until some amount of time has passed. This is dependent on review request 8698, where the ratelimiting has been implemented in djblets.

This has been tested manually by attempting to log into reviewboard with an existing username but incorrect password until the maximum number of attempts has been reached. In addition, the number of login attempts and time left before rate limit is over was also tracked during this process using print statements in djblet's ratelimit.py file (more specifically, the dictionary returned from the get_usage_count() method in ratelimit.py).

  • 0
  • 35
  • 0
  • 35
Description From Last Updated
Review Bot
Raman Dhatt
Review Bot
Raman Dhatt
Review Bot
Raman Dhatt
Review Bot
Simon Zhang
Raman Dhatt
Review Bot
Raman Dhatt
Raman Dhatt
Review Bot
Raman Dhatt
Review Bot
Raman Dhatt
Review Bot
Barret Rennie
Raman Dhatt
Review Bot
Raman Dhatt
Review Bot
Christian Hammond
Raman Dhatt
Review Bot
Raman Dhatt
Review Bot
Raman Dhatt
Raman Dhatt
Review Bot
Raman Dhatt
Review Bot
Raman Dhatt
Raman Dhatt
Review Bot
Raman Dhatt
Review request changed

Commit:

-fab85f9683f573ff1d0c9f2bd22118a5c9a7dddb
+1f42f5e3895b4d84ff52bd36f6db5f419514e296

Diff:

Revision 17 (+37 -1)

Show changes

Review Bot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/accounts/forms/auth.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/accounts/forms/auth.py
    
    
Loading...