custom fields

Review Request #8765 - Created Feb. 19, 2017 and discarded

Joyce Zhou
Review Board
master
reviewboard, students

The custome fields allow extension writters to write extensions with custom fields!
Which include:
Date field
Time field
Datetime field
Dropdown field
Checkbox field
Radiobutton field

Javascript unit test for the fields listed above have been done.
Test includes:
Correctly disable the fields when changes are not allowed.
Triggers "saveDraft" event when changes are made.

  • 0
  • 0
  • 104
  • 29
  • 133
Description From Last Updated
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/fields.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/fields.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
  2. reviewboard/reviews/fields.py (Diff revision 1)
     
     
    Col: 1
     E303 too many blank lines (4)
    
  3. reviewboard/reviews/fields.py (Diff revision 1)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  4. reviewboard/reviews/fields.py (Diff revision 1)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  5. reviewboard/reviews/fields.py (Diff revision 1)
     
     
    Col: 31
     W291 trailing whitespace
    
  6. reviewboard/reviews/fields.py (Diff revision 1)
     
     
    Col: 1
     E303 too many blank lines (3)
    
  7. reviewboard/reviews/fields.py (Diff revision 1)
     
     
     undefined name '_populated'
    
  8. reviewboard/reviews/fields.py (Diff revision 1)
     
     
     undefined name '_all_fields'
    
  9. reviewboard/reviews/fields.py (Diff revision 1)
     
     
     undefined name '_all_fields'
    
  10. 
      
Joyce Zhou
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestFieldView.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestFieldView.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
  2. reviewboard/reviews/fields.py (Diff revision 2)
     
     
    Col: 1
     E303 too many blank lines (4)
    
  3. reviewboard/reviews/fields.py (Diff revision 2)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  4. reviewboard/reviews/fields.py (Diff revision 2)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  5. reviewboard/reviews/fields.py (Diff revision 2)
     
     
    Col: 31
     W291 trailing whitespace
    
  6. reviewboard/reviews/fields.py (Diff revision 2)
     
     
    Col: 1
     E303 too many blank lines (3)
    
  7. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     undefined name '_populated'
    
  8. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     undefined name '_all_fields'
    
  9. reviewboard/reviews/fields.py (Diff revision 2)
     
     
     undefined name '_all_fields'
    
  10. 
      
Joyce Zhou
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestFieldView.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestFieldView.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
  2. reviewboard/reviews/fields.py (Diff revision 3)
     
     
    Col: 1
     E303 too many blank lines (4)
    
  3. reviewboard/reviews/fields.py (Diff revision 3)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  4. reviewboard/reviews/fields.py (Diff revision 3)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  5. reviewboard/reviews/fields.py (Diff revision 3)
     
     
    Col: 31
     W291 trailing whitespace
    
  6. reviewboard/reviews/fields.py (Diff revision 3)
     
     
    Col: 1
     E303 too many blank lines (3)
    
  7. reviewboard/reviews/fields.py (Diff revision 3)
     
     
     undefined name '_populated'
    
  8. reviewboard/reviews/fields.py (Diff revision 3)
     
     
     undefined name '_all_fields'
    
  9. reviewboard/reviews/fields.py (Diff revision 3)
     
     
     undefined name '_all_fields'
    
  10. 
      
Raman Dhatt
  1. Hey! Just thought I'd review your code! Looks great, it's mostly blank line and doc stuff. :)

  2. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Ex: 'Return the default...' instead of 'Returns the default...'

    This applies to the rest of your function docs! :)

  3. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Need blank line between 939 and 940.

  4. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  5. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  6. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  7. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Need blank line between 1020 and 1021.

  8. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  9. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  10. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  11. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  12. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Need blank line between 1089 and 1090.

  13. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  14. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  15. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  16. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  17. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Need blank line between 1158 and 1159.

  18. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  19. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    blank line between 1169 and 1170.

  20. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Blank line between 1172 and 1173.

  21. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Blank line needed above this line.

  22. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Blank line needed above this line.

  23. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Blank line needed above this line.

  24. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Blank line needed above this line.

  25. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Blank line needed above this line.

  26. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  27. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    No need for blank line here?

  28. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  29. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Remove one extra blank line here

  30. 
      
Joyce Zhou
Review request changed

Change Summary:

Right I forgot to publish change.....

Commit:

-c546272c896ddc874e70d1d64f148886731d3e1f
+e3080b24a94eafe1fbb2d78c6c150328eea831c9

Diff:

Revision 4 (+869 -32)

Show changes

Checks run (2 failed, 1 failed with error)

JSHint failed.
PEP8 Style Checker internal error.
Pyflakes failed.

JSHint

Pyflakes

Joyce Zhou
Review request changed

Checks run (2 failed, 1 failed with error)

JSHint failed.
PEP8 Style Checker internal error.
Pyflakes failed.

JSHint

Pyflakes

Joyce Zhou
Review request changed

Description:

   

The extension related to this is not posted yet.

~   CheckboxField and RadioButtonField are good now.
~   DateTimeField and DropdownButtonField should not be too bad.
  ~ The timezone for timefield are not yet implemented (so now they are just like a formatted text)
  ~ Text fields are still not done!

-   It's text field which is troublesome...

Commit:

-5c7e47d9bf78a92f5d461b61429fc96fcb2c9ddc
+de2731152f5a53485d519912158913c338089e88

Diff:

Revision 6 (+871 -32)

Show changes

Checks run (2 failed, 1 failed with error)

JSHint failed.
PEP8 Style Checker internal error.
Pyflakes failed.

JSHint

Pyflakes

Joyce Zhou
Review request changed

Summary:

-[WIP] custom fields
+custom fields

Description:

   

The extension related to this is not posted yet.

~   The timezone for timefield are not yet implemented (so now they are just like a formatted text)
  ~ All fields except text fields should be working

-   Text fields are still not done!

Commit:

-de2731152f5a53485d519912158913c338089e88
+c82eb8d413e4950d24210c88546a6ba58ee3adf5

Diff:

Revision 7 (+896 -59)

Show changes

Checks run (2 failed, 1 failed with error)

JSHint failed.
PEP8 Style Checker internal error.
Pyflakes failed.

JSHint

Pyflakes

Joyce Zhou
Review request changed

Change Summary:

This is close to the final one! But not yet!

Description:

~  

The extension related to this is not posted yet.

~   All fields except text fields should be working

  ~

The custome fields allow extension writters to write extensions with custom fields!

  ~ Which include:
  + Date field
  + Time field
  + Datetime field
  + Dropdown field
  + Checkbox field
  + Radiobutton field

Testing Done:

  +

Javascript unit test for the fields listed above have been done.

  + Test includes:
  + Correctly disable the fields when changes are not allowed.
  + Triggers "saveDraft" event when changes are made.

Commit:

-c82eb8d413e4950d24210c88546a6ba58ee3adf5
+792721f4ef429946831128af68e09d342d82a9c8

Diff:

Revision 8 (+1153 -59)

Show changes

Checks run (2 failed, 1 failed with error)

JSHint failed.
PEP8 Style Checker internal error.
Pyflakes failed.

JSHint

Pyflakes

Joyce Zhou
Review request changed

Checks run (2 failed, 1 failed with error)

JSHint failed.
PEP8 Style Checker internal error.
Pyflakes failed.

JSHint

Pyflakes

Joyce Zhou
Review request changed

Checks run (2 failed, 1 failed with error)

JSHint failed.
PEP8 Style Checker internal error.
Pyflakes failed.

JSHint

Pyflakes

David Trowbridge
Review request changed

Status: Discarded

Loading...