Summary

custom fields

Review Request #8765 — Created Feb. 19, 2017 and discarded Aug. 30, 2017, 10:06 a.m.

Information

Owner

joycezhou47

Repository

Review Board

Branch

master

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

The custome fields allow extension writters to write extensions with custom fields!
Which include:
Date field
Time field
Datetime field
Dropdown field
Checkbox field
Radiobutton field

Testing Done

Javascript unit test for the fields listed above have been done.
Test includes:
Correctly disable the fields when changes are not allowed.
Triggers "saveDraft" event when changes are made.

Issues

Description	From	Last Updated
Col: 1 E303 too many blank lines (4)	reviewbot	March 26, 2017, 2:31 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 26, 2017, 2:31 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 26, 2017, 2:31 p.m.
Col: 31 W291 trailing whitespace	reviewbot	March 26, 2017, 2:32 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	March 26, 2017, 2:32 p.m.
undefined name '_populated'	reviewbot	March 26, 2017, 2:32 p.m.
undefined name '_all_fields'	reviewbot	April 1, 2017, 5:45 p.m.
undefined name '_all_fields'	reviewbot	April 1, 2017, 5:45 p.m.
Col: 1 E303 too many blank lines (4)	reviewbot	March 26, 2017, 2:32 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 26, 2017, 2:32 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 26, 2017, 2:32 p.m.
Col: 31 W291 trailing whitespace	reviewbot	March 26, 2017, 2:32 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	March 26, 2017, 2:32 p.m.
undefined name '_populated'	reviewbot	March 26, 2017, 2:32 p.m.
undefined name '_all_fields'	reviewbot	March 26, 2017, 2:32 p.m.
undefined name '_all_fields'	reviewbot	March 26, 2017, 2:32 p.m.
Col: 1 E303 too many blank lines (4)	reviewbot	March 26, 2017, 2:32 p.m.
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Ex: 'Return the …	RK rkdhatt	March 26, 2017, 2:33 p.m.
Need blank line between 939 and 940.	RK rkdhatt	March 26, 2017, 2:33 p.m.
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.	RK rkdhatt	March 26, 2017, 2:33 p.m.
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.	RK rkdhatt	March 26, 2017, 2:33 p.m.
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.	RK rkdhatt	March 26, 2017, 2:33 p.m.
Need blank line between 1020 and 1021.	RK rkdhatt	March 26, 2017, 2:33 p.m.
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.	RK rkdhatt	March 26, 2017, 2:33 p.m.
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.	RK rkdhatt	March 26, 2017, 2:33 p.m.
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.	RK rkdhatt	March 26, 2017, 2:33 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 26, 2017, 2:32 p.m.
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.	RK rkdhatt	March 26, 2017, 2:33 p.m.
Need blank line between 1089 and 1090.	RK rkdhatt	March 26, 2017, 2:33 p.m.
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.	RK rkdhatt	March 26, 2017, 2:33 p.m.
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.	RK rkdhatt	March 26, 2017, 2:33 p.m.
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.	RK rkdhatt	March 26, 2017, 2:33 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 26, 2017, 2:32 p.m.
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.	RK rkdhatt	March 26, 2017, 2:33 p.m.
Need blank line between 1158 and 1159.	RK rkdhatt	March 26, 2017, 2:33 p.m.
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.	RK rkdhatt	March 26, 2017, 2:33 p.m.
Col: 31 W291 trailing whitespace	reviewbot	March 26, 2017, 2:32 p.m.
blank line between 1169 and 1170.	RK rkdhatt	March 26, 2017, 2:33 p.m.
Blank line between 1172 and 1173.	RK rkdhatt	March 26, 2017, 2:33 p.m.
Blank line needed above this line.	RK rkdhatt	March 26, 2017, 2:33 p.m.
Blank line needed above this line.	RK rkdhatt	March 26, 2017, 2:33 p.m.
Blank line needed above this line.	RK rkdhatt	March 26, 2017, 2:33 p.m.
Blank line needed above this line.	RK rkdhatt	March 26, 2017, 2:34 p.m.
Blank line needed above this line.	RK rkdhatt	March 26, 2017, 2:34 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	March 26, 2017, 2:32 p.m.
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.	RK rkdhatt	March 26, 2017, 2:34 p.m.
undefined name '_populated'	reviewbot	March 26, 2017, 2:32 p.m.
No need for blank line here?	RK rkdhatt	March 26, 2017, 2:34 p.m.
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.	RK rkdhatt	March 26, 2017, 2:34 p.m.
undefined name '_all_fields'	reviewbot	March 26, 2017, 2:32 p.m.
undefined name '_all_fields'	reviewbot	March 26, 2017, 2:32 p.m.
Remove one extra blank line here	RK rkdhatt	March 26, 2017, 2:34 p.m.
undefined name '_all_fields'	reviewbot	April 1, 2017, 5:46 p.m.
undefined name '_all_fields'	reviewbot	April 1, 2017, 5:46 p.m.
Col: 45 Expected '===' and instead saw '=='.	reviewbot	April 1, 2017, 5:46 p.m.
Col: 50 Expected '===' and instead saw '=='.	reviewbot	April 1, 2017, 5:46 p.m.
Col: 50 Expected '===' and instead saw '=='.	reviewbot	April 1, 2017, 5:46 p.m.
Col: 50 Expected '===' and instead saw '=='.	reviewbot	April 1, 2017, 5:46 p.m.
Col: 13 'model' is defined but never used.	reviewbot	April 1, 2017, 5:47 p.m.
Col: 27 Expected '!==' and instead saw '!='.	reviewbot	April 1, 2017, 5:47 p.m.
Col: 31 Missing semicolon.	reviewbot	April 1, 2017, 5:47 p.m.
Col: 43 Expected '!==' and instead saw '!='.	reviewbot	April 1, 2017, 5:47 p.m.
Col: 65 ['hour'] is better written in dot notation.	reviewbot	April 1, 2017, 5:47 p.m.
Col: 62 ['period'] is better written in dot notation.	reviewbot	April 1, 2017, 5:48 p.m.
Col: 18 '_saveDatetimeIfChanged' was used before it was defined.	reviewbot	April 1, 2017, 5:48 p.m.
Col: 18 '_readDatetime' was used before it was defined.	reviewbot	April 1, 2017, 5:48 p.m.
Col: 19 '_toAMPM' was used before it was defined.	reviewbot	April 1, 2017, 5:48 p.m.
Col: 50 Missing semicolon.	reviewbot	April 1, 2017, 5:50 p.m.
Col: 46 Missing semicolon.	reviewbot	April 1, 2017, 5:50 p.m.
Col: 18 '_pad' was used before it was defined.	reviewbot	April 1, 2017, 5:50 p.m.
Col: 35 Missing semicolon.	reviewbot	April 1, 2017, 5:50 p.m.
Col: 3 Missing semicolon.	reviewbot	April 1, 2017, 5:50 p.m.
Col: 3 Missing semicolon.	reviewbot	April 1, 2017, 5:50 p.m.
Col: 3 Missing semicolon.	reviewbot	April 1, 2017, 5:50 p.m.
Col: 3 Missing semicolon.	reviewbot	April 1, 2017, 5:50 p.m.
Col: 3 Missing semicolon.	reviewbot	April 1, 2017, 5:53 p.m.
Col: 44 Expected '!==' and instead saw '!='.	reviewbot	April 1, 2017, 5:50 p.m.
Col: 65 ['hour'] is better written in dot notation.	reviewbot	April 1, 2017, 5:50 p.m.
Col: 62 ['period'] is better written in dot notation.	reviewbot	April 1, 2017, 5:50 p.m.
Col: 66 ['hour'] is better written in dot notation.	reviewbot	April 1, 2017, 5:50 p.m.
Col: 62 ['period'] is better written in dot notation.	reviewbot	April 1, 2017, 5:50 p.m.
Col: 11 Missing semicolon.	reviewbot	April 1, 2017, 5:51 p.m.
Col: 18 '_toAMPM' was used before it was defined.	reviewbot	April 1, 2017, 5:51 p.m.
Col: 50 Missing semicolon.	reviewbot	April 1, 2017, 5:51 p.m.
undefined name '_all_fields'	reviewbot	April 7, 2017, 9:35 p.m.
undefined name '_all_fields'	reviewbot	April 7, 2017, 9:35 p.m.
Col: 13 'model' is defined but never used.	reviewbot	April 1, 2017, 5:54 p.m.
Col: 27 Expected '!==' and instead saw '!='.	reviewbot	April 1, 2017, 5:55 p.m.
Col: 43 Expected '!==' and instead saw '!='.	reviewbot	April 1, 2017, 5:56 p.m.
Col: 65 ['hour'] is better written in dot notation.	reviewbot	April 1, 2017, 5:56 p.m.
Col: 62 ['period'] is better written in dot notation.	reviewbot	April 1, 2017, 5:56 p.m.
Col: 18 '_saveDatetimeIfChanged' was used before it was defined.	reviewbot	April 1, 2017, 5:56 p.m.
Col: 18 '_readDatetime' was used before it was defined.	reviewbot	April 1, 2017, 5:56 p.m.
Col: 19 '_toAMPM' was used before it was defined.	reviewbot	April 1, 2017, 5:56 p.m.
Col: 50 Missing semicolon.	reviewbot	April 1, 2017, 5:56 p.m.
Col: 46 Missing semicolon.	reviewbot	April 1, 2017, 5:56 p.m.
Col: 18 '_pad' was used before it was defined.	reviewbot	April 1, 2017, 5:56 p.m.
Col: 5 'TextFieldView' is defined but never used.	reviewbot	April 1, 2017, 5:56 p.m.
Col: 20 'AutoCompleteView' is defined but never used.	reviewbot	April 1, 2017, 5:56 p.m.
Col: 38 'MarkdownCapableView' is defined but never used.	reviewbot	April 1, 2017, 5:56 p.m.
Col: 1 'RadioButtonFieldView' is defined but never used.	reviewbot	April 1, 2017, 5:57 p.m.
Col: 23 'CheckboxFieldView' is defined but never used.	reviewbot	April 1, 2017, 5:57 p.m.
Col: 42 'DataTimeFieldView' is defined but never used.	reviewbot	April 1, 2017, 5:57 p.m.
Col: 1 'DropdownFieldView' is defined but never used.	reviewbot	April 1, 2017, 5:57 p.m.
Col: 35 Missing semicolon.	reviewbot	April 1, 2017, 6 p.m.
Col: 3 Missing semicolon.	reviewbot	April 1, 2017, 6 p.m.
Col: 13 'options' is already defined.	reviewbot	April 1, 2017, 6 p.m.
Col: 15 Missing semicolon.	reviewbot	April 1, 2017, 6:01 p.m.
Col: 50 Missing semicolon.	reviewbot	April 1, 2017, 6:01 p.m.
Col: 46 Missing semicolon.	reviewbot	April 1, 2017, 6:01 p.m.
Col: 11 Missing semicolon.	reviewbot	April 1, 2017, 6:02 p.m.
Col: 10 Unnecessary semicolon.	reviewbot	April 1, 2017, 6:03 p.m.
Col: 15 Missing semicolon.	reviewbot	April 1, 2017, 6:03 p.m.
Col: 50 Missing semicolon.	reviewbot	April 1, 2017, 6:03 p.m.
Col: 46 Missing semicolon.	reviewbot	April 1, 2017, 6:03 p.m.
undefined name '_all_fields'	reviewbot	April 6, 2017, 2:56 p.m.
undefined name '_all_fields'	reviewbot	April 6, 2017, 2:56 p.m.
Col: 13 'f_options' is defined but never used.	reviewbot	April 6, 2017, 2:56 p.m.
undefined name '_all_fields'	reviewbot	April 7, 2017, 9:34 p.m.
undefined name '_all_fields'	reviewbot	April 7, 2017, 9:34 p.m.
Col: 13 'f_options' is defined but never used.	reviewbot	April 7, 2017, 9:34 p.m.
Col: 18 '_pad' was used before it was defined.	reviewbot	April 7, 2017, 9:34 p.m.
undefined name '_all_fields'	reviewbot	April 7, 2017, 9:35 p.m.
undefined name '_all_fields'	reviewbot	April 7, 2017, 9:35 p.m.
Col: 13 'f_options' is defined but never used.	reviewbot	April 7, 2017, 9:35 p.m.
Col: 18 '_pad' was used before it was defined.	reviewbot	April 7, 2017, 9:35 p.m.
undefined name '_all_fields'	reviewbot	April 7, 2017, 9:34 p.m.
undefined name '_all_fields'	reviewbot	April 7, 2017, 9:34 p.m.
Col: 13 'f_options' is defined but never used.	reviewbot	April 7, 2017, 9:34 p.m.
Col: 18 '_pad' was used before it was defined.	reviewbot	April 7, 2017, 9:34 p.m.
undefined name '_all_fields'	reviewbot	April 7, 2017, 9:35 p.m.
undefined name '_all_fields'	reviewbot	April 7, 2017, 9:35 p.m.
Col: 13 'f_options' is defined but never used.	reviewbot	April 7, 2017, 9:36 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/fields.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/fields.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/reviews/fields.py (Diff revision 1)
Show all issues
```
Col: 1
 E303 too many blank lines (4)
```
reviewboard/reviews/fields.py (Diff revision 1)
Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/reviews/fields.py (Diff revision 1)
Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/reviews/fields.py (Diff revision 1)
Show all issues
```
Col: 31
 W291 trailing whitespace
```
reviewboard/reviews/fields.py (Diff revision 1)
Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
reviewboard/reviews/fields.py (Diff revision 1)
Show all issues
```
 undefined name '_populated'
```
reviewboard/reviews/fields.py (Diff revision 1)
Show all issues
```
 undefined name '_all_fields'
```
reviewboard/reviews/fields.py (Diff revision 1)
Show all issues
```
 undefined name '_all_fields'
```

Commit:

-	ba07d71e1afa7a0b432f9788d35cc53490e558f0
+	9a8c8671ad60ea95042230f31b0f26c4ab426bdc

Diff:

Revision 2 (+658 -31)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/fields.py
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/static/rb/js/views/reviewRequestFieldView.js

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestFieldView.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestFieldView.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/reviews/fields.py (Diff revision 2)
Show all issues
```
Col: 1
 E303 too many blank lines (4)
```
reviewboard/reviews/fields.py (Diff revision 2)
Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/reviews/fields.py (Diff revision 2)
Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/reviews/fields.py (Diff revision 2)
Show all issues
```
Col: 31
 W291 trailing whitespace
```
reviewboard/reviews/fields.py (Diff revision 2)
Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
reviewboard/reviews/fields.py (Diff revision 2)
Show all issues
```
 undefined name '_populated'
```
reviewboard/reviews/fields.py (Diff revision 2)
Show all issues
```
 undefined name '_all_fields'
```
reviewboard/reviews/fields.py (Diff revision 2)
Show all issues
```
 undefined name '_all_fields'
```

Description:

~		The extension related to this is not posted yet.
	~	The extension related to this is not posted yet.
	+	CheckboxField and RadioButtonField are good now.
	+	DateTimeField and DropdownButtonField should not be too bad.
	+	It's text field which is troublesome...

Commit:

-	9a8c8671ad60ea95042230f31b0f26c4ab426bdc
+	c546272c896ddc874e70d1d64f148886731d3e1f

Diff:

Revision 3 (+858 -32)

Show changes

	reviewboard/staticbundles.py
	reviewboard/reviews/fields.py
	reviewboard/static/rb/js/views/reviewRequestEditorView.js
	reviewboard/static/rb/js/views/reviewRequestFieldView.js

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestFieldView.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/fields.py
    reviewboard/staticbundles.py

Ignored Files:
    reviewboard/static/rb/js/views/reviewRequestFieldView.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js

reviewboard/reviews/fields.py (Diff revision 3)
Show all issues
```
Col: 1
 E303 too many blank lines (4)
```
reviewboard/reviews/fields.py (Diff revision 3)
Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/reviews/fields.py (Diff revision 3)
Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/reviews/fields.py (Diff revision 3)
Show all issues
```
Col: 31
 W291 trailing whitespace
```
reviewboard/reviews/fields.py (Diff revision 3)
Show all issues
```
Col: 1
 E303 too many blank lines (3)
```
reviewboard/reviews/fields.py (Diff revision 3)
Show all issues
```
 undefined name '_populated'
```
reviewboard/reviews/fields.py (Diff revision 3)
Show all issues
```
 undefined name '_all_fields'
```
reviewboard/reviews/fields.py (Diff revision 3)
Show all issues
```
 undefined name '_all_fields'
```

Hey! Just thought I'd review your code! Looks great, it's mostly blank line and doc stuff. :)

reviewboard/reviews/fields.py (Diff revision 3)

Show all issues

For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Ex: 'Return the default...' instead of 'Returns the default...'
This applies to the rest of your function docs! :)

reviewboard/reviews/fields.py (Diff revision 3)
Show all issues
```
Need blank line between 939 and 940.
```

reviewboard/reviews/fields.py (Diff revision 3)

Show all issues