[WIP] custom fields

Review Request #8765 - Created Feb. 19, 2017 and updated

Joyce Zhou
Review Board
master
c546272...
reviewboard, students

The extension related to this is not posted yet.
CheckboxField and RadioButtonField are good now.
DateTimeField and DropdownButtonField should not be too bad.
It's text field which is troublesome...


  
  • 52
  • 0
  • 0
  • 52
Description From Last Updated
Col: 1 E303 too many blank lines (4) Review Bot Review Bot
Col: 1 E302 expected 2 blank lines, found 1 Review Bot Review Bot
Col: 1 E302 expected 2 blank lines, found 1 Review Bot Review Bot
Col: 31 W291 trailing whitespace Review Bot Review Bot
Col: 1 E303 too many blank lines (3) Review Bot Review Bot
undefined name '_populated' Review Bot Review Bot
undefined name '_all_fields' Review Bot Review Bot
undefined name '_all_fields' Review Bot Review Bot
Col: 1 E303 too many blank lines (4) Review Bot Review Bot
Col: 1 E302 expected 2 blank lines, found 1 Review Bot Review Bot
Col: 1 E302 expected 2 blank lines, found 1 Review Bot Review Bot
Col: 31 W291 trailing whitespace Review Bot Review Bot
Col: 1 E303 too many blank lines (3) Review Bot Review Bot
undefined name '_populated' Review Bot Review Bot
undefined name '_all_fields' Review Bot Review Bot
undefined name '_all_fields' Review Bot Review Bot
Col: 1 E303 too many blank lines (4) Review Bot Review Bot
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Ex: 'Return the ... Raman Dhatt Raman Dhatt
Need blank line between 939 and 940. Raman Dhatt Raman Dhatt
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Raman Dhatt Raman Dhatt
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Raman Dhatt Raman Dhatt
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Raman Dhatt Raman Dhatt
Need blank line between 1020 and 1021. Raman Dhatt Raman Dhatt
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Raman Dhatt Raman Dhatt
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Raman Dhatt Raman Dhatt
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Raman Dhatt Raman Dhatt
Col: 1 E302 expected 2 blank lines, found 1 Review Bot Review Bot
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Raman Dhatt Raman Dhatt
Need blank line between 1089 and 1090. Raman Dhatt Raman Dhatt
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Raman Dhatt Raman Dhatt
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Raman Dhatt Raman Dhatt
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Raman Dhatt Raman Dhatt
Col: 1 E302 expected 2 blank lines, found 1 Review Bot Review Bot
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Raman Dhatt Raman Dhatt
Need blank line between 1158 and 1159. Raman Dhatt Raman Dhatt
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Raman Dhatt Raman Dhatt
Col: 31 W291 trailing whitespace Review Bot Review Bot
blank line between 1169 and 1170. Raman Dhatt Raman Dhatt
Blank line between 1172 and 1173. Raman Dhatt Raman Dhatt
Blank line needed above this line. Raman Dhatt Raman Dhatt
Blank line needed above this line. Raman Dhatt Raman Dhatt
Blank line needed above this line. Raman Dhatt Raman Dhatt
Blank line needed above this line. Raman Dhatt Raman Dhatt
Blank line needed above this line. Raman Dhatt Raman Dhatt
Col: 1 E303 too many blank lines (3) Review Bot Review Bot
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Raman Dhatt Raman Dhatt
undefined name '_populated' Review Bot Review Bot
No need for blank line here? Raman Dhatt Raman Dhatt
For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Raman Dhatt Raman Dhatt
undefined name '_all_fields' Review Bot Review Bot
undefined name '_all_fields' Review Bot Review Bot
Remove one extra blank line here Raman Dhatt Raman Dhatt
Review Bot
Joyce Zhou
Review Bot
Joyce Zhou
Review request changed

Description:

~  

The extension related to this is not posted yet.

  ~

The extension related to this is not posted yet.

  + CheckboxField and RadioButtonField are good now.
  + DateTimeField and DropdownButtonField should not be too bad.
  + It's text field which is troublesome...

Commit:

-9a8c8671ad60ea95042230f31b0f26c4ab426bdc
+c546272c896ddc874e70d1d64f148886731d3e1f

Diff:

Revision 3 (+858 -32)

Show changes

Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestFieldView.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/reviews/fields.py
        reviewboard/staticbundles.py
    
    Ignored Files:
        reviewboard/static/rb/js/views/reviewRequestFieldView.js
        reviewboard/static/rb/js/views/reviewRequestEditorView.js
    
    
  2. reviewboard/reviews/fields.py (Diff revision 3)
     
     
    Col: 1
     E303 too many blank lines (4)
    
  3. reviewboard/reviews/fields.py (Diff revision 3)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  4. reviewboard/reviews/fields.py (Diff revision 3)
     
     
    Col: 1
     E302 expected 2 blank lines, found 1
    
  5. reviewboard/reviews/fields.py (Diff revision 3)
     
     
    Col: 31
     W291 trailing whitespace
    
  6. reviewboard/reviews/fields.py (Diff revision 3)
     
     
    Col: 1
     E303 too many blank lines (3)
    
  7. reviewboard/reviews/fields.py (Diff revision 3)
     
     
     undefined name '_populated'
    
  8. reviewboard/reviews/fields.py (Diff revision 3)
     
     
     undefined name '_all_fields'
    
  9. reviewboard/reviews/fields.py (Diff revision 3)
     
     
     undefined name '_all_fields'
    
Raman Dhatt
  1. Hey! Just thought I'd review your code! Looks great, it's mostly blank line and doc stuff. :)

  2. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood. Ex: 'Return the default...' instead of 'Returns the default...'

    This applies to the rest of your function docs! :)

  3. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Need blank line between 939 and 940.

  4. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  5. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  6. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  7. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Need blank line between 1020 and 1021.

  8. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  9. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  10. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  11. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  12. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Need blank line between 1089 and 1090.

  13. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  14. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  15. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  16. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  17. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Need blank line between 1158 and 1159.

  18. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  19. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    blank line between 1169 and 1170.

  20. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Blank line between 1172 and 1173.

  21. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Blank line needed above this line.

  22. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Blank line needed above this line.

  23. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Blank line needed above this line.

  24. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Blank line needed above this line.

  25. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Blank line needed above this line.

  26. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  27. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    No need for blank line here?

  28. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    For all your one-line summaries in your docs, the sentence has to be present tense/ imperative mood.

  29. reviewboard/reviews/fields.py (Diff revision 3)
     
     

    Remove one extra blank line here

Loading...