Summary

Allow passing "true" to the include-inactive GET param of the user API

Review Request #8758 — Created Feb. 15, 2017 and submitted Feb. 15, 2017, 4:58 p.m.

Information

Owner

brennie

Repository

Review Board

Branch

release-2.5.x

Bugs

Depends On

Commit

dbffaff...

Reviewers

Groups

reviewboard

People

Description

The users list API now supports "true" in addition to "1" as the value
of the include-inactive GET parameter to include inactive users in the
query.

Testing Done

Ran unit tests.

Issues

Description	From	Last Updated
Also True (to keep consistent with ship-it).	chipx86	Feb. 15, 2017, 4:52 p.m.
redefinition of unused 'test_get_include_inactive' from line 72	reviewbot	Feb. 15, 2017, 4:52 p.m.
This can be one statement.	chipx86	Feb. 15, 2017, 4:52 p.m.
This can fit to 2 lines, with the first argument on the assertion line.	chipx86	Feb. 15, 2017, 4:58 p.m.
Same here.	chipx86	Feb. 15, 2017, 4:58 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py

reviewboard/webapi/tests/test_user.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 redefinition of unused 'test_get_include_inactive' from line 72
```

reviewboard/webapi/resources/user.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Also True (to keep consistent with ship-it).
```
reviewboard/webapi/tests/test_user.py (Diff revision 1)
The issue has been resolved. Show all issues
```
This can be one statement.
```

Commit:

791e82be12b0ec12d56e453d9f93502d853a762a

dbffaff5e611e74d8cfdccb78a4e938baace2a44

Diff:

Revision 2 (+23 -9)

Show changes

	reviewboard/webapi/resources/user.py
	reviewboard/webapi/tests/test_user.py

Tool: Pyflakes
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/webapi/resources/user.py
    reviewboard/webapi/tests/test_user.py

Ship it!

reviewboard/webapi/tests/test_user.py (Diff revision 2)
The issue has been resolved. Show all issues
```
This can fit to 2 lines, with the first argument on the assertion line.
```
reviewboard/webapi/tests/test_user.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Same here.
```

Status:: Completed
Change Summary:: Pushed to release-2.5.x (8c486ad)