Allow passing "true" to the include-inactive GET param of the user API

Review Request #8758 - Created Feb. 15, 2017 and submitted

Barret Rennie
Review Board
release-2.5.x
dbffaff...
reviewboard

The users list API now supports "true" in addition to "1" as the value
of the include-inactive GET parameter to include inactive users in the
query.

Ran unit tests.

  • 0
  • 0
  • 5
  • 0
  • 5
Description From Last Updated
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
    
    
  2. reviewboard/webapi/tests/test_user.py (Diff revision 1)
     
     
     redefinition of unused 'test_get_include_inactive' from line 72
    
  3. 
      
Christian Hammond
  1. 
      
  2. reviewboard/webapi/resources/user.py (Diff revision 1)
     
     
     

    Also True (to keep consistent with ship-it).

  3. reviewboard/webapi/tests/test_user.py (Diff revision 1)
     
     
     
     

    This can be one statement.

  4. 
      
Barret Rennie
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
    
    
  2. 
      
Christian Hammond
  1. 
      
  2. reviewboard/webapi/tests/test_user.py (Diff revision 2)
     
     
     
     

    This can fit to 2 lines, with the first argument on the assertion line.

  3. reviewboard/webapi/tests/test_user.py (Diff revision 2)
     
     
     
     

    Same here.

  4. 
      
Barret Rennie
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (8c486ad)
Loading...