Allow passing "true" to the include-inactive GET param of the user API

Review Request #8758 — Created Feb. 15, 2017 and submitted

Information

Review Board
release-2.5.x
dbffaff...

Reviewers

The users list API now supports "true" in addition to "1" as the value
of the include-inactive GET parameter to include inactive users in the
query.

Ran unit tests.

Description From Last Updated

Also True (to keep consistent with ship-it).

chipx86chipx86

redefinition of unused 'test_get_include_inactive' from line 72

reviewbotreviewbot

This can be one statement.

chipx86chipx86

This can fit to 2 lines, with the first argument on the assertion line.

chipx86chipx86

Same here.

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
    
    
  2. reviewboard/webapi/tests/test_user.py (Diff revision 1)
     
     
    Show all issues
     redefinition of unused 'test_get_include_inactive' from line 72
    
  3. 
      
chipx86
  1. 
      
  2. reviewboard/webapi/resources/user.py (Diff revision 1)
     
     
     
    Show all issues

    Also True (to keep consistent with ship-it).

  3. reviewboard/webapi/tests/test_user.py (Diff revision 1)
     
     
     
     
    Show all issues

    This can be one statement.

  4. 
      
brennie
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/webapi/resources/user.py
        reviewboard/webapi/tests/test_user.py
    
    
  2. 
      
chipx86
  1. 
      
  2. reviewboard/webapi/tests/test_user.py (Diff revision 2)
     
     
     
     
    Show all issues

    This can fit to 2 lines, with the first argument on the assertion line.

  3. reviewboard/webapi/tests/test_user.py (Diff revision 2)
     
     
     
     
    Show all issues

    Same here.

  4. 
      
brennie
Review request changed
Status:
Completed
Change Summary:
Pushed to release-2.5.x (8c486ad)