[WIP] Added a floating banner to the diff view

Review Request #8746 - Created Feb. 14, 2017 and updated

Orjan Monsen
Review Board
master
1a05450...
reviewboard, students

We currently have to scroll all the way to the top if we want to be navigated to a
specific diff file.

I added a floating banner to the diff view that sticks to the top of the page when
the user has scrolled down on the page. On this banner, I will further add a
collapsed list of the diff files, showing only the the file that the user is currently
looking at. The user will be able to expand this list to navigate to the other files.

I have tested the floating banner on the dev server on review requests with multiple
diff files.
The banner has been tested on Chrome, Safari, and Firefox. Further testing on other
browsers is required.

  • 0
  • 10
  • 2
  • 12
Description From Last Updated
Review Bot
Orjan Monsen
Orjan Monsen
Daniel Bak
Orjan Monsen
Review Bot
Orjan Monsen
Review Bot
Orjan Monsen
Review Bot
Orjan Monsen
Review Bot
Raman Dhatt
Orjan Monsen
Review Bot
Orjan Monsen
Review Bot
Orjan Monsen
Review Bot
Orjan Monsen
Review Bot
Barret Rennie
Orjan Monsen
Review Bot
Barret Rennie
Orjan Monsen
Orjan Monsen
Orjan Monsen
Review request changed

Testing Done:

   

I have tested the floating banner on the dev server on review requests with multiple

    diff files.
~   The banner has been tested on Chrome and Safari. Further testing on other browsers
~   must be done.

  ~ The banner has been tested on Chrome, Safari, and Firefox. Further testing on other
  ~ browsers is required.

Commit:

-70ead4405ccaf354b776d798133f143dfb3f39dc
+1a05450f917ad4f2825b012a12dd7be54f75bf73

Diff:

Revision 12 (+274 -66)

Show changes

Checks run (2 succeeded, 0 failed with error)

Pyflakes passed.
PEP8 Style Checker internal error.
JSHint passed.
Loading...