-
-
reviewboard/accounts/forms/pages.py (Diff revision 1) Col: 5 E265 block comment should start with '# '
-
reviewboard/accounts/forms/pages.py (Diff revision 1) Col: 13 E265 block comment should start with '# '
-
reviewboard/accounts/forms/pages.py (Diff revision 1) Col: 9 E265 block comment should start with '# '
-
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 1) local variable 'e' is assigned to but never used
-
-
reviewboard/hostingsvcs/github.py (Diff revision 1) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/reviews/builtin_fields.py (Diff revision 1) Col: 80 E501 line too long (81 > 79 characters)
Create a new Review Request after creating a PR on Github
Review Request #8741 — Created Feb. 12, 2017 and discarded
I didn't have permission to modify r/8437/, so I'm posting this as a separate RR. A decent portion of this diff is stuff that Dominic did. Anything involving social authentication is stuff I did.
Users may now authenticate with GitHub, associating their RR account with their GitHub account. When a webhook pull request is incoming, it will attempt to find a user with that GitHub username and submit it under their name, else it submits it under a dummy account (No_Submitter).
I have also added the ability to authenticate with a BitBucket account. The data is currently not showing up in the database even though it successfully authenticates.
Nothing except testing that it actually works - no unit tests or attempting to break it.
Description | From | Last Updated |
---|---|---|
There's some weird stuff going on in settings.py. It looks like you may have squashed some changes into this one. |
brennie | |
Col: 5 E265 block comment should start with '# ' |
reviewbot | |
Col: 13 E265 block comment should start with '# ' |
reviewbot | |
Col: 9 E265 block comment should start with '# ' |
reviewbot | |
We should use social-auth-core and social-auth-app-django for this. See http://python-social-auth.readthedocs.io/en/latest/. We don't want to limit this too just GitHub. Ideally … |
brennie | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 80 E501 line too long (82 > 79 characters) |
reviewbot | |
Col: 5 E303 too many blank lines (3) |
reviewbot | |
local variable 'e' is assigned to but never used |
reviewbot | |
Col: 22 E225 missing whitespace around operator |
reviewbot | |
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot | |
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot | |
Col: 5 E265 block comment should start with '# ' |
reviewbot | |
Col: 13 E265 block comment should start with '# ' |
reviewbot | |
Col: 9 E265 block comment should start with '# ' |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
Col: 80 E501 line too long (82 > 79 characters) |
reviewbot | |
Col: 5 E303 too many blank lines (3) |
reviewbot | |
local variable 'e' is assigned to but never used |
reviewbot | |
Col: 22 E225 missing whitespace around operator |
reviewbot | |
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot | |
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot | |
'django_reset' imported but unused |
reviewbot | |
'from settings_local import *' used; unable to detect undefined names |
reviewbot | |
'HttpResponseRedirect' imported but unused |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 0 |
reviewbot | |
Col: 5 E303 too many blank lines (3) |
reviewbot | |
Col: 5 E265 block comment should start with '# ' |
reviewbot | |
Col: 13 E265 block comment should start with '# ' |
reviewbot | |
Col: 9 E265 block comment should start with '# ' |
reviewbot | |
Col: 1 E302 expected 2 blank lines, found 1 |
reviewbot | |
redefinition of unused 'login_required' from line 3 |
reviewbot | |
'render' imported but unused |
reviewbot | |
Col: 80 E501 line too long (82 > 79 characters) |
reviewbot | |
Col: 5 E303 too many blank lines (3) |
reviewbot | |
local variable 'e' is assigned to but never used |
reviewbot | |
undefined name 'UserSocialAuth' |
reviewbot | |
Col: 22 E225 missing whitespace around operator |
reviewbot | |
Col: 80 E501 line too long (100 > 79 characters) |
reviewbot | |
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot | |
'django_reset' imported but unused |
reviewbot | |
'from settings_local import *' used; unable to detect undefined names |
reviewbot | |
'HttpResponseRedirect' imported but unused |
reviewbot | |
redefinition of unused 'login_required' from line 3 |
reviewbot | |
'render' imported but unused |
reviewbot | |
Col: 48 E225 missing whitespace around operator |
reviewbot | |
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot | |
'django_reset' imported but unused |
reviewbot | |
'from settings_local import *' used; unable to detect undefined names |
reviewbot | |
Imports should be alphabetized. |
brennie | |
redefinition of unused 'login_required' from line 3 |
reviewbot | |
'render' imported but unused |
reviewbot | |
This would go with the django imports asits a 3rd party import. In general, imports are grouped as such: from … |
brennie | |
Undo this. |
brennie | |
See other comment about imports. |
brennie | |
Only one blank line between class methods. |
brennie | |
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot | |
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot | |
'django_reset' imported but unused |
reviewbot | |
These must be added in load_siteconfig in admin/siteconfig.py line 366 with the web api token backend. |
brennie | |
These need to be blank and added to the settings_local template. |
brennie | |
These need to be blank and added to the settings_local template. |
brennie | |
Missing trailing comma. |
brennie | |
'from settings_local import *' used; unable to detect undefined names |
reviewbot | |
Undo this. |
brennie | |
We should only render these if a user hasnt already connected with them. |
brennie | |
Lets put these under social/ or something. Otherwise they are polluting the global URL namespace. |
brennie | |
These would be in settings.py |
brennie | |
redefinition of unused 'login_required' from line 3 |
reviewbot | |
'render' imported but unused |
reviewbot | |
redefinition of unused 'ReviewRequest' from line 51 |
reviewbot | |
redefinition of unused 'User' from line 17 |
reviewbot | |
Col: 5 E303 too many blank lines (2) |
reviewbot | |
Col: 20 E703 statement ends with a semicolon |
reviewbot | |
Col: 5 E303 too many blank lines (2) |
reviewbot | |
Col: 5 E303 too many blank lines (2) |
reviewbot | |
Col: 27 E225 missing whitespace around operator |
reviewbot | |
Col: 43 E251 unexpected spaces around keyword / parameter equals |
reviewbot | |
Col: 45 E251 unexpected spaces around keyword / parameter equals |
reviewbot | |
Col: 65 E251 unexpected spaces around keyword / parameter equals |
reviewbot | |
Col: 67 E251 unexpected spaces around keyword / parameter equals |
reviewbot | |
Col: 80 E501 line too long (132 > 79 characters) |
reviewbot | |
Col: 81 E251 unexpected spaces around keyword / parameter equals |
reviewbot | |
Col: 83 E251 unexpected spaces around keyword / parameter equals |
reviewbot | |
Col: 119 E251 unexpected spaces around keyword / parameter equals |
reviewbot | |
Col: 121 E251 unexpected spaces around keyword / parameter equals |
reviewbot | |
'django_reset' imported but unused |
reviewbot | |
'from settings_local import *' used; unable to detect undefined names |
reviewbot | |
Col: 1 E303 too many blank lines (3) |
reviewbot | |
This file shouldnt be in the diff. |
brennie | |
If you insert the other auth backends correctly, this wont be necessary. See my comment from a while back. |
brennie | |
Undo. |
brennie | |
Blank line between these. |
brennie | |
Undo |
brennie | |
The password backend kludge stuff needs to be undone. |
brennie | |
Undo. |
brennie | |
Can you add documentation to explain what this does? |
brennie | |
Undo. |
brennie | |
Missing a period. |
brennie | |
Use a tuple. This list should not be changing at runtime. |
brennie | |
Review Board |
brennie | |
Single quotes for strings. |
brennie | |
Reformat as: raise ValueError( '... %s' % ', '.join(self.PR_STATUSES) ) |
brennie | |
Reformat as: status_url = self._build_api_url( '%s/statuses/%s % (self._get_repo_api_url(repository), commit) ) |
brennie | |
Missing trailing comma. |
brennie | |
We dont use PEP484. This should be typename, optional, e.g., unicode, optional. |
brennie | |
types should use :py:class:`type` You can just say the response status here instead, e.g. "A 200 OK is returned if … |
brennie | |
Blank line between these |
brennie | |
Blank line between these. |
brennie | |
This corresponds to a header, so it should use the header name X-Hub-Signature. |
brennie | |
dict. Same elsewhere. |
brennie | |
Blank line between these. |
brennie | |
This seems like testing code, yes? |
brennie | |
Should use an invalid password instead. |
brennie | |
You can move that inline. |
brennie | |
Undo |
brennie | |
Undo. |
brennie | |
3rd party stuff should come before reviewboard. |
brennie | |
Undo. |
brennie | |
Looks like youve had a rebase go bad. |
brennie | |
First import should be from __future__ import unicode_literals. |
brennie | |
These methods need docstrings. |
brennie | |
booleans are singletons in python, you will want to use is not True. |
brennie | |
str.format() is quite slow. Use %-interpolation instead. |
brennie | |
Reformat as per other comment. |
brennie | |
We prefer to format as: return { 'social': social, 'user': social.user, 'new_association': True, } No semicolon necessary. |
brennie | |
comments should be complete sentences and end with periods. |
brennie | |
'string' imported but unused |
reviewbot | |
'random.choice' imported but unused |
reviewbot | |
This shouldn't be in the diff. Whats up with this? |
brennie | |
Likewise this also shouldn't be in the diff. |
brennie | |
'social.exceptions.AuthCanceled' imported but unused |
reviewbot | |
undefined name '_' |
reviewbot | |
undefined name '_' |
reviewbot | |
undefined name '_' |
reviewbot | |
'django.http.HttpResponse' imported but unused |
reviewbot | |
'social.exceptions as social_exceptions' imported but unused |
reviewbot | |
'djblets.configforms.forms.ConfigPageForm' imported but unused |
reviewbot | |
'django.contrib.messages' imported but unused |
reviewbot | |
'django.shortcuts.redirect' imported but unused |
reviewbot | |
'django.shortcuts.HttpResponseRedirect' imported but unused |
reviewbot | |
'django.core.urlresolvers.reverse' imported but unused |
reviewbot | |
'django.conf.urls.include' imported but unused |
reviewbot | |
'django.http.HttpResponseRedirect' imported but unused |
reviewbot | |
'django.utils.translation.ugettext_lazy as _' imported but unused |
reviewbot | |
'django.core.urlresolvers.reverse' imported but unused |
reviewbot | |
'djblets.util.decorators.augment_method_from' imported but unused |
reviewbot | |
'djblets.configforms.views.ConfigPagesView' imported but unused |
reviewbot | |
'reviewboard.admin.decorators.superuser_required' imported but unused |
reviewbot |
Description: |
|
---|
-
-
reviewboard/accounts/models.py (Diff revision 1) We should use
social-auth-core
andsocial-auth-app-django
for this. See http://python-social-auth.readthedocs.io/en/latest/. We don't want to limit this too just GitHub. Ideally we would able to link to PRs from GitHub, GitLab, Bitbucket, etc. So a generic notion of a service (likesocial-auth-core
provides) is what we're going to want to do.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+174 -8) |
-
Tool: Pyflakes Processed Files: reviewboard/settings.py reviewboard/accounts/evolutions/__init__.py reviewboard/accounts/forms/pages.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/accounts/evolutions/github_username.py reviewboard/urls.py reviewboard/hostingsvcs/github.py reviewboard/accounts/admin.py reviewboard/accounts/models.py Ignored Files: docs/manual/fixtures/initial_data.json Tool: PEP8 Style Checker Processed Files: reviewboard/settings.py reviewboard/accounts/evolutions/__init__.py reviewboard/accounts/forms/pages.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/accounts/evolutions/github_username.py reviewboard/urls.py reviewboard/hostingsvcs/github.py reviewboard/accounts/admin.py reviewboard/accounts/models.py Ignored Files: docs/manual/fixtures/initial_data.json
-
reviewboard/accounts/forms/pages.py (Diff revision 2) Col: 5 E265 block comment should start with '# '
-
reviewboard/accounts/forms/pages.py (Diff revision 2) Col: 13 E265 block comment should start with '# '
-
reviewboard/accounts/forms/pages.py (Diff revision 2) Col: 9 E265 block comment should start with '# '
-
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 2) local variable 'e' is assigned to but never used
-
-
reviewboard/hostingsvcs/github.py (Diff revision 2) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/reviews/builtin_fields.py (Diff revision 2) Col: 80 E501 line too long (81 > 79 characters)
-
-
reviewboard/settings.py (Diff revision 2) 'from settings_local import *' used; unable to detect undefined names
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+270 -9) |
-
Tool: Pyflakes Processed Files: reviewboard/accounts/urls.py reviewboard/settings.py reviewboard/accounts/views.py reviewboard/accounts/evolutions/__init__.py reviewboard/accounts/pages.py reviewboard/accounts/forms/pages.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/accounts/evolutions/github_username.py reviewboard/urls.py reviewboard/hostingsvcs/github.py reviewboard/accounts/admin.py reviewboard/accounts/models.py Ignored Files: reviewboard/templates/accounts/external_service_auth.html docs/manual/fixtures/initial_data.json Tool: PEP8 Style Checker Processed Files: reviewboard/accounts/urls.py reviewboard/settings.py reviewboard/accounts/views.py reviewboard/accounts/evolutions/__init__.py reviewboard/accounts/pages.py reviewboard/accounts/forms/pages.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/accounts/evolutions/github_username.py reviewboard/urls.py reviewboard/hostingsvcs/github.py reviewboard/accounts/admin.py reviewboard/accounts/models.py Ignored Files: reviewboard/templates/accounts/external_service_auth.html docs/manual/fixtures/initial_data.json
-
-
-
-
reviewboard/accounts/forms/pages.py (Diff revision 3) Col: 5 E265 block comment should start with '# '
-
reviewboard/accounts/forms/pages.py (Diff revision 3) Col: 13 E265 block comment should start with '# '
-
reviewboard/accounts/forms/pages.py (Diff revision 3) Col: 9 E265 block comment should start with '# '
-
-
-
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 3) local variable 'e' is assigned to but never used
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 3) Col: 80 E501 line too long (100 > 79 characters)
-
reviewboard/reviews/builtin_fields.py (Diff revision 3) Col: 80 E501 line too long (81 > 79 characters)
-
-
reviewboard/settings.py (Diff revision 3) 'from settings_local import *' used; unable to detect undefined names
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 4 (+221 -8) |
-
Tool: Pyflakes Processed Files: reviewboard/hostingsvcs/gitlab.py reviewboard/settings.py reviewboard/accounts/views.py reviewboard/accounts/urls.py reviewboard/accounts/pages.py reviewboard/accounts/forms/pages.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/urls.py reviewboard/hostingsvcs/github.py Ignored Files: reviewboard/templates/accounts/external_service_auth.html docs/manual/fixtures/initial_data.json Tool: PEP8 Style Checker Processed Files: reviewboard/hostingsvcs/gitlab.py reviewboard/settings.py reviewboard/accounts/views.py reviewboard/accounts/urls.py reviewboard/accounts/pages.py reviewboard/accounts/forms/pages.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/urls.py reviewboard/hostingsvcs/github.py Ignored Files: reviewboard/templates/accounts/external_service_auth.html docs/manual/fixtures/initial_data.json
-
-
-
-
-
reviewboard/reviews/builtin_fields.py (Diff revision 4) Col: 80 E501 line too long (81 > 79 characters)
-
-
reviewboard/settings.py (Diff revision 4) 'from settings_local import *' used; unable to detect undefined names
Description: |
|
---|
Description: |
|
|||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||||||||||||||
Diff: |
Revision 5 (+217 -8) |
-
Tool: Pyflakes Processed Files: reviewboard/hostingsvcs/gitlab.py reviewboard/settings.py reviewboard/accounts/views.py reviewboard/accounts/urls.py reviewboard/accounts/pages.py reviewboard/accounts/forms/pages.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/urls.py reviewboard/hostingsvcs/github.py Ignored Files: reviewboard/templates/accounts/external_service_auth.html docs/manual/fixtures/initial_data.json Tool: PEP8 Style Checker Processed Files: reviewboard/hostingsvcs/gitlab.py reviewboard/settings.py reviewboard/accounts/views.py reviewboard/accounts/urls.py reviewboard/accounts/pages.py reviewboard/accounts/forms/pages.py reviewboard/reviews/models/review_request.py reviewboard/reviews/builtin_fields.py reviewboard/urls.py reviewboard/hostingsvcs/github.py Ignored Files: reviewboard/templates/accounts/external_service_auth.html docs/manual/fixtures/initial_data.json
-
-
-
-
reviewboard/reviews/builtin_fields.py (Diff revision 5) Col: 80 E501 line too long (81 > 79 characters)
-
-
reviewboard/settings.py (Diff revision 5) 'from settings_local import *' used; unable to detect undefined names
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 5) This would go with the django imports asits a 3rd party import.
In general, imports are grouped as such:
from __future__ import unicode_literals import os # Standard library import django # 3rd Party import reviewboard # The current repo.
-
-
-
-
reviewboard/settings.py (Diff revision 5) These must be added in load_siteconfig in admin/siteconfig.py line 366 with the web api token backend.
-
reviewboard/settings.py (Diff revision 5) These need to be blank and added to the settings_local template.
-
reviewboard/settings.py (Diff revision 5) These need to be blank and added to the settings_local template.
-
-
-
reviewboard/templates/accounts/external_service_auth.html (Diff revision 5) We should only render these if a user hasnt already connected with them.
-
reviewboard/urls.py (Diff revision 5) Lets put these under
social/
or something. Otherwise they are polluting the global URL namespace. -
Branch: |
|
||||
---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 6 (+915 -28) |
-
Tool: Pyflakes Processed Files: reviewboard/hostingsvcs/gitlab.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/accounts/views.py reviewboard/accounts/urls.py reviewboard/accounts/pages.py reviewboard/reviews/evolutions/pull_request.py reviewboard/accounts/forms/pages.py reviewboard/diffviewer/diffutils.py reviewboard/reviews/builtin_fields.py reviewboard/urls.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/hostingsvcs/service.py reviewboard/settings.py reviewboard/hostingsvcs/github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/review.py Ignored Files: reviewboard/templates/base/_nav_support_menu.html reviewboard/templates/accounts/external_service_auth.html docs/manual/fixtures/initial_data.json reviewboard/templates/accounts/claim_github.html
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 6) redefinition of unused 'ReviewRequest' from line 51
-
-
-
reviewboard/settings.py (Diff revision 6) 'from settings_local import *' used; unable to detect undefined names
-
Tool: PEP8 Style Checker Processed Files: reviewboard/hostingsvcs/gitlab.py reviewboard/reviews/models/base_comment.py reviewboard/reviews/evolutions/__init__.py reviewboard/accounts/views.py reviewboard/accounts/urls.py reviewboard/accounts/pages.py reviewboard/reviews/evolutions/pull_request.py reviewboard/accounts/forms/pages.py reviewboard/diffviewer/diffutils.py reviewboard/reviews/builtin_fields.py reviewboard/urls.py reviewboard/hostingsvcs/tests/test_github.py reviewboard/hostingsvcs/service.py reviewboard/settings.py reviewboard/hostingsvcs/github.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/review.py Ignored Files: reviewboard/templates/base/_nav_support_menu.html reviewboard/templates/accounts/external_service_auth.html docs/manual/fixtures/initial_data.json reviewboard/templates/accounts/claim_github.html
-
-
-
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 6) Col: 43 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/hostingsvcs/github.py (Diff revision 6) Col: 45 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/hostingsvcs/github.py (Diff revision 6) Col: 65 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/hostingsvcs/github.py (Diff revision 6) Col: 67 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/hostingsvcs/github.py (Diff revision 6) Col: 80 E501 line too long (132 > 79 characters)
-
reviewboard/hostingsvcs/github.py (Diff revision 6) Col: 81 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/hostingsvcs/github.py (Diff revision 6) Col: 83 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/hostingsvcs/github.py (Diff revision 6) Col: 119 E251 unexpected spaces around keyword / parameter equals
-
reviewboard/hostingsvcs/github.py (Diff revision 6) Col: 121 E251 unexpected spaces around keyword / parameter equals
-
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 7 (+998 -35) |
Checks run (2 succeeded, 1 failed with error)
-
-
-
reviewboard/accounts/backends.py (Diff revision 7) If you insert the other auth backends correctly, this wont be necessary. See my comment from a while back.
-
-
-
-
reviewboard/accounts/forms/pages.py (Diff revision 7) The password backend kludge stuff needs to be undone.
-
-
reviewboard/accounts/middleware.py (Diff revision 7) Can you add documentation to explain what this does?
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 7) Use a tuple. This list should not be changing at runtime.
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 7) Reformat as:
raise ValueError( '... %s' % ', '.join(self.PR_STATUSES) )
-
reviewboard/hostingsvcs/github.py (Diff revision 7) Reformat as:
status_url = self._build_api_url( '%s/statuses/%s % (self._get_repo_api_url(repository), commit) )
-
-
reviewboard/hostingsvcs/github.py (Diff revision 7) We dont use PEP484. This should be
typename, optional
, e.g.,unicode, optional
. -
reviewboard/hostingsvcs/github.py (Diff revision 7) types should use
:py:class:`type`
You can just say the response status here instead, e.g.
"A 200 OK is returned if the review request was updated successfully. Otherwise a 400 Bad Request is returned."
-
-
-
reviewboard/hostingsvcs/github.py (Diff revision 7) This corresponds to a header, so it should use the header name
X-Hub-Signature
. -
-
-
-
-
-
-
-
-
-
-
reviewboard/social/pipeline.py (Diff revision 7) First import should be
from __future__ import unicode_literals
. -
-
reviewboard/social/pipeline.py (Diff revision 7) booleans are singletons in python, you will want to use
is not True
. -
reviewboard/social/pipeline.py (Diff revision 7) str.format()
is quite slow. Use%
-interpolation instead. -
-
reviewboard/social/pipeline.py (Diff revision 7) We prefer to format as:
return { 'social': social, 'user': social.user, 'new_association': True, }
No semicolon necessary.
-
reviewboard/social/pipeline.py (Diff revision 7) comments should be complete sentences and end with periods.
Summary: |
|
||||
---|---|---|---|---|---|
Commit: |
|
||||
Diff: |
Revision 8 (+1002 -3933) |
Checks run (1 failed, 1 succeeded, 1 failed with error)
Pyflakes
-
-
-
reviewboard/social/pipeline.py (Diff revision 8) 'social.exceptions.AuthCanceled' imported but unused
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 9 (+967 -3933) |
Checks run (2 succeeded, 1 failed with error)
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 10 (+1045 -3933) |
Checks run (1 failed, 1 succeeded, 1 failed with error)
Pyflakes
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 11 (+1117 -41) |
Checks run (1 failed, 1 succeeded, 1 failed with error)
Pyflakes
-
reviewboard/accounts/middleware.py (Diff revision 11) 'django.http.HttpResponse' imported but unused
-
reviewboard/accounts/middleware.py (Diff revision 11) 'social.exceptions as social_exceptions' imported but unused
-
reviewboard/social/forms.py (Diff revision 11) 'djblets.configforms.forms.ConfigPageForm' imported but unused
-
-
-
reviewboard/social/forms.py (Diff revision 11) 'django.shortcuts.HttpResponseRedirect' imported but unused
-
reviewboard/social/forms.py (Diff revision 11) 'django.core.urlresolvers.reverse' imported but unused
-
-
reviewboard/social/views.py (Diff revision 11) 'django.http.HttpResponseRedirect' imported but unused
-
reviewboard/social/views.py (Diff revision 11) 'django.utils.translation.ugettext_lazy as _' imported but unused
-
reviewboard/social/views.py (Diff revision 11) 'django.core.urlresolvers.reverse' imported but unused
-
reviewboard/social/views.py (Diff revision 11) 'djblets.util.decorators.augment_method_from' imported but unused
-
reviewboard/social/views.py (Diff revision 11) 'djblets.configforms.views.ConfigPagesView' imported but unused
-
reviewboard/social/views.py (Diff revision 11) 'reviewboard.admin.decorators.superuser_required' imported but unused