Create a new Review Request after creating a PR on Github

Review Request #8741 - Created Feb. 12, 2017 and updated

Daniel Bak
Review Board
dvcs
e0cfbda...
reviewboard, students

I didn't have permission to modify r/8437/, so I'm posting this as a separate RR. A decent portion of this diff is stuff that Dominic did. Anything involving social authentication is stuff I did.

Users may now authenticate with GitHub, associating their RR account with their GitHub account. When a webhook pull request is incoming, it will attempt to find a user with that GitHub username and submit it under their name, else it submits it under a dummy account (No_Submitter).

I have also added the ability to authenticate with a BitBucket account. The data is currently not showing up in the database even though it successfully authenticates.

Nothing except testing that it actually works - no unit tests or attempting to break it.

  • 21
  • 111
  • 17
  • 149
Description From Last Updated
Can you add documentation to explain what this does? Barret Rennie Barret Rennie
This shouldn't be in the diff. Whats up with this? Barret Rennie Barret Rennie
Likewise this also shouldn't be in the diff. Barret Rennie Barret Rennie
undefined name '_' Review Bot Review Bot
undefined name '_' Review Bot Review Bot
undefined name '_' Review Bot Review Bot
'django.http.HttpResponse' imported but unused Review Bot Review Bot
'social.exceptions as social_exceptions' imported but unused Review Bot Review Bot
'djblets.configforms.forms.ConfigPageForm' imported but unused Review Bot Review Bot
'django.contrib.messages' imported but unused Review Bot Review Bot
'django.shortcuts.redirect' imported but unused Review Bot Review Bot
'django.shortcuts.HttpResponseRedirect' imported but unused Review Bot Review Bot
'django.core.urlresolvers.reverse' imported but unused Review Bot Review Bot
'django.conf.urls.include' imported but unused Review Bot Review Bot
'django.http.HttpResponseRedirect' imported but unused Review Bot Review Bot
'django.utils.translation.ugettext_lazy as _' imported but unused Review Bot Review Bot
'django.core.urlresolvers.reverse' imported but unused Review Bot Review Bot
'djblets.util.decorators.augment_method_from' imported but unused Review Bot Review Bot
'djblets.configforms.views.ConfigPagesView' imported but unused Review Bot Review Bot
'reviewboard.admin.decorators.superuser_required' imported but unused Review Bot Review Bot
There's some weird stuff going on in settings.py. It looks like you may have squashed some changes into this one. Barret Rennie Barret Rennie
Review Bot
Daniel Bak
Barret Rennie
Daniel Bak
Review Bot
Daniel Bak
Review Bot
Daniel Bak
Review Bot
Daniel Bak
Daniel Bak
Review Bot
Barret Rennie
Christian Hammond
Daniel Bak
Review Bot
Review Bot
Daniel Bak
Barret Rennie
Daniel Bak
Barret Rennie
Daniel Bak
Daniel Bak
Daniel Bak
Review request changed

Checks run (1 failed, 1 succeeded, 1 failed with error)

JSHint passed.
PEP8 Style Checker internal error.
Pyflakes failed.

Pyflakes

Loading...