Create a new Review Request after creating a PR on Github - duplicate [WIP]

Review Request #8741 - Created Feb. 12, 2017 and updated

Daniel Bak
Review Board
dvcs
6ce94eb...
reviewboard, students

I didn't have permission to modify r/8437/, so I'm posting this as a separate RR. A decent portion of this diff is stuff that Dominic did. Anything involving social authentication is stuff I did.

Users may now authenticate with GitHub, associating their RR account with their GitHub account. When a webhook pull request is incoming, it will attempt to find a user with that GitHub username and submit it under their name, else it submits it under a dummy account (No_Submitter).

I have also added the ability to authenticate with a BitBucket account. The data is currently not showing up in the database even though it successfully authenticates.

Nothing except testing that it actually works - no unit tests or attempting to break it.

  • 1
  • 71
  • 16
  • 88
Description From Last Updated
These would be in settings.py Barret Rennie Barret Rennie
Review Bot
Daniel Bak
Barret Rennie
Daniel Bak
Review Bot
Daniel Bak
Review Bot
Daniel Bak
Review Bot
Daniel Bak
Daniel Bak
Review Bot
Barret Rennie
Christian Hammond
Daniel Bak
Review request changed
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/gitlab.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/accounts/views.py
        reviewboard/accounts/urls.py
        reviewboard/accounts/pages.py
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/accounts/forms/pages.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/urls.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/hostingsvcs/service.py
        reviewboard/settings.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/models/review.py
    
    Ignored Files:
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/templates/accounts/external_service_auth.html
        docs/manual/fixtures/initial_data.json
        reviewboard/templates/accounts/claim_github.html
    
    
  2. reviewboard/accounts/views.py (Diff revision 6)
     
     
     redefinition of unused 'login_required' from line 3
    
  3. reviewboard/accounts/views.py (Diff revision 6)
     
     
     'render' imported but unused
    
  4. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
     redefinition of unused 'ReviewRequest' from line 51
    
  5. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
     redefinition of unused 'User' from line 17
    
  6. reviewboard/settings.py (Diff revision 6)
     
     
     'django_reset' imported but unused
    
  7. reviewboard/settings.py (Diff revision 6)
     
     
     'from settings_local import *' used; unable to detect undefined names
    
Review Bot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/gitlab.py
        reviewboard/reviews/models/base_comment.py
        reviewboard/reviews/evolutions/__init__.py
        reviewboard/accounts/views.py
        reviewboard/accounts/urls.py
        reviewboard/accounts/pages.py
        reviewboard/reviews/evolutions/pull_request.py
        reviewboard/accounts/forms/pages.py
        reviewboard/diffviewer/diffutils.py
        reviewboard/reviews/builtin_fields.py
        reviewboard/urls.py
        reviewboard/hostingsvcs/tests/test_github.py
        reviewboard/hostingsvcs/service.py
        reviewboard/settings.py
        reviewboard/hostingsvcs/github.py
        reviewboard/reviews/models/review_request.py
        reviewboard/reviews/models/review.py
    
    Ignored Files:
        reviewboard/templates/base/_nav_support_menu.html
        reviewboard/templates/accounts/external_service_auth.html
        docs/manual/fixtures/initial_data.json
        reviewboard/templates/accounts/claim_github.html
    
    
  2. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 5
     E303 too many blank lines (2)
    
  3. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 20
     E703 statement ends with a semicolon
    
  4. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 5
     E303 too many blank lines (2)
    
  5. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 5
     E303 too many blank lines (2)
    
  6. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 27
     E225 missing whitespace around operator
    
  7. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 43
     E251 unexpected spaces around keyword / parameter equals
    
  8. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 45
     E251 unexpected spaces around keyword / parameter equals
    
  9. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 65
     E251 unexpected spaces around keyword / parameter equals
    
  10. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 67
     E251 unexpected spaces around keyword / parameter equals
    
  11. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 80
     E501 line too long (132 > 79 characters)
    
  12. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 81
     E251 unexpected spaces around keyword / parameter equals
    
  13. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 83
     E251 unexpected spaces around keyword / parameter equals
    
  14. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 119
     E251 unexpected spaces around keyword / parameter equals
    
  15. reviewboard/hostingsvcs/github.py (Diff revision 6)
     
     
    Col: 121
     E251 unexpected spaces around keyword / parameter equals
    
  16. reviewboard/settings.py (Diff revision 6)
     
     
    Col: 1
     E303 too many blank lines (3)
    
Loading...