Summary

Create a new Review Request after creating a PR on Github

Review Request #8741 — Created Feb. 12, 2017 and discarded Sept. 14, 2021, 11:17 p.m.

Information

Owner

DanielPBak

Repository

Review Board

Branch

dvcs

Bugs

Depends On

Reviewers

Groups

reviewboard, students

People

Description

I didn't have permission to modify r/8437/, so I'm posting this as a separate RR. A decent portion of this diff is stuff that Dominic did. Anything involving social authentication is stuff I did.

Users may now authenticate with GitHub, associating their RR account with their GitHub account. When a webhook pull request is incoming, it will attempt to find a user with that GitHub username and submit it under their name, else it submits it under a dummy account (No_Submitter).

I have also added the ability to authenticate with a BitBucket account. The data is currently not showing up in the database even though it successfully authenticates.

Testing Done

Nothing except testing that it actually works - no unit tests or attempting to break it.

Issues

Description	From	Last Updated
There's some weird stuff going on in settings.py. It looks like you may have squashed some changes into this one.	brennie	April 3, 2017, 8:31 p.m.
Col: 5 E265 block comment should start with '# '	reviewbot	March 5, 2017, 5:28 p.m.
Col: 13 E265 block comment should start with '# '	reviewbot	March 5, 2017, 5:28 p.m.
Col: 9 E265 block comment should start with '# '	reviewbot	March 5, 2017, 5:28 p.m.
We should use social-auth-core and social-auth-app-django for this. See http://python-social-auth.readthedocs.io/en/latest/. We don't want to limit this too just GitHub. Ideally …	brennie	March 5, 2017, 5:36 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 5, 2017, 5:29 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	March 5, 2017, 5:33 p.m.
Col: 5 E303 too many blank lines (3)	reviewbot	March 5, 2017, 5:36 p.m.
local variable 'e' is assigned to but never used	reviewbot	March 5, 2017, 5:36 p.m.
Col: 22 E225 missing whitespace around operator	reviewbot	March 5, 2017, 5:36 p.m.
Col: 80 E501 line too long (100 > 79 characters)	reviewbot	March 5, 2017, 5:36 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	March 5, 2017, 5:36 p.m.
Col: 5 E265 block comment should start with '# '	reviewbot	March 5, 2017, 5:37 p.m.
Col: 13 E265 block comment should start with '# '	reviewbot	March 5, 2017, 5:37 p.m.
Col: 9 E265 block comment should start with '# '	reviewbot	March 5, 2017, 5:37 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 5, 2017, 5:37 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	March 5, 2017, 5:37 p.m.
Col: 5 E303 too many blank lines (3)	reviewbot	March 5, 2017, 5:37 p.m.
local variable 'e' is assigned to but never used	reviewbot	March 5, 2017, 5:37 p.m.
Col: 22 E225 missing whitespace around operator	reviewbot	March 5, 2017, 5:37 p.m.
Col: 80 E501 line too long (100 > 79 characters)	reviewbot	March 5, 2017, 5:37 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	March 5, 2017, 5:37 p.m.
'django_reset' imported but unused	reviewbot	March 5, 2017, 5:37 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 5, 2017, 5:37 p.m.
'HttpResponseRedirect' imported but unused	reviewbot	March 5, 2017, 5:37 p.m.
Col: 1 E302 expected 2 blank lines, found 0	reviewbot	March 5, 2017, 5:37 p.m.
Col: 5 E303 too many blank lines (3)	reviewbot	March 5, 2017, 5:38 p.m.
Col: 5 E265 block comment should start with '# '	reviewbot	March 5, 2017, 5:38 p.m.
Col: 13 E265 block comment should start with '# '	reviewbot	March 5, 2017, 5:38 p.m.
Col: 9 E265 block comment should start with '# '	reviewbot	March 5, 2017, 5:38 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 5, 2017, 5:38 p.m.
redefinition of unused 'login_required' from line 3	reviewbot	March 5, 2017, 5:38 p.m.
'render' imported but unused	reviewbot	March 5, 2017, 5:38 p.m.
Col: 80 E501 line too long (82 > 79 characters)	reviewbot	March 5, 2017, 5:38 p.m.
Col: 5 E303 too many blank lines (3)	reviewbot	March 5, 2017, 5:38 p.m.
local variable 'e' is assigned to but never used	reviewbot	March 5, 2017, 5:38 p.m.
undefined name 'UserSocialAuth'	reviewbot	March 5, 2017, 5:38 p.m.
Col: 22 E225 missing whitespace around operator	reviewbot	March 5, 2017, 5:38 p.m.
Col: 80 E501 line too long (100 > 79 characters)	reviewbot	March 5, 2017, 5:38 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	March 5, 2017, 5:38 p.m.
'django_reset' imported but unused	reviewbot	March 5, 2017, 5:38 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 5, 2017, 5:38 p.m.
'HttpResponseRedirect' imported but unused	reviewbot	March 5, 2017, 5:56 p.m.
redefinition of unused 'login_required' from line 3	reviewbot	March 5, 2017, 5:56 p.m.
'render' imported but unused	reviewbot	March 5, 2017, 5:57 p.m.
Col: 48 E225 missing whitespace around operator	reviewbot	March 5, 2017, 5:57 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	March 5, 2017, 5:57 p.m.
'django_reset' imported but unused	reviewbot	March 5, 2017, 5:57 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 5, 2017, 5:57 p.m.
Imports should be alphabetized.	brennie	March 25, 2017, 1:27 p.m.
redefinition of unused 'login_required' from line 3	reviewbot	March 19, 2017, 1 p.m.
'render' imported but unused	reviewbot	March 19, 2017, 1 p.m.
This would go with the django imports asits a 3rd party import. In general, imports are grouped as such: from …	brennie	March 25, 2017, 1:28 p.m.
Undo this.	brennie	March 25, 2017, 1:28 p.m.
See other comment about imports.	brennie	March 25, 2017, 1:29 p.m.
Only one blank line between class methods.	brennie	March 25, 2017, 1:31 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	March 19, 2017, 1:01 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	March 19, 2017, 1:01 p.m.
'django_reset' imported but unused	reviewbot	March 19, 2017, 1:01 p.m.
These must be added in load_siteconfig in admin/siteconfig.py line 366 with the web api token backend.	brennie	April 1, 2017, 1:31 p.m.
These need to be blank and added to the settings_local template.	brennie	March 15, 2017, 6:08 p.m.
These need to be blank and added to the settings_local template.	brennie	March 15, 2017, 6:08 p.m.
Missing trailing comma.	brennie	March 25, 2017, 1:34 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 19, 2017, 1:01 p.m.
Undo this.	brennie	March 25, 2017, 1:35 p.m.
We should only render these if a user hasnt already connected with them.	brennie	March 25, 2017, 2:42 p.m.
Lets put these under social/ or something. Otherwise they are polluting the global URL namespace.	brennie	March 25, 2017, 3:01 p.m.
These would be in settings.py	brennie	April 1, 2017, 1:31 p.m.
redefinition of unused 'login_required' from line 3	reviewbot	March 25, 2017, 12:49 p.m.
'render' imported but unused	reviewbot	March 25, 2017, 12:49 p.m.
redefinition of unused 'ReviewRequest' from line 51	reviewbot	March 25, 2017, 12:50 p.m.
redefinition of unused 'User' from line 17	reviewbot	March 25, 2017, 12:50 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	March 25, 2017, 1:12 p.m.
Col: 20 E703 statement ends with a semicolon	reviewbot	March 25, 2017, 1:12 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	March 25, 2017, 1:13 p.m.
Col: 5 E303 too many blank lines (2)	reviewbot	March 25, 2017, 1:13 p.m.
Col: 27 E225 missing whitespace around operator	reviewbot	March 25, 2017, 1:14 p.m.
Col: 43 E251 unexpected spaces around keyword / parameter equals	reviewbot	March 25, 2017, 1:23 p.m.
Col: 45 E251 unexpected spaces around keyword / parameter equals	reviewbot	March 25, 2017, 1:24 p.m.
Col: 65 E251 unexpected spaces around keyword / parameter equals	reviewbot	March 25, 2017, 1:24 p.m.
Col: 67 E251 unexpected spaces around keyword / parameter equals	reviewbot	March 25, 2017, 1:24 p.m.
Col: 80 E501 line too long (132 > 79 characters)	reviewbot	March 25, 2017, 1:24 p.m.
Col: 81 E251 unexpected spaces around keyword / parameter equals	reviewbot	March 25, 2017, 1:24 p.m.
Col: 83 E251 unexpected spaces around keyword / parameter equals	reviewbot	March 25, 2017, 1:24 p.m.
Col: 119 E251 unexpected spaces around keyword / parameter equals	reviewbot	March 25, 2017, 1:24 p.m.
Col: 121 E251 unexpected spaces around keyword / parameter equals	reviewbot	March 25, 2017, 1:24 p.m.
'django_reset' imported but unused	reviewbot	March 25, 2017, 1:09 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 25, 2017, 1:10 p.m.
Col: 1 E303 too many blank lines (3)	reviewbot	March 25, 2017, 1:25 p.m.
This file shouldnt be in the diff.	brennie	April 7, 2017, 4:12 p.m.
If you insert the other auth backends correctly, this wont be necessary. See my comment from a while back.	brennie	April 3, 2017, 12:17 p.m.
Undo.	brennie	April 3, 2017, 12:18 p.m.
Blank line between these.	brennie	April 3, 2017, 12:18 p.m.
Undo	brennie	April 3, 2017, 12:18 p.m.
The password backend kludge stuff needs to be undone.	brennie	April 3, 2017, 12:18 p.m.
Undo.	brennie	April 3, 2017, 12:18 p.m.
Can you add documentation to explain what this does?	brennie	March 27, 2017, 3:26 p.m.
Undo.	brennie	April 3, 2017, 12:19 p.m.
Missing a period.	brennie	April 3, 2017, 12:22 p.m.
Use a tuple. This list should not be changing at runtime.	brennie	April 3, 2017, 12:22 p.m.
Review Board	brennie	April 3, 2017, 12:23 p.m.
Single quotes for strings.	brennie	April 3, 2017, 12:23 p.m.
Reformat as: raise ValueError( '... %s' % ', '.join(self.PR_STATUSES) )	brennie	April 3, 2017, 12:23 p.m.
Reformat as: status_url = self._build_api_url( '%s/statuses/%s % (self._get_repo_api_url(repository), commit) )	brennie	April 3, 2017, 12:24 p.m.
Missing trailing comma.	brennie	April 3, 2017, 12:24 p.m.
We dont use PEP484. This should be typename, optional, e.g., unicode, optional.	brennie	April 3, 2017, 12:25 p.m.
types should use :py:class:`type` You can just say the response status here instead, e.g. "A 200 OK is returned if …	brennie	April 3, 2017, 12:25 p.m.
Blank line between these	brennie	April 3, 2017, 12:25 p.m.
Blank line between these.	brennie	April 3, 2017, 12:26 p.m.
This corresponds to a header, so it should use the header name X-Hub-Signature.	brennie	April 3, 2017, 12:26 p.m.
dict. Same elsewhere.	brennie	April 3, 2017, 12:56 p.m.
Blank line between these.	brennie	April 3, 2017, 12:57 p.m.
This seems like testing code, yes?	brennie	April 3, 2017, 12:57 p.m.
Should use an invalid password instead.	brennie	April 3, 2017, 12:58 p.m.
You can move that inline.	brennie	April 3, 2017, 12:58 p.m.
Undo	brennie	April 3, 2017, 12:58 p.m.
Undo.	brennie	April 3, 2017, 12:58 p.m.
3rd party stuff should come before reviewboard.	brennie	April 3, 2017, 12:59 p.m.
Undo.	brennie	April 3, 2017, 1:19 p.m.
Looks like youve had a rebase go bad.	brennie	March 27, 2017, 11:04 p.m.
First import should be from __future__ import unicode_literals.	brennie	April 3, 2017, 1 p.m.
These methods need docstrings.	brennie	April 7, 2017, 4:20 p.m.
booleans are singletons in python, you will want to use is not True.	brennie	April 3, 2017, 1 p.m.
str.format() is quite slow. Use %-interpolation instead.	brennie	April 3, 2017, 1:05 p.m.
Reformat as per other comment.	brennie	April 3, 2017, 1:06 p.m.
We prefer to format as: return { 'social': social, 'user': social.user, 'new_association': True, } No semicolon necessary.	brennie	April 3, 2017, 1:06 p.m.
comments should be complete sentences and end with periods.	brennie	April 3, 2017, 1:18 p.m.
'string' imported but unused	reviewbot	April 7, 2017, 4:23 p.m.
'random.choice' imported but unused	reviewbot	April 7, 2017, 4:23 p.m.
This shouldn't be in the diff. Whats up with this?	brennie	April 3, 2017, 8:31 p.m.
Likewise this also shouldn't be in the diff.	brennie	April 3, 2017, 8:31 p.m.
'social.exceptions.AuthCanceled' imported but unused	reviewbot	April 7, 2017, 4:24 p.m.
undefined name '_'	reviewbot	April 7, 2017, 5:41 p.m.
undefined name '_'	reviewbot	April 7, 2017, 5:41 p.m.
undefined name '_'	reviewbot	April 7, 2017, 5:41 p.m.
'django.http.HttpResponse' imported but unused	reviewbot	April 8, 2017, 10:59 a.m.
'social.exceptions as social_exceptions' imported but unused	reviewbot	April 8, 2017, 10:59 a.m.
'djblets.configforms.forms.ConfigPageForm' imported but unused	reviewbot	April 8, 2017, 10:59 a.m.
'django.contrib.messages' imported but unused	reviewbot	April 8, 2017, 10:59 a.m.
'django.shortcuts.redirect' imported but unused	reviewbot	April 8, 2017, 10:59 a.m.
'django.shortcuts.HttpResponseRedirect' imported but unused	reviewbot	April 8, 2017, 10:59 a.m.
'django.core.urlresolvers.reverse' imported but unused	reviewbot	April 8, 2017, 10:59 a.m.
'django.conf.urls.include' imported but unused	reviewbot	April 8, 2017, 10:59 a.m.
'django.http.HttpResponseRedirect' imported but unused	reviewbot	April 8, 2017, 10:59 a.m.
'django.utils.translation.ugettext_lazy as _' imported but unused	reviewbot	April 8, 2017, 10:59 a.m.
'django.core.urlresolvers.reverse' imported but unused	reviewbot	April 8, 2017, 10:59 a.m.
'djblets.util.decorators.augment_method_from' imported but unused	reviewbot	April 8, 2017, 10:59 a.m.
'djblets.configforms.views.ConfigPagesView' imported but unused	reviewbot	April 8, 2017, 10:59 a.m.
'reviewboard.admin.decorators.superuser_required' imported but unused	reviewbot	April 8, 2017, 10:59 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/forms/pages.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/builtin_fields.py
    reviewboard/accounts/evolutions/github_username.py
    reviewboard/hostingsvcs/github.py
    reviewboard/accounts/admin.py
    reviewboard/accounts/models.py

Ignored Files:
    docs/manual/fixtures/initial_data.json



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/forms/pages.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/builtin_fields.py
    reviewboard/accounts/evolutions/github_username.py
    reviewboard/hostingsvcs/github.py
    reviewboard/accounts/admin.py
    reviewboard/accounts/models.py

Ignored Files:
    docs/manual/fixtures/initial_data.json

reviewboard/accounts/forms/pages.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5
 E265 block comment should start with '# '
```
reviewboard/accounts/forms/pages.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 13
 E265 block comment should start with '# '
```
reviewboard/accounts/forms/pages.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 9
 E265 block comment should start with '# '
```
reviewboard/accounts/models.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (3)
```
reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
 local variable 'e' is assigned to but never used
```
reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 22
 E225 missing whitespace around operator
```
reviewboard/hostingsvcs/github.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (100 > 79 characters)
```
reviewboard/reviews/builtin_fields.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```

Description:: I didn't have permission to modify r/8437/, so I'm posting this as a separate RR. A decent portion of this diff is stuff that Dominic did. Anything involving "github usernames" is stuff I did.

I have added the ability for a user to specify their GitHub username (in the settings page), and when a webhook pull request is incoming, it will attempt to find a user with that GitHub username and submit it under their name, else it submits it under a dummy account.

~
There is a ton of messiness, I know. Didn't attempt to clean it up whatsoever.
~
There is a ton of messiness, I know. Didn't attempt to clean it up whatsoever. Please don't review this yet, I'm just dumping for the status report!

reviewboard/accounts/models.py (Diff revision 1)

The issue has been resolved. Show all issues

We should use social-auth-core and social-auth-app-django for this. See http://python-social-auth.readthedocs.io/en/latest/. We don't want to limit this too just GitHub. Ideally we would able to link to PRs from GitHub, GitLab, Bitbucket, etc. So a generic notion of a service (like social-auth-core provides) is what we're going to want to do.

Commit:

978f3fc42cf2a4e61feda2a175e59ed6c086d9ee

98505b04723e77f10411958a64faa419ce823787

Diff:

Revision 2 (+174 -8)

Show changes

	docs/manual/fixtures/initial_data.json
	reviewboard/settings.py
	reviewboard/urls.py
	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/accounts/evolutions/__init__.py
	reviewboard/accounts/evolutions/github_username.py
	reviewboard/accounts/forms/pages.py
	3 more

Tool: Pyflakes
Processed Files:
    reviewboard/settings.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/forms/pages.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/builtin_fields.py
    reviewboard/accounts/evolutions/github_username.py
    reviewboard/urls.py
    reviewboard/hostingsvcs/github.py
    reviewboard/accounts/admin.py
    reviewboard/accounts/models.py

Ignored Files:
    docs/manual/fixtures/initial_data.json



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/forms/pages.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/builtin_fields.py
    reviewboard/accounts/evolutions/github_username.py
    reviewboard/urls.py
    reviewboard/hostingsvcs/github.py
    reviewboard/accounts/admin.py
    reviewboard/accounts/models.py

Ignored Files:
    docs/manual/fixtures/initial_data.json

reviewboard/accounts/forms/pages.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 5
 E265 block comment should start with '# '
```
reviewboard/accounts/forms/pages.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 13
 E265 block comment should start with '# '
```
reviewboard/accounts/forms/pages.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 9
 E265 block comment should start with '# '
```
reviewboard/accounts/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (3)
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 local variable 'e' is assigned to but never used
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 22
 E225 missing whitespace around operator
```
reviewboard/hostingsvcs/github.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (100 > 79 characters)
```
reviewboard/reviews/builtin_fields.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Commit:

98505b04723e77f10411958a64faa419ce823787

9a4bb16881527352866c3736227e645dd176301d

Diff:

Revision 3 (+270 -9)

Show changes

	docs/manual/fixtures/initial_data.json
	reviewboard/settings.py
	reviewboard/urls.py
	reviewboard/accounts/admin.py
	reviewboard/accounts/models.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/urls.py
	reviewboard/accounts/views.py
	7 more

Tool: Pyflakes
Processed Files:
    reviewboard/accounts/urls.py
    reviewboard/settings.py
    reviewboard/accounts/views.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/pages.py
    reviewboard/accounts/forms/pages.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/builtin_fields.py
    reviewboard/accounts/evolutions/github_username.py
    reviewboard/urls.py
    reviewboard/hostingsvcs/github.py
    reviewboard/accounts/admin.py
    reviewboard/accounts/models.py

Ignored Files:
    reviewboard/templates/accounts/external_service_auth.html
    docs/manual/fixtures/initial_data.json



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/accounts/urls.py
    reviewboard/settings.py
    reviewboard/accounts/views.py
    reviewboard/accounts/evolutions/__init__.py
    reviewboard/accounts/pages.py
    reviewboard/accounts/forms/pages.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/builtin_fields.py
    reviewboard/accounts/evolutions/github_username.py
    reviewboard/urls.py
    reviewboard/hostingsvcs/github.py
    reviewboard/accounts/admin.py
    reviewboard/accounts/models.py

Ignored Files:
    reviewboard/templates/accounts/external_service_auth.html
    docs/manual/fixtures/initial_data.json

reviewboard/accounts/forms/pages.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 'HttpResponseRedirect' imported but unused
```
reviewboard/accounts/forms/pages.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 0
```
reviewboard/accounts/forms/pages.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (3)
```
reviewboard/accounts/forms/pages.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 5
 E265 block comment should start with '# '
```
reviewboard/accounts/forms/pages.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 13
 E265 block comment should start with '# '
```
reviewboard/accounts/forms/pages.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 9
 E265 block comment should start with '# '
```
reviewboard/accounts/models.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/accounts/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 redefinition of unused 'login_required' from line 3
```
reviewboard/accounts/views.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 'render' imported but unused
```
reviewboard/hostingsvcs/github.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (82 > 79 characters)
```
reviewboard/hostingsvcs/github.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (3)
```
reviewboard/hostingsvcs/github.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 local variable 'e' is assigned to but never used
```
reviewboard/hostingsvcs/github.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 undefined name 'UserSocialAuth'
```
reviewboard/hostingsvcs/github.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 22
 E225 missing whitespace around operator
```
reviewboard/hostingsvcs/github.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (100 > 79 characters)
```
reviewboard/reviews/builtin_fields.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/settings.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 3)
The issue has been resolved. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Commit:

9a4bb16881527352866c3736227e645dd176301d

50e112852047b6ecd0e890108f6392019963ae25

Diff:

Revision 4 (+221 -8)

Show changes

	docs/manual/fixtures/initial_data.json
	reviewboard/settings.py
	reviewboard/urls.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/urls.py
	reviewboard/accounts/views.py
	reviewboard/accounts/forms/pages.py
	reviewboard/hostingsvcs/github.py
	4 more

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/gitlab.py
    reviewboard/settings.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/accounts/pages.py
    reviewboard/accounts/forms/pages.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/builtin_fields.py
    reviewboard/urls.py
    reviewboard/hostingsvcs/github.py

Ignored Files:
    reviewboard/templates/accounts/external_service_auth.html
    docs/manual/fixtures/initial_data.json



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/gitlab.py
    reviewboard/settings.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/accounts/pages.py
    reviewboard/accounts/forms/pages.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/builtin_fields.py
    reviewboard/urls.py
    reviewboard/hostingsvcs/github.py

Ignored Files:
    reviewboard/templates/accounts/external_service_auth.html
    docs/manual/fixtures/initial_data.json

reviewboard/accounts/forms/pages.py (Diff revision 4)
The issue has been resolved. Show all issues
```
 'HttpResponseRedirect' imported but unused
```
reviewboard/accounts/views.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 redefinition of unused 'login_required' from line 3
```
reviewboard/accounts/views.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'render' imported but unused
```
reviewboard/hostingsvcs/github.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 48
 E225 missing whitespace around operator
```
reviewboard/reviews/builtin_fields.py (Diff revision 4)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 4)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Description:: I didn't have permission to modify r/8437/, so I'm posting this as a separate RR. A decent portion of this diff is stuff that Dominic did. Anything involving "github usernames" is stuff I did.

~
I have added the ability for a user to specify their GitHub username (in the settings page), and when a webhook pull request is incoming, it will attempt to find a user with that GitHub username and submit it under their name, else it submits it under a dummy account.
~
Users may now authenticate with GitHub, associating their RR account with their GitHub account. When a webhook pull request is incoming, it will attempt to find a user with that GitHub username and submit it under their name, else it submits it under a dummy account.
-
-
There is a ton of messiness, I know. Didn't attempt to clean it up whatsoever. Please don't review this yet, I'm just dumping for the status report!

Description:

~		I didn't have permission to modify r/8437/, so I'm posting this as a separate RR. A decent portion of this diff is stuff that Dominic did. Anything involving "github usernames" is stuff I did.
	~	I didn't have permission to modify r/8437/, so I'm posting this as a separate RR. A decent portion of this diff is stuff that Dominic did. Anything involving social authentication is stuff I did.

~		Users may now authenticate with GitHub, associating their RR account with their GitHub account. When a webhook pull request is incoming, it will attempt to find a user with that GitHub username and submit it under their name, else it submits it under a dummy account.
	~	Users may now authenticate with GitHub, associating their RR account with their GitHub account. When a webhook pull request is incoming, it will attempt to find a user with that GitHub username and submit it under their name, else it submits it under a dummy account (No_Submitter).
	+
	+	I have also added the ability to authenticate with a BitBucket account. The data is currently not showing up in the database even though it successfully authenticates.

Commit:

50e112852047b6ecd0e890108f6392019963ae25

09d5a5a2fc012b88053e19dbf678ceb086331f8f

Diff:

Revision 5 (+217 -8)

Show changes

	docs/manual/fixtures/initial_data.json
	reviewboard/settings.py
	reviewboard/urls.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/urls.py
	reviewboard/accounts/views.py
	reviewboard/accounts/forms/pages.py
	reviewboard/hostingsvcs/github.py
	4 more

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/gitlab.py
    reviewboard/settings.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/accounts/pages.py
    reviewboard/accounts/forms/pages.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/builtin_fields.py
    reviewboard/urls.py
    reviewboard/hostingsvcs/github.py

Ignored Files:
    reviewboard/templates/accounts/external_service_auth.html
    docs/manual/fixtures/initial_data.json



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/gitlab.py
    reviewboard/settings.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/accounts/pages.py
    reviewboard/accounts/forms/pages.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/builtin_fields.py
    reviewboard/urls.py
    reviewboard/hostingsvcs/github.py

Ignored Files:
    reviewboard/templates/accounts/external_service_auth.html
    docs/manual/fixtures/initial_data.json

reviewboard/accounts/views.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 redefinition of unused 'login_required' from line 3
```
reviewboard/accounts/views.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'render' imported but unused
```
reviewboard/hostingsvcs/github.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```
reviewboard/reviews/builtin_fields.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 5)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

reviewboard/accounts/forms/pages.py (Diff revision 5)
The issue has been dropped. Show all issues
```
Imports should be alphabetized.
```

reviewboard/hostingsvcs/github.py (Diff revision 5)

The issue has been resolved. Show all issues

This would go with the django imports asits a 3rd party import. 
In general, imports are grouped as such:

from __future__ import unicode_literals

import os  # Standard library

import django  # 3rd Party

import reviewboard  # The current repo.

reviewboard/hostingsvcs/github.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Undo this.
```
reviewboard/hostingsvcs/github.py (Diff revision 5)
The issue has been resolved. Show all issues
```
See other comment about imports.
```
reviewboard/hostingsvcs/github.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Only one blank line between class methods.
```

reviewboard/settings.py (Diff revision 5)

The issue has been resolved. Show all issues

These must be added in load_siteconfig in admin/siteconfig.py line 366 with the web api token backend.

reviewboard/settings.py (Diff revision 5)
The issue has been resolved. Show all issues
```
These need to be blank and added to the settings_local template.
```
reviewboard/settings.py (Diff revision 5)
The issue has been resolved. Show all issues
```
These need to be blank and added to the settings_local template.
```
reviewboard/settings.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Missing trailing comma.
```
reviewboard/settings.py (Diff revision 5)
The issue has been resolved. Show all issues
```
Undo this.
```
reviewboard/templates/accounts/external_service_auth.html (Diff revision 5)
The issue has been resolved. Show all issues
```
We should only render these if a user hasnt already connected with them.
```

reviewboard/urls.py (Diff revision 5)

The issue has been resolved. Show all issues

Lets put these under social/ or something. Otherwise they are polluting the global URL namespace.

reviewboard/urls.py (Diff revision 5)
The issue has been resolved. Show all issues
```
These would be in settings.py
```

Can you attach a screenshot of the configuration forms?

Branch:

master

dvcs

Commit:

09d5a5a2fc012b88053e19dbf678ceb086331f8f

6ce94eb347765c701017ebdb5fd2455d4085abe8

Diff:

Revision 6 (+915 -28)

Show changes

	docs/manual/fixtures/initial_data.json
	reviewboard/settings.py
	reviewboard/urls.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/urls.py
	reviewboard/accounts/views.py
	reviewboard/accounts/forms/pages.py
	reviewboard/diffviewer/diffutils.py
	13 more

Tool: Pyflakes
Processed Files:
    reviewboard/hostingsvcs/gitlab.py
    reviewboard/reviews/models/base_comment.py
    reviewboard/reviews/evolutions/__init__.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/accounts/pages.py
    reviewboard/reviews/evolutions/pull_request.py
    reviewboard/accounts/forms/pages.py
    reviewboard/diffviewer/diffutils.py
    reviewboard/reviews/builtin_fields.py
    reviewboard/urls.py
    reviewboard/hostingsvcs/tests/test_github.py
    reviewboard/hostingsvcs/service.py
    reviewboard/settings.py
    reviewboard/hostingsvcs/github.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/review.py

Ignored Files:
    reviewboard/templates/base/_nav_support_menu.html
    reviewboard/templates/accounts/external_service_auth.html
    docs/manual/fixtures/initial_data.json
    reviewboard/templates/accounts/claim_github.html

reviewboard/accounts/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
 redefinition of unused 'login_required' from line 3
```
reviewboard/accounts/views.py (Diff revision 6)
The issue has been resolved. Show all issues
```
 'render' imported but unused
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
 redefinition of unused 'ReviewRequest' from line 51
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
 redefinition of unused 'User' from line 17
```
reviewboard/settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 6)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/hostingsvcs/gitlab.py
    reviewboard/reviews/models/base_comment.py
    reviewboard/reviews/evolutions/__init__.py
    reviewboard/accounts/views.py
    reviewboard/accounts/urls.py
    reviewboard/accounts/pages.py
    reviewboard/reviews/evolutions/pull_request.py
    reviewboard/accounts/forms/pages.py
    reviewboard/diffviewer/diffutils.py
    reviewboard/reviews/builtin_fields.py
    reviewboard/urls.py
    reviewboard/hostingsvcs/tests/test_github.py
    reviewboard/hostingsvcs/service.py
    reviewboard/settings.py
    reviewboard/hostingsvcs/github.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/review.py

Ignored Files:
    reviewboard/templates/base/_nav_support_menu.html
    reviewboard/templates/accounts/external_service_auth.html
    docs/manual/fixtures/initial_data.json
    reviewboard/templates/accounts/claim_github.html

reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 20
 E703 statement ends with a semicolon
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 5
 E303 too many blank lines (2)
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 27
 E225 missing whitespace around operator
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 43
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 45
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 65
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 67
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (132 > 79 characters)
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 81
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 83
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 119
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/hostingsvcs/github.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 121
 E251 unexpected spaces around keyword / parameter equals
```
reviewboard/settings.py (Diff revision 6)
The issue has been resolved. Show all issues
```
Col: 1
 E303 too many blank lines (3)
```

Commit:

6ce94eb347765c701017ebdb5fd2455d4085abe8

76e0a1a01a0f3dd0e377df7941354b94a01db9dc

Diff:

Revision 7 (+998 -35)

Show changes

	docs/manual/fixtures/initial_data.json
	reviewboard/settings.py
	reviewboard/urls.py
	reviewboard/accounts/backends.py
	reviewboard/accounts/middleware.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/urls.py
	reviewboard/accounts/views.py
	17 more

Checks run (2 succeeded, 1 failed with error)

JSHint passed.

PEP8 Style Checker internal error.

Pyflakes passed.

Fix it!

docs/manual/fixtures/initial_data.json (Diff revision 7)
The issue has been resolved. Show all issues
```
This file shouldnt be in the diff.
```

reviewboard/accounts/backends.py (Diff revision 7)

The issue has been resolved. Show all issues

If you insert the other auth backends correctly, this wont be necessary. See my comment from a while back.

reviewboard/accounts/forms/pages.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Undo.
```
reviewboard/accounts/forms/pages.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/accounts/forms/pages.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Undo
```
reviewboard/accounts/forms/pages.py (Diff revision 7)
The issue has been resolved. Show all issues
```
The password backend kludge stuff needs to be undone.
```
reviewboard/accounts/forms/pages.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Undo.
```

reviewboard/accounts/middleware.py (Diff revision 7)

An issue was opened. Show all issues

Can you add documentation to explain what this does?

reviewboard/diffviewer/diffutils.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Undo.
```
reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Missing a period.
```
reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Use a tuple. This list should not be changing at runtime.
```
reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Review Board
```
reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Single quotes for strings.
```

reviewboard/hostingsvcs/github.py (Diff revision 7)

The issue has been resolved. Show all issues

Reformat as:

raise ValueError(
    '... %s'
    % ', '.join(self.PR_STATUSES)
)

reviewboard/hostingsvcs/github.py (Diff revision 7)

The issue has been resolved. Show all issues

Reformat as:

status_url = self._build_api_url(
    '%s/statuses/%s
    % (self._get_repo_api_url(repository), commit)
)

reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Missing trailing comma.
```

reviewboard/hostingsvcs/github.py (Diff revision 7)

The issue has been resolved. Show all issues

We dont use PEP484. This should be typename, optional, e.g., unicode, optional.

reviewboard/hostingsvcs/github.py (Diff revision 7)

The issue has been resolved. Show all issues

types should use :py:class:`type`

You can just say the response status here instead, e.g.

"A 200 OK is returned if the review request was updated successfully. Otherwise a 400 Bad Request is returned."

reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Blank line between these
```
reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been resolved. Show all issues
```
This corresponds to a header, so it should use the header name X-Hub-Signature.
```
reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been resolved. Show all issues
```
dict. Same elsewhere.
```
reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Blank line between these.
```
reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been resolved. Show all issues
```
This seems like testing code, yes?
```
reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Should use an invalid password instead.
```
reviewboard/hostingsvcs/github.py (Diff revision 7)
The issue has been resolved. Show all issues
```
You can move that inline.
```
reviewboard/hostingsvcs/gitlab.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Undo
```
reviewboard/settings.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Undo.
```
reviewboard/settings.py (Diff revision 7)
The issue has been resolved. Show all issues
```
3rd party stuff should come before reviewboard.
```
reviewboard/settings.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Undo.
```

reviewboard/settings.py (Diff revision 7)

The issue has been dropped. Show all issues

Looks like youve had a rebase go bad.

brennie March 27, 2017, 11:05 p.m.

Nevermind I had less than enough coffee when I opened this issue.

reviewboard/social/pipeline.py (Diff revision 7)
The issue has been resolved. Show all issues
```
First import should be from __future__ import unicode_literals.
```
reviewboard/social/pipeline.py (Diff revision 7)
The issue has been resolved. Show all issues
```
These methods need docstrings.
```
reviewboard/social/pipeline.py (Diff revision 7)
The issue has been resolved. Show all issues
```
booleans are singletons in python, you will want to use is not True.
```
reviewboard/social/pipeline.py (Diff revision 7)
The issue has been resolved. Show all issues
```
str.format() is quite slow. Use %-interpolation instead.
```
reviewboard/social/pipeline.py (Diff revision 7)
The issue has been resolved. Show all issues
```
Reformat as per other comment.
```

reviewboard/social/pipeline.py (Diff revision 7)

The issue has been resolved. Show all issues

We prefer to format as:

return {
    'social': social,
    'user': social.user,
    'new_association': True,
}


No semicolon necessary.

reviewboard/social/pipeline.py (Diff revision 7)
The issue has been resolved. Show all issues
```
comments should be complete sentences and end with periods.
```

Summary:

Create a new Review Request after creating a PR on Github - duplicate [WIP]

Create a new Review Request after creating a PR on Github

Commit:

76e0a1a01a0f3dd0e377df7941354b94a01db9dc

2288ef1ac25f2cfbcd5b0194e957ace6dc86b97e

Diff:

Revision 8 (+1002 -3933)

Show changes

	docs/manual/fixtures/initial_data.json
	reviewboard/settings.py
	reviewboard/urls.py
	reviewboard/accounts/backends.py
	reviewboard/accounts/middleware.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/urls.py
	reviewboard/accounts/views.py
	16 more

Checks run (1 failed, 1 succeeded, 1 failed with error)

JSHint passed.

PEP8 Style Checker internal error.

Pyflakes failed.

Pyflakes

reviewboard/hostingsvcs/github.py (Diff revision 8)
The issue has been resolved. Show all issues
```
 'string' imported but unused
```
reviewboard/hostingsvcs/github.py (Diff revision 8)
The issue has been resolved. Show all issues
```
 'random.choice' imported but unused
```
reviewboard/social/pipeline.py (Diff revision 8)
The issue has been resolved. Show all issues
```
 'social.exceptions.AuthCanceled' imported but unused
```

Fix it!

An issue was opened. Show all issues

There's some weird stuff going on in settings.py. It looks like you may have squashed some changes into this one.

reviewboard/settings.py (Diff revision 8)

An issue was opened. Show all issues

This shouldn't be in the diff. Whats up with this?

reviewboard/settings.py (Diff revision 8)

An issue was opened. Show all issues

Likewise this also shouldn't be in the diff.

Commit:

2288ef1ac25f2cfbcd5b0194e957ace6dc86b97e

2214898a7f6d2eba433d0a36b0a56a8f40917c5c

Diff:

Revision 9 (+967 -3933)

Show changes

	docs/manual/fixtures/initial_data.json
	reviewboard/settings.py
	reviewboard/urls.py
	reviewboard/accounts/backends.py
	reviewboard/accounts/middleware.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/urls.py
	reviewboard/accounts/views.py
	16 more

Checks run (2 succeeded, 1 failed with error)

JSHint passed.

PEP8 Style Checker internal error.

Pyflakes passed.

Commit:

2214898a7f6d2eba433d0a36b0a56a8f40917c5c

54f825b56adeb7a907409198edfd78a59fadb1d5

Diff:

Revision 10 (+1045 -3933)

Show changes

	docs/manual/fixtures/initial_data.json
	reviewboard/settings.py
	reviewboard/urls.py
	reviewboard/accounts/backends.py
	reviewboard/accounts/middleware.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/urls.py
	reviewboard/accounts/views.py
	17 more

Checks run (1 failed, 1 succeeded, 1 failed with error)

JSHint passed.

PEP8 Style Checker internal error.

Pyflakes failed.

Pyflakes

reviewboard/social/forms.py (Diff revision 10)
An issue was opened. Show all issues
```
 undefined name '_'
```
reviewboard/social/forms.py (Diff revision 10)
An issue was opened. Show all issues
```
 undefined name '_'
```
reviewboard/social/forms.py (Diff revision 10)
An issue was opened. Show all issues
```
 undefined name '_'
```

Commit:

54f825b56adeb7a907409198edfd78a59fadb1d5

e0cfbdab2219847f8240813fb3876c4c2dd9d02f

Diff:

Revision 11 (+1117 -41)

Show changes

	reviewboard/settings.py
	reviewboard/urls.py
	reviewboard/accounts/backends.py
	reviewboard/accounts/middleware.py
	reviewboard/accounts/pages.py
	reviewboard/accounts/urls.py
	reviewboard/accounts/views.py
	reviewboard/accounts/forms/pages.py
	19 more

Checks run (1 failed, 1 succeeded, 1 failed with error)

JSHint passed.

PEP8 Style Checker internal error.

Pyflakes failed.

Pyflakes

reviewboard/accounts/middleware.py (Diff revision 11)
An issue was opened. Show all issues
```
 'django.http.HttpResponse' imported but unused
```
reviewboard/accounts/middleware.py (Diff revision 11)
An issue was opened. Show all issues
```
 'social.exceptions as social_exceptions' imported but unused
```
reviewboard/social/forms.py (Diff revision 11)
An issue was opened. Show all issues
```
 'djblets.configforms.forms.ConfigPageForm' imported but unused
```
reviewboard/social/forms.py (Diff revision 11)
An issue was opened. Show all issues
```
 'django.contrib.messages' imported but unused
```
reviewboard/social/forms.py (Diff revision 11)
An issue was opened. Show all issues
```
 'django.shortcuts.redirect' imported but unused
```
reviewboard/social/forms.py (Diff revision 11)
An issue was opened. Show all issues
```
 'django.shortcuts.HttpResponseRedirect' imported but unused
```
reviewboard/social/forms.py (Diff revision 11)
An issue was opened. Show all issues
```
 'django.core.urlresolvers.reverse' imported but unused
```
reviewboard/social/urls.py (Diff revision 11)
An issue was opened. Show all issues
```
 'django.conf.urls.include' imported but unused
```
reviewboard/social/views.py (Diff revision 11)
An issue was opened. Show all issues
```
 'django.http.HttpResponseRedirect' imported but unused
```
reviewboard/social/views.py (Diff revision 11)
An issue was opened. Show all issues
```
 'django.utils.translation.ugettext_lazy as _' imported but unused
```
reviewboard/social/views.py (Diff revision 11)
An issue was opened. Show all issues
```
 'django.core.urlresolvers.reverse' imported but unused
```
reviewboard/social/views.py (Diff revision 11)
An issue was opened. Show all issues
```
 'djblets.util.decorators.augment_method_from' imported but unused
```
reviewboard/social/views.py (Diff revision 11)
An issue was opened. Show all issues
```
 'djblets.configforms.views.ConfigPagesView' imported but unused
```

reviewboard/social/views.py (Diff revision 11)

An issue was opened. Show all issues

 'reviewboard.admin.decorators.superuser_required' imported but unused

Status:: Discarded

		I didn't have permission to modify r/8437/, so I'm posting this as a separate RR. A decent portion of this diff is stuff that Dominic did. Anything involving "github usernames" is stuff I did.

		I have added the ability for a user to specify their GitHub username (in the settings page), and when a webhook pull request is incoming, it will attempt to find a user with that GitHub username and submit it under their name, else it submits it under a dummy account.

~		There is a ton of messiness, I know. Didn't attempt to clean it up whatsoever.
	~	There is a ton of messiness, I know. Didn't attempt to clean it up whatsoever. Please don't review this yet, I'm just dumping for the status report!