Summary

Fix a major regression in comment ordering.

Review Request #8739 — Created Feb. 11, 2017 and submitted Feb. 12, 2017, 3:18 p.m.

Information

Owner

chipx86

Repository

Review Board

Branch

release-2.0.x

Bugs

Depends On

Commit

166c15d...

Reviewers

Groups

reviewboard

People

Description

A recent change going into 2.0.26 and 2.5.8 broke comment ordering,
causing them to be ordered by ID and not timestamp. This could greatly
alter reading and composing a review, along with API results. The cause
was the subclasses of BaseComment introducing a Meta that overrode the
one from the parent, instead of subclassing it.

This fixes that by subclassing the parent's meta, inheriting the
ordering. It also removes the app_labels, which were already provided by
the parent.

Testing Done

Unit tests pass.

No longer saw the comment ordering problem in tests.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/reviews/models/screenshot_comment.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/reviews/models/screenshot_comment.py

Ship it!

Good catch. Are we going to need this for GeneralComment on the branches that have it?

Also, I'm kinda surprised we don't have tests on ordering... :/

chipx86 Feb. 11, 2017, 5:26 p.m.

We did. I don't know how it slipped by. I noticed it after the release...

Going to be bullet-proofing things soon so all releases require all tests to pass, rather than that being a manual step. Also, new CI is almost ready.

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-2.0.x (2ce15eb)