Convert URL patterns to lists.

Review Request #8723 - Created Feb. 7, 2017 and updated

David Trowbridge
Review Board
release-3.0.x
c2417de...
reviewboard

Django has deprecated the use of the old patterns() method, since they now
recommend that all URLs pass in the view directly rather than do string magic
to get the module path. This change moves us over to using plain lists of
url() entries, rather than a bunch of calls to patterns().

While I was doing this, I cleaned things up a bit with the regexes (such as
converting [0-9] to \d and [a-zA-Z0-9_] to \w), and changed it so we
only use raw strings where necessary.

Ran unit tests on Django 1.6 and 1.8.

  • 0
  • 12
  • 0
  • 12
Description From Last Updated
Review Bot
Christian Hammond
David Trowbridge
Review Bot
Barret Rennie
Christian Hammond
David Trowbridge
Review Bot
David Trowbridge
Review request changed
Review Bot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/scmtools/admin.py
        reviewboard/hostingsvcs/urls.py
        reviewboard/hostingsvcs/beanstalk.py
        reviewboard/accounts/urls.py
        reviewboard/reviews/urls.py
        reviewboard/hostingsvcs/bitbucket.py
        reviewboard/admin/urls.py
        reviewboard/urls.py
        reviewboard/hostingsvcs/service.py
        reviewboard/search/urls.py
        reviewboard/hostingsvcs/github.py
        reviewboard/hostingsvcs/googlecode.py
        reviewboard/hostingsvcs/tests/test_registration.py
        reviewboard/datagrids/urls.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/scmtools/admin.py
        reviewboard/hostingsvcs/urls.py
        reviewboard/hostingsvcs/beanstalk.py
        reviewboard/accounts/urls.py
        reviewboard/reviews/urls.py
        reviewboard/hostingsvcs/bitbucket.py
        reviewboard/admin/urls.py
        reviewboard/urls.py
        reviewboard/hostingsvcs/service.py
        reviewboard/search/urls.py
        reviewboard/hostingsvcs/github.py
        reviewboard/hostingsvcs/googlecode.py
        reviewboard/hostingsvcs/tests/test_registration.py
        reviewboard/datagrids/urls.py
    
    
Loading...