Fix display of "popup" pages in the admin site.
Review Request #8717 — Created Feb. 6, 2017 and submitted
The admin site has a feature where it can show a pop-up window for some
actions, mostly selecting or creating related objects. We had some logic in the
admin_actions
tag that was supposed to hide the sidebar in these windows, but
that logic was broken (since it was ORing two mutually-exclusive tests). I
fixed it to never even calladmin_actions
for pop-up windows, but that
exposed some issues with the CSS.This change fixes all of that. The pop-up windows still show the header, which
I'm undecided on.
Opened a pop-up from the admin site and saw that it no longer showed the
sidebar.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+22 -28) |
-
Tool: Pyflakes Processed Files: reviewboard/admin/templatetags/rbadmintags.py Ignored Files: reviewboard/templates/admin/widgets/w-actions.html reviewboard/static/rb/css/pages/admin.less reviewboard/templates/admin/base_site.html Tool: PEP8 Style Checker Processed Files: reviewboard/admin/templatetags/rbadmintags.py Ignored Files: reviewboard/templates/admin/widgets/w-actions.html reviewboard/static/rb/css/pages/admin.less reviewboard/templates/admin/base_site.html
Change Summary:
Turn off header via CSS (since it's basically impossible via the templates)
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+26 -28) |
-
Tool: Pyflakes Processed Files: reviewboard/admin/templatetags/rbadmintags.py Ignored Files: reviewboard/templates/admin/widgets/w-actions.html reviewboard/static/rb/css/pages/admin.less reviewboard/templates/admin/base_site.html Tool: PEP8 Style Checker Processed Files: reviewboard/admin/templatetags/rbadmintags.py Ignored Files: reviewboard/templates/admin/widgets/w-actions.html reviewboard/static/rb/css/pages/admin.less reviewboard/templates/admin/base_site.html