Summary

Fix display of "popup" pages in the admin site.

Review Request #8717 — Created Feb. 6, 2017 and submitted Feb. 15, 2017, 3:45 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

7278049...

Reviewers

Groups

reviewboard

People

Description

The admin site has a feature where it can show a pop-up window for some
actions, mostly selecting or creating related objects. We had some logic in the
admin_actions tag that was supposed to hide the sidebar in these windows, but
that logic was broken (since it was ORing two mutually-exclusive tests). I
fixed it to never even call admin_actions for pop-up windows, but that
exposed some issues with the CSS.

This change fixes all of that. The pop-up windows still show the header, which
I'm undecided on.

Testing Done

Opened a pop-up from the admin site and saw that it no longer showed the
sidebar.

Files

Issues

Description	From	Last Updated
I feel like the header is unnecessary. You probably shouldn't be using the popup window for anything other than adding/selecting …	brennie	Feb. 7, 2017, 11:12 p.m.
You can combine these.	chipx86	Feb. 7, 2017, 10:10 a.m.

Tool: Pyflakes
Processed Files:
    reviewboard/admin/templatetags/rbadmintags.py

Ignored Files:
    reviewboard/templates/admin/widgets/w-actions.html
    reviewboard/static/rb/css/pages/admin.less
    reviewboard/templates/admin/base_site.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/templatetags/rbadmintags.py

Ignored Files:
    reviewboard/templates/admin/widgets/w-actions.html
    reviewboard/static/rb/css/pages/admin.less
    reviewboard/templates/admin/base_site.html

reviewboard/templates/admin/base_site.html (Diff revision 1)
The issue has been resolved. Show all issues
```
You can combine these.
```

Commit:

26bab6163aa46d94ab98d5b4ab1e0c8c1a721aa7

60a90e896e24d8df8c5332b125539e0be8327746

Diff:

Revision 2 (+22 -28)

Show changes

	reviewboard/admin/templatetags/rbadmintags.py
	reviewboard/static/rb/css/pages/admin.less
	reviewboard/templates/admin/base_site.html
	reviewboard/templates/admin/widgets/w-actions.html

Tool: Pyflakes
Processed Files:
    reviewboard/admin/templatetags/rbadmintags.py

Ignored Files:
    reviewboard/templates/admin/widgets/w-actions.html
    reviewboard/static/rb/css/pages/admin.less
    reviewboard/templates/admin/base_site.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/templatetags/rbadmintags.py

Ignored Files:
    reviewboard/templates/admin/widgets/w-actions.html
    reviewboard/static/rb/css/pages/admin.less
    reviewboard/templates/admin/base_site.html

After (Revision 1)

The issue has been resolved. Show all issues

I feel like the header is unnecessary. You probably shouldn't be using the popup window for anything other than adding/selecting a model.

If we keep the header, maybe we should slim it down to only show Review Board and the version string (in another change)? Just an idea.

david Feb. 7, 2017, 10:55 a.m.

Yeah, I agree, but it's looking like that might be really hard to do with the current templates.

Change Summary:

Turn off header via CSS (since it's basically impossible via the templates)

Commit:

60a90e896e24d8df8c5332b125539e0be8327746

72780493cd0121bf2fc83ae84f61e3cbf656f2f0

Diff:

Revision 3 (+26 -28)

Show changes

	reviewboard/admin/templatetags/rbadmintags.py
	reviewboard/static/rb/css/pages/admin.less
	reviewboard/templates/admin/base_site.html
	reviewboard/templates/admin/widgets/w-actions.html

Tool: Pyflakes
Processed Files:
    reviewboard/admin/templatetags/rbadmintags.py

Ignored Files:
    reviewboard/templates/admin/widgets/w-actions.html
    reviewboard/static/rb/css/pages/admin.less
    reviewboard/templates/admin/base_site.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/templatetags/rbadmintags.py

Ignored Files:
    reviewboard/templates/admin/widgets/w-actions.html
    reviewboard/static/rb/css/pages/admin.less
    reviewboard/templates/admin/base_site.html

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (cf3cd50)