Add new TEMPLATES setting.

Review Request #8709 — Created Feb. 3, 2017 and submitted

Information

Review Board
release-3.0.x
f0e0b64...

Reviewers

Django 1.8 uses a new, unified TEMPLATES setting. This change adds a definition
for that which is built up from the old broken-out settings. Once we cut over
to 1.8+ entirely we can move everything inline.

Ran unit tests on Django 1.6 and 1.8

Description From Last Updated

Can we put this back before the settings_local import? It's sometimes handy to override these variables there for some testing.

chipx86chipx86

'django_reset' imported but unused

reviewbotreviewbot

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot

'django_reset' imported but unused

reviewbotreviewbot

'from settings_local import *' used; unable to detect undefined names

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/settings.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/settings.py
    
    
  2. reviewboard/settings.py (Diff revision 1)
     
     
    Show all issues
     'django_reset' imported but unused
    
  3. reviewboard/settings.py (Diff revision 1)
     
     
    Show all issues
     'from settings_local import *' used; unable to detect undefined names
    
  4. 
      
brennie
  1. Ship It!
  2. 
      
chipx86
  1. 
      
  2. Show all issues

    Can we put this back before the settings_local import? It's sometimes handy to override these variables there for some testing.

  3. 
      
david
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        reviewboard/settings.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/settings.py
    
    
  2. reviewboard/settings.py (Diff revision 2)
     
     
    Show all issues
     'django_reset' imported but unused
    
  3. reviewboard/settings.py (Diff revision 2)
     
     
    Show all issues
     'from settings_local import *' used; unable to detect undefined names
    
  4. 
      
chipx86
  1. Ship It!
  2. 
      
david
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (7f721f2)
Loading...