Summary

Add new TEMPLATES setting.

Review Request #8709 — Created Feb. 3, 2017 and submitted Feb. 8, 2017, 5:21 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

f0e0b64...

Reviewers

Groups

reviewboard

People

Description

Django 1.8 uses a new, unified TEMPLATES setting. This change adds a definition
for that which is built up from the old broken-out settings. Once we cut over
to 1.8+ entirely we can move everything inline.

Testing Done

Ran unit tests on Django 1.6 and 1.8

Issues

Description	From	Last Updated
Can we put this back before the settings_local import? It's sometimes handy to override these variables there for some testing.	chipx86	Feb. 3, 2017, 10:28 p.m.
'django_reset' imported but unused	reviewbot	Feb. 3, 2017, 2:16 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 3, 2017, 2:16 p.m.
'django_reset' imported but unused	reviewbot	Feb. 3, 2017, 10:30 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	Feb. 3, 2017, 10:30 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/settings.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py

reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 1)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Ship it!

```
Ship It!
```

The issue has been resolved. Show all issues

Can we put this back before the settings_local import? It's sometimes handy to override these variables there for some testing.

Commit:

722d0ab99b60d7ecb593f15c0bacbad3c7c57f61

f0e0b6423ef61ead9f33c74497bc2a1b178e1063

Diff:

Revision 2 (+50 -34)

Show changes

reviewboard/settings.py

Tool: Pyflakes
Processed Files:
    reviewboard/settings.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/settings.py

reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'django_reset' imported but unused
```
reviewboard/settings.py (Diff revision 2)
The issue has been dropped. Show all issues
```
 'from settings_local import *' used; unable to detect undefined names
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (7f721f2)

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 1)

reviewboard/settings.py (Diff revision 2)

reviewboard/settings.py (Diff revision 2)