Summary

Add db_table and verbose_name for all models.

Review Request #8704 — Created Feb. 1, 2017 and submitted Feb. 3, 2017, 10:32 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

2a58b67...

Reviewers

Groups

reviewboard

People

Description

In preparation for making use of Django 1.8's AppConfig for all our apps (and
in doing so, rename them to be reviewboard_* instead of *), we need to
explicitly define the db_table for existing models so as to retain backward
compatibility.

While I was going through here, I also defined verbose_name and
verbose_name_plural for every model, setting them to be localized strings in
title case. We had a mix of things in here, often only defining
verbose_name_plural when we had something that needed to pluralize with "ies"
instead of "s" (and not localized). A recent change added these for the
reviews models, but these were all in lower case.

Testing Done


Ran unit tests.
Started the devserver and looked through the db admin to see the new casing

  on localized strings.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/models/screenshot_comment.py
    reviewboard/notifications/models.py
    reviewboard/hostingsvcs/models.py
    reviewboard/reviews/models/screenshot.py
    reviewboard/attachments/models.py
    reviewboard/webapi/models.py
    reviewboard/diffviewer/models.py
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/scmtools/models.py
    reviewboard/integrations/models.py
    reviewboard/reviews/models/group.py
    reviewboard/reviews/models/default_reviewer.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/status_update.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/site/models.py
    reviewboard/accounts/models.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/reviews/models/review_request_draft.py
    reviewboard/changedescs/models.py
    reviewboard/reviews/models/review.py

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/models/screenshot_comment.py
    reviewboard/notifications/models.py
    reviewboard/hostingsvcs/models.py
    reviewboard/reviews/models/screenshot.py
    reviewboard/attachments/models.py
    reviewboard/webapi/models.py
    reviewboard/diffviewer/models.py
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/scmtools/models.py
    reviewboard/integrations/models.py
    reviewboard/reviews/models/group.py
    reviewboard/reviews/models/default_reviewer.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/status_update.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/site/models.py
    reviewboard/accounts/models.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/reviews/models/review_request_draft.py
    reviewboard/changedescs/models.py
    reviewboard/reviews/models/review.py

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (bb86b44)