Allow spaces in filename

Review Request #87 — Created June 20, 2007 and submitted


Review Board SVN (deprecated)


Filenames with spaces needed two changes, one to the diff parser and another to the svn connector.

The parser change is probably incomplete.

I'm also not sure of the svn changes when using another protocol to access the server.
Works with unified diffs and using http to access the subversion server. 
  2. /trunk/reviewboard/diffviewer/ (Diff revision 1)
    I'm pretty sure we're not guaranteed to have a tab in  the diff headers, especially given the vast number of  version control systems we're starting to accumulate.
    1. So what do you suggest to support filenames with spaces?
    2. I'm not yet sure.  I need to think over how to best parse this,
      and how it fits in with all the diffparser changes that will
      need to be made for CVS and git.
  3. /trunk/reviewboard/scmtools/ (Diff revision 1)
    I think this should be OK with protocols other than http.  SVN uses URLs for all types of repositories (http, svn+ssh, file, etc.)