Summary

Allow spaces in filename

Review Request #87 — Created June 20, 2007 and submitted

Information

Owner

nuno

Repository

Review Board SVN (deprecated)

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Filenames with spaces needed two changes, one to the diff parser and another to the svn connector.

The parser change is probably incomplete.

I'm also not sure of the svn changes when using another protocol to access the server.

Testing Done

Works with unified diffs and using http to access the subversion server.

/trunk/reviewboard/diffviewer/parser.py (Diff revision 1)

I'm pretty sure we're not guaranteed to have a tab in  the diff headers, especially given the vast number of  version control systems we're starting to accumulate.

nuno June 21, 2007, 6:44 p.m.

So what do you suggest to support filenames with spaces?

david June 21, 2007, 6:49 p.m.

I'm not yet sure.  I need to think over how to best parse this,
and how it fits in with all the diffparser changes that will
need to be made for CVS and git.

/trunk/reviewboard/scmtools/svn.py (Diff revision 1)

I think this should be OK with protocols other than http.  SVN uses URLs for all types of repositories (http, svn+ssh, file, etc.)