Summary

Fix up a couple places that used select_related() with incorrect field names.

Review Request #8697 — Created Jan. 31, 2017 and submitted Jan. 31, 2017, 10:15 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

bb27629...

Reviewers

Groups

reviewboard

People

Description

Django 1.8 helpfully throws an error if select_related() is called with a
field name that doesn't exist. There were a couple places that were doing this
(columns in the reviews datagrid on the users page and the e-mail
notifications), and we just didn't notice that they were doing more queries
than expected as a result.

Testing Done

Ran unit tests.

Expand All
Collapse All

Tool: Pyflakes
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/datagrids/columns.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/notifications/email.py
    reviewboard/datagrids/columns.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (828c0da)