Summary

Fix handling of TestCase.fixtures for broader compatibility.

Review Request #8694 — Created Jan. 31, 2017 and submitted Jan. 31, 2017, 10:10 p.m.

Information

Owner

david

Repository

Djblets

Branch

release-0.10.x

Bugs

Depends On

Commit

42eb2a9...

Reviewers

Groups

djblets

People

Description

In Django 1.8, they've added a fixtures attribute to TestCase which
defaults to None. This messes up our existing code that expects test cases
that don't have fixtures to just not have this attribute defined.

We can't just change it to default to an empty list, because django's
TestCase then gets grumpy. Instead, I've changed it so we handle a None
value appropriately.

Testing Done


Ran djblets unit tests on 1.6 and 1.8.
Ran Review Board unit tests on 1.6 and 1.8.

Expand All
Collapse All

Tool: PEP8 Style Checker
Processed Files:
    djblets/testing/testcases.py



Tool: Pyflakes
Processed Files:
    djblets/testing/testcases.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (3fccd1e)