Summary

Add Meta.fields to all ModelForm instances.

Review Request #8692 — Created Jan. 31, 2017 and submitted Jan. 31, 2017, 4 p.m.

Information

Owner

david

Repository

Review Board

Branch

release-3.0.x

Bugs

Depends On

Commit

fc8dbf0...

Reviewers

Groups

reviewboard

People

Description

A new change in Django 1.8 requires ModelForms to define either fields or
excludes. This change adds fields to all ModelForms that need it.

Testing Done


Ran unit tests.
Tested adding a new repository.

Issues

Description	From	Last Updated
Where did this requirement come up? The documentation doesn't state these are required, just suggested.	chipx86	Jan. 31, 2017, 10:46 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/forms.py
    reviewboard/notifications/forms.py
    reviewboard/scmtools/forms.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/forms.py
    reviewboard/notifications/forms.py
    reviewboard/scmtools/forms.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (bb7dfb4)

The issue has been dropped. Show all issues

Where did this requirement come up? The documentation doesn't state these are required, just suggested.

david Jan. 31, 2017, 10:46 p.m.

I couldn't find it in the docs either but the code in 1.8 has:

raise ImproperlyConfigured(
    "Creating a ModelForm without either the 'fields' attribute "
    "or the 'exclude' attribute is prohibited; form %s "
    "needs updating." % name
)

david Jan. 31, 2017, 10:47 p.m.

Ah, here it is: https://django.readthedocs.io/en/1.6.x/releases/1.6.html#modelform-without-fields-or-exclude

chipx86 Jan. 31, 2017, 10:49 p.m.

Huh, interesting. Docs contradict it, but the logic's the same in 1.10. I'll make a note in Notion.