Summary

post-review: support for plain mercurial repos

Review Request #869 — Created May 18, 2009 and discarded

Information

Owner

Repository

Review Board SVN (deprecated)

Branch

Bugs

Depends On

Reviewers

Groups

reviewboard

People

Description

Adds a client for plain mercurial repos (not hgsubversion).
- renamed the hgsubversion class to MercurialSVNClient
- added a copy named MercurialClient using plain hg command lines

Testing Done

tested with:
$ hg --version
Mercurial Distributed SCM (version 1.2.1)

/trunk/rbtools/scripts/post-review (Diff revision 1)
```
End with a period.
```

/trunk/rbtools/scripts/post-review (Diff revision 1)

Space after the comma.

file_name should be filename.

/trunk/rbtools/scripts/post-review (Diff revision 1)

Should specify "r" as the second parameter.

/trunk/rbtools/scripts/post-review (Diff revision 1)

We end up creating this thing twice in here, with much of the same data. Can you refactor the code before this such that we eventually fall out into this one statement, building using the path variables calculated above?

For example, instead of doing:

    if not os.path.exists(...):
        return RepositoryInfo(...)

    # Other code here


Do:

    if os.path.exists(...):
        # Other code here

    return RepositoryInfo(...)

/trunk/rbtools/scripts/post-review (Diff revision 1)
```
No blank line here.
```

As far as I can tell the current svn version (-r 2045) already supports hg and hg svn repos.