Added new ratelimit file for rate limiting authentication (in progress)

Review Request #8684 — Created Jan. 30, 2017 and discarded

Information

Djblets
master

Reviewers

ratelimit in progress - need to understand caching

None at the moment.

Description From Last Updated

'time' imported but unused

reviewbotreviewbot

'settings' imported but unused

reviewbotreviewbot

'cache' imported but unused

reviewbotreviewbot

Col: 36 E261 at least two spaces before inline comment

reviewbotreviewbot

Col: 80 E501 line too long (97 > 79 characters)

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 4 W291 trailing whitespace

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

Col: 1 W293 blank line contains whitespace

reviewbotreviewbot

undefined name 'LOGIN_LIMIT_RATE'

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

undefined name 'group'

reviewbotreviewbot

local variable 'usage' is assigned to but never used

reviewbotreviewbot

undefined name 'LOGIN_LIMIT_RATE'

reviewbotreviewbot

Col: 1 E302 expected 2 blank lines, found 1

reviewbotreviewbot

Col: 80 E501 line too long (99 > 79 characters)

reviewbotreviewbot

Col: 50 W292 no newline at end of file

reviewbotreviewbot
reviewbot
  1. Tool: Pyflakes
    Processed Files:
        djblets/auth/ratelimit.py
        djblets/settings.py
    
    
    
    Tool: PEP8 Style Checker
    Processed Files:
        djblets/auth/ratelimit.py
        djblets/settings.py
    
    
  2. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
     'time' imported but unused
    
  3. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
     'settings' imported but unused
    
  4. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
     'cache' imported but unused
    
  5. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
    Col: 36
     E261 at least two spaces before inline comment
    
  6. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (97 > 79 characters)
    
  7. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  8. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
    Col: 4
     W291 trailing whitespace
    
  9. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     W293 blank line contains whitespace
    
  10. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  11. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     W293 blank line contains whitespace
    
  12. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     W293 blank line contains whitespace
    
  13. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     W293 blank line contains whitespace
    
  14. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     W293 blank line contains whitespace
    
  15. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     W293 blank line contains whitespace
    
  16. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
     undefined name 'LOGIN_LIMIT_RATE'
    
  17. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  18. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
     undefined name 'group'
    
  19. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
     local variable 'usage' is assigned to but never used
    
  20. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
     undefined name 'LOGIN_LIMIT_RATE'
    
  21. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
    Col: 1
     E302 expected 2 blank lines, found 1
    
  22. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
    Col: 80
     E501 line too long (99 > 79 characters)
    
  23. djblets/auth/ratelimit.py (Diff revision 1)
     
     
    Show all issues
    Col: 50
     W292 no newline at end of file
    
  24. 
      
RK
Review request changed

Status: Discarded

Loading...