Summary

Added new ratelimit file for rate limiting authentication (in progress)

Review Request #8684 — Created Jan. 30, 2017 and discarded Feb. 3, 2017, 9:58 p.m.

Information

Owner

rkdhatt

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets, students

People

Description

ratelimit in progress - need to understand caching

Testing Done

None at the moment.

Issues

Description	From	Last Updated
'time' imported but unused	reviewbot	Jan. 30, 2017, 8:24 p.m.
'settings' imported but unused	reviewbot	Jan. 30, 2017, 8:24 p.m.
'cache' imported but unused	reviewbot	Jan. 30, 2017, 8:24 p.m.
Col: 36 E261 at least two spaces before inline comment	reviewbot	Jan. 30, 2017, 8:24 p.m.
Col: 80 E501 line too long (97 > 79 characters)	reviewbot	Jan. 30, 2017, 8:24 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Jan. 30, 2017, 8:24 p.m.
Col: 4 W291 trailing whitespace	reviewbot	Jan. 30, 2017, 8:24 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Jan. 30, 2017, 8:24 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Jan. 30, 2017, 8:24 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Jan. 30, 2017, 8:24 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Jan. 30, 2017, 8:24 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Jan. 30, 2017, 8:24 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Jan. 30, 2017, 8:24 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Jan. 30, 2017, 8:24 p.m.
undefined name 'LOGIN_LIMIT_RATE'	reviewbot	Jan. 30, 2017, 8:24 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Jan. 30, 2017, 8:24 p.m.
undefined name 'group'	reviewbot	Jan. 30, 2017, 8:24 p.m.
local variable 'usage' is assigned to but never used	reviewbot	Jan. 30, 2017, 8:24 p.m.
undefined name 'LOGIN_LIMIT_RATE'	reviewbot	Jan. 30, 2017, 8:24 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Jan. 30, 2017, 8:24 p.m.
Col: 80 E501 line too long (99 > 79 characters)	reviewbot	Jan. 30, 2017, 8:24 p.m.
Col: 50 W292 no newline at end of file	reviewbot	Jan. 30, 2017, 8:24 p.m.

Fix it!

Tool: Pyflakes
Processed Files:
    djblets/auth/ratelimit.py
    djblets/settings.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/auth/ratelimit.py
    djblets/settings.py

djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
 'time' imported but unused
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
 'settings' imported but unused
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
 'cache' imported but unused
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 36
 E261 at least two spaces before inline comment
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (97 > 79 characters)
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 4
 W291 trailing whitespace
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
 undefined name 'LOGIN_LIMIT_RATE'
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
 undefined name 'group'
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
 local variable 'usage' is assigned to but never used
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
 undefined name 'LOGIN_LIMIT_RATE'
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 80
 E501 line too long (99 > 79 characters)
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 50
 W292 no newline at end of file
```

Status:: Discarded

djblets/auth/ratelimit.py (Diff revision 1)

djblets/auth/ratelimit.py (Diff revision 1)

djblets/auth/ratelimit.py (Diff revision 1)

djblets/auth/ratelimit.py (Diff revision 1)