Summary:

Update the custom models tests mixin to support Django 1.6, 1.8+.

Review Request #8682 — Created Jan. 30, 2017 and submitted Feb. 3, 2017, 2:04 p.m.

Information
Owner:	chipx86
Repository:	Djblets
Branch:	release-0.10.x
Bugs:
Depends On:
Commit:	8b642f7...
Reviewers
Groups:	djblets
People:

Description

Our TestModelsLoaderMixin, while working fine on Django 1.6, had some
problems on modern versions of Django. Models weren't gaining their
correct app labels and were appearing in two apps at once. We also were
attempting to register models that were imported from other modules
(like User, Site, etc.). Along with this, not all state was properly
cleared.

This change fixes the mixin for Django 1.8 and higher. This gives us
compatibility with Django 1.6 and 1.8 through 1.10. It does not support
Django 1.7 (which Djblets will not officially support anyway), due to
issues in Django 1.7 that were fixed in 1.8 involving ManyToManyFields
not being properly created in the database under these conditions.

Testing Done

Unit tests pass on 1.6, 1.8, 1.9, 1.10.

Issues

Description	From	Last Updated
These definitions aren't needed because they're only used when apps is None.	david	Feb. 2, 2017, 4:47 p.m.
Do we want to call apps.clear_cache()?	david	Feb. 2, 2017, 4:45 p.m.
This could be a generator expression instead of a list comprehension.	david	Feb. 2, 2017, 4:46 p.m.

Tool: Pyflakes
Processed Files:
    djblets/testing/testcases.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/testing/testcases.py

djblets/testing/testcases.py (Diff revision 1)

Show all issues

These definitions aren't needed because they're only used when apps is None.

chipx86 Feb. 2, 2017, 4:53 p.m.

What I was aiming for (in this and other changes) is to always have a version of each of these imports we can check for, and to keep lintian checkers from complaining. Pyflakes doesn't seem to care, though.

djblets/testing/testcases.py (Diff revision 1)
Show all issues
```
Do we want to call apps.clear_cache()?
```
1. chipx86 Feb. 2, 2017, 4:51 p.m.
  unset_installed_apps calls this for us.

djblets/testing/testcases.py (Diff revision 1)

Show all issues

This could be a generator expression instead of a list comprehension.

chipx86 Feb. 2, 2017, 4:51 p.m.

Aiming to keep the return types the same between both versions. get_apps() returns a list.

Change Summary:

Removed the fallback variables for app_cache and load_app.

Commit:

-	ff87519b1ba0404daa8f0dec9d27e231829e2ffb
+	8b642f741a2678c780c20358056b1ae13f68e8b9

Diff:

Revision 2 (+46 -12)

Show changes

djblets/testing/testcases.py

Tool: Pyflakes
Processed Files:
    djblets/testing/testcases.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/testing/testcases.py

Ship it!

```
Ship It!
```

Status: Closed (submitted)

Change Summary:

Pushed to release-0.10.x (3ebacf7)