Summary:

[WIP] Figuring out how to affect front-end to enable read-only mode

Review Request #8677 — Created Jan. 29, 2017 and discarded March 18, 2017, 2:20 a.m.

Information
Owner:	khp
Repository:	Review Board
Branch:	master
Bugs:
Depends On:	~~8648~~, ~~8657~~
Reviewers
Groups:	reviewboard, students
People:

Description

This is exploration for read-only mode, which is a feature to allow admins to disable functionality which would disrupt RB upgrades and maintenance while allowing users to consume site content.

Blocking API and introducing feature into admin panel are in previous commits.

Changes to Navbar (New Review Request link), Actions in ReviewRequestEditorView, ReviewRequestEditorView description, testing, information, comments, diff/comment box all changed.

Sidebar in Dashboard disabled (possibly not the best way to disable those features).

ETag updated to reflect changes in read-only mode for ReviewRequestEditorView.

Testing Done

Issues

Description	From	Last Updated
You'll also need to do work to block off write access to the API, and handle this in RB.apiCall in …	chipx86	March 1, 2017, 2:13 a.m.
Another thing that modifies the database today is changing columns for a datagrid (dashboard, All Review Requests, etc.). Users can …	chipx86	March 3, 2017, 11:16 p.m.
While this change wires off some pages (New Review Request, My Account, etc.), that doesn't stop users from actually going …	chipx86	March 4, 2017, 2:10 a.m.
Col: 13 W291 trailing whitespace	reviewbot	Feb. 20, 2017, 3:47 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Feb. 20, 2017, 3:48 p.m.
Col: 13 E131 continuation line unaligned for hanging indent	reviewbot	Feb. 20, 2017, 3:48 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Feb. 20, 2017, 3:48 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Feb. 20, 2017, 3:48 p.m.
Col: 80 E501 line too long (87 > 79 characters)	reviewbot	Feb. 20, 2017, 3:49 p.m.
Col: 13 E131 continuation line unaligned for hanging indent	reviewbot	Feb. 20, 2017, 3:49 p.m.
Col: 19 E127 continuation line over-indented for visual indent	reviewbot	Feb. 20, 2017, 3:52 p.m.
Col: 80 E501 line too long (93 > 79 characters)	reviewbot	Feb. 20, 2017, 3:52 p.m.
Col: 80 E501 line too long (112 > 79 characters)	reviewbot	Feb. 20, 2017, 3:52 p.m.
Col: 18 E127 continuation line over-indented for visual indent	reviewbot	Feb. 20, 2017, 3:52 p.m.
Col: 80 E501 line too long (112 > 79 characters)	reviewbot	Feb. 20, 2017, 3:52 p.m.
Col: 80 E501 line too long (103 > 79 characters)	reviewbot	Feb. 20, 2017, 3:52 p.m.
Col: 80 E501 line too long (86 > 79 characters)	reviewbot	Feb. 20, 2017, 3:52 p.m.
Col: 80 E501 line too long (103 > 79 characters)	reviewbot	Feb. 20, 2017, 3:52 p.m.
Col: 80 E501 line too long (83 > 79 characters)	reviewbot	Feb. 20, 2017, 3:52 p.m.
'SiteConfiguration' imported but unused	reviewbot	Feb. 20, 2017, 3:52 p.m.
Col: 19 E127 continuation line over-indented for visual indent	reviewbot	Feb. 20, 2017, 3:53 p.m.
Col: 18 E127 continuation line over-indented for visual indent	reviewbot	Feb. 20, 2017, 3:54 p.m.
local variable 'siteconfig' is assigned to but never used	reviewbot	Feb. 20, 2017, 3:54 p.m.
local variable 'siteconfig' is assigned to but never used	reviewbot	Feb. 20, 2017, 3:54 p.m.
Col: 73 W292 no newline at end of file	reviewbot	Feb. 20, 2017, 3:55 p.m.
'SiteConfiguration' imported but unused	reviewbot	Feb. 20, 2017, 3:55 p.m.
Col: 19 E127 continuation line over-indented for visual indent	reviewbot	Feb. 20, 2017, 3:55 p.m.
Col: 18 E127 continuation line over-indented for visual indent	reviewbot	Feb. 20, 2017, 3:55 p.m.
Instead of this, we should have a file-level docstring. There are examples elsewhere in the codebase.	chipx86	Feb. 21, 2017, 12:53 a.m.
The name makes it sound like the user is read-only, but really we're saying "the user can make changes to …	chipx86	Feb. 20, 2017, 10:08 p.m.
Needs Args and Returns.	chipx86	Feb. 21, 2017, 1 a.m.
Needs double-backticks. This is in ReStructuredText format, and single backticks is a syntax error.	chipx86	Feb. 21, 2017, 1:01 a.m.
This method gets called a lot, so it's going to be important for it to be fast and not have …	chipx86	Feb. 21, 2017, 1:41 a.m.
Should be aligned like: var showMenu = (count > 0 && !RB.UserSession.instance.get(...));	chipx86	Feb. 21, 2017, 1:40 a.m.
This should be computed only once. You can do so earlier in the file by defining a variable.	chipx86	Feb. 21, 2017, 1:42 a.m.
Missing space after the comma.	chipx86	Feb. 21, 2017, 1:44 a.m.
Indentation on the loop should be fixed.	chipx86	Feb. 21, 2017, 1:47 a.m.
Blank line between these.	chipx86	Feb. 21, 2017, 1:48 a.m.
We're going to want the logic to be identical between here (and other template code) and is_user_read_only, now and in …	chipx86	Feb. 21, 2017, 1:57 a.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	March 1, 2017, 1:37 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	March 1, 2017, 1:37 a.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	March 1, 2017, 1:37 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	March 1, 2017, 1:37 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	March 1, 2017, 1:37 a.m.
Col: 1 W191 indentation contains tabs	reviewbot	March 1, 2017, 1:37 a.m.
'django_reset' imported but unused	reviewbot	March 1, 2017, 1:36 a.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 1, 2017, 1:36 a.m.
'django_reset' imported but unused	reviewbot	March 11, 2017, 2:26 p.m.
'from settings_local import *' used; unable to detect undefined names	reviewbot	March 11, 2017, 2:26 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/models/base_comment.py
    reviewboard/reviews/context.py

Ignored Files:
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/utils/apiUtils.es6.js
    reviewboard/templates/base.html



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/models/base_comment.py
    reviewboard/reviews/context.py

Ignored Files:
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/utils/apiUtils.es6.js
    reviewboard/templates/base.html

reviewboard/reviews/context.py (Diff revision 1)
Show all issues
```
Col: 13
 W291 trailing whitespace
```
reviewboard/reviews/context.py (Diff revision 1)
Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```

reviewboard/reviews/context.py (Diff revision 1)

Show all issues

Col: 13
 E131 continuation line unaligned for hanging indent

reviewboard/reviews/models/base_comment.py (Diff revision 1)
Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```
reviewboard/reviews/models/base_comment.py (Diff revision 1)
Show all issues
```
Col: 1
 W293 blank line contains whitespace
```

Change Summary:

Updated WIP

Description:

		This is exploration for read-only mode, which is a feature to allow admins to disable functionality which would disrupt RB upgrades and maintenance while allowing users to consume site content.

		Blocking API and introducing feature into admin panel are in previous commits.

		Looking into which templates to modify and if any .js files need to be changed as well. Potentially looking into passing a read-only value to the UserSession, but might not be necessary. Modifying editable and statusEditable in review_request model seems necessary.

~		Looking into 1) creating a utility method to call on to determine if a user is read-only mode or not, 2) perhaps a decorator or another way to introduce read-only logic into existing code.
	~	Review Request Editor is all (as far as I can tell) read-only mode "enabled" now. Toolbar, review request information, and comments section are all disabled when in read-only mode.
	+
	+	TODO:
	+	- Refactor read-only logic into a utility method somewhere
	+	- Look into caching issues and eTags
	+	- Move into main menu

Diff:

Revision 2 (+53 -12)

Show changes

	reviewboard/reviews/context.py
	reviewboard/reviews/default_actions.py
	reviewboard/reviews/models/base_comment.py
	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/static/rb/js/models/commentEditorModel.js
	reviewboard/static/rb/js/models/reviewRequestEditorModel.js
	reviewboard/static/rb/js/models/userSessionModel.js
	reviewboard/static/rb/js/views/commentDialogView.js
	2 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/models/base_comment.py
    reviewboard/reviews/default_actions.py
    reviewboard/reviews/context.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/base.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/models/commentEditorModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/models/base_comment.py
    reviewboard/reviews/default_actions.py
    reviewboard/reviews/context.py

Ignored Files:
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/base.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/models/commentEditorModel.js

reviewboard/reviews/context.py (Diff revision 2)
Show all issues
```
Col: 80
 E501 line too long (87 > 79 characters)
```

reviewboard/reviews/context.py (Diff revision 2)

Show all issues

Col: 13
 E131 continuation line unaligned for hanging indent

reviewboard/reviews/default_actions.py (Diff revision 2)

Show all issues

Col: 19
 E127 continuation line over-indented for visual indent

reviewboard/reviews/default_actions.py (Diff revision 2)
Show all issues
```
Col: 80
 E501 line too long (93 > 79 characters)
```
reviewboard/reviews/default_actions.py (Diff revision 2)
Show all issues
```
Col: 80
 E501 line too long (112 > 79 characters)
```

reviewboard/reviews/default_actions.py (Diff revision 2)

Show all issues

Col: 18
 E127 continuation line over-indented for visual indent

reviewboard/reviews/default_actions.py (Diff revision 2)
Show all issues
```
Col: 80
 E501 line too long (112 > 79 characters)
```
reviewboard/reviews/default_actions.py (Diff revision 2)
Show all issues
```
Col: 80
 E501 line too long (103 > 79 characters)
```
reviewboard/reviews/default_actions.py (Diff revision 2)
Show all issues
```
Col: 80
 E501 line too long (86 > 79 characters)
```
reviewboard/reviews/default_actions.py (Diff revision 2)
Show all issues
```
Col: 80
 E501 line too long (103 > 79 characters)
```
reviewboard/reviews/models/base_comment.py (Diff revision 2)
Show all issues
```
Col: 80
 E501 line too long (83 > 79 characters)
```

Change Summary:

Updated WIP with some refactors and changes to most database-effecting UI

Diff:

Revision 3 (+83 -21)

Show changes

	reviewboard/admin/read_only.py
	reviewboard/reviews/default_actions.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/base_comment.py
	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/static/rb/js/models/commentEditorModel.js
	reviewboard/static/rb/js/models/userSessionModel.js
	7 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/read_only.py
    reviewboard/reviews/models/base_comment.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/default_actions.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/views/starManagerView.js
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/base/navbar.html
    reviewboard/templates/base.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/pages/views/datagridPageView.js
    reviewboard/static/rb/js/models/commentEditorModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/read_only.py
    reviewboard/reviews/models/base_comment.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/default_actions.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/views/starManagerView.js
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/base/navbar.html
    reviewboard/templates/base.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/pages/views/datagridPageView.js
    reviewboard/static/rb/js/models/commentEditorModel.js

reviewboard/reviews/default_actions.py (Diff revision 3)
Show all issues
```
 'SiteConfiguration' imported but unused
```

reviewboard/reviews/default_actions.py (Diff revision 3)

Show all issues

Col: 19
 E127 continuation line over-indented for visual indent

reviewboard/reviews/default_actions.py (Diff revision 3)

Show all issues

Col: 18
 E127 continuation line over-indented for visual indent

Description:

		This is exploration for read-only mode, which is a feature to allow admins to disable functionality which would disrupt RB upgrades and maintenance while allowing users to consume site content.

		Blocking API and introducing feature into admin panel are in previous commits.

~		Looking into which templates to modify and if any .js files need to be changed as well. Potentially looking into passing a read-only value to the UserSession, but might not be necessary. Modifying editable and statusEditable in review_request model seems necessary.
	~	Changes to Navbar (New Review Request link), Actions in ReviewRequestEditorView, ReviewRequestEditorView description, testing, information, comments, diff/comment box all changed.

~		Review Request Editor is all (as far as I can tell) read-only mode "enabled" now. Toolbar, review request information, and comments section are all disabled when in read-only mode.
	~	Sidebar in Dashboard disabled (possibly not the best way to disable those features).

~		TODO:
	~	ETag updated to reflect changes in read-only mode for ReviewRequestEditorView.
-		- Refactor read-only logic into a utility method somewhere
-		- Look into caching issues and eTags
-		- Move into main menu

Change Summary:

Updated front-end to cover "My Account"

Diff:

Revision 4 (+104 -22)

Show changes

	reviewboard/accounts/views.py
	reviewboard/admin/read_only.py
	reviewboard/reviews/default_actions.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/base_comment.py
	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/static/rb/js/models/commentEditorModel.js
	9 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/read_only.py
    reviewboard/reviews/models/base_comment.py
    reviewboard/accounts/views.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/default_actions.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/views/starManagerView.js
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/base/navbar.html
    reviewboard/templates/base.html
    reviewboard/templates/base/_nav_support_menu.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/pages/views/datagridPageView.js
    reviewboard/static/rb/js/models/commentEditorModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/read_only.py
    reviewboard/reviews/models/base_comment.py
    reviewboard/accounts/views.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/default_actions.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/views/starManagerView.js
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/base/navbar.html
    reviewboard/templates/base.html
    reviewboard/templates/base/_nav_support_menu.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/pages/views/datagridPageView.js
    reviewboard/static/rb/js/models/commentEditorModel.js

reviewboard/accounts/views.py (Diff revision 4)

Show all issues

 local variable 'siteconfig' is assigned to but never used

reviewboard/accounts/views.py (Diff revision 4)

Show all issues

 local variable 'siteconfig' is assigned to but never used

reviewboard/accounts/views.py (Diff revision 4)
Show all issues
```
Col: 73
 W292 no newline at end of file
```
reviewboard/reviews/default_actions.py (Diff revision 4)
Show all issues
```
 'SiteConfiguration' imported but unused
```

reviewboard/reviews/default_actions.py (Diff revision 4)

Show all issues

Col: 19
 E127 continuation line over-indented for visual indent

reviewboard/reviews/default_actions.py (Diff revision 4)

Show all issues

Col: 18
 E127 continuation line over-indented for visual indent

Change Summary:

Minor fixes

Diff:

Revision 5 (+100 -24)

Show changes

	reviewboard/accounts/views.py
	reviewboard/admin/read_only.py
	reviewboard/reviews/default_actions.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/base_comment.py
	reviewboard/reviews/models/review_request.py
	reviewboard/reviews/templatetags/reviewtags.py
	reviewboard/static/rb/js/models/commentEditorModel.js
	10 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/read_only.py
    reviewboard/reviews/models/base_comment.py
    reviewboard/accounts/views.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/default_actions.py
    reviewboard/webapi/tests/test_base.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/views/starManagerView.js
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/base/navbar.html
    reviewboard/templates/base.html
    reviewboard/templates/base/_nav_support_menu.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/pages/views/datagridPageView.js
    reviewboard/static/rb/js/models/commentEditorModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/read_only.py
    reviewboard/reviews/models/base_comment.py
    reviewboard/accounts/views.py
    reviewboard/reviews/templatetags/reviewtags.py
    reviewboard/reviews/default_actions.py
    reviewboard/webapi/tests/test_base.py
    reviewboard/reviews/models/review_request.py

Ignored Files:
    reviewboard/static/rb/js/views/starManagerView.js
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/base/navbar.html
    reviewboard/templates/base.html
    reviewboard/templates/base/_nav_support_menu.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/pages/views/datagridPageView.js
    reviewboard/static/rb/js/models/commentEditorModel.js

This is a great start! Some comments about next steps and fixes/improvements for the current implementation.

Show all issues

You'll also need to do work to block off write access to the API, and handle this in RB.apiCall in JavaScript.

khp March 3, 2017, 11:17 p.m.

I've made RB.apiCall return early when doing non GET requests while in read-only mode.

Show all issues

Another thing that modifies the database today is changing columns for a datagrid (dashboard, All Review Requests, etc.). Users can reorder columns or add/remove columns. There's no harm in continuing to allow those operations to continue, but you should prevent saving in the database in the backend.

khp March 3, 2017, 11:17 p.m.

I found this a bit harder to test since, if I've understood correctly, the issue is that in djblets the columns get changed on the profile and saved. I've refactored the djblets load_state to be able to take a third optional argument, and overrode it in reviewboard. This is because djblets is agnostic about read-only mode (for now..?). Is there a better way to go about this?

Show all issues

While this change wires off some pages (New Review Request, My Account, etc.), that doesn't stop users from actually going to those pages. You'll need a solution for those pages as well.

One option is to show different content completely for the pages, letting the user know the site is in read-only mode and they can't post new changes for review or modify settings.

khp March 3, 2017, 11:17 p.m.

I've have them redirecting to the dashboard for now. What do you think?

reviewboard/admin/read_only.py (Diff revision 5)

Show all issues

Instead of this, we should have a file-level docstring. There are examples elsewhere in the codebase.

khp Feb. 26, 2017, 5:12 a.m.

Replaced with """Provide utility methods for read-only mode."""

reviewboard/admin/read_only.py (Diff revision 5)

Show all issues

The name makes it sound like the user is read-only, but really we're saying "the user can make changes to the site." I'd instead go with: is_site_read_only_for(user).

KH

khp Feb. 26, 2017, 5:12 a.m.
```
Agreed
```

reviewboard/admin/read_only.py (Diff revision 5)
Show all issues
```
Needs Args and Returns.
```

reviewboard/admin/read_only.py (Diff revision 5)

Show all issues

Needs double-backticks. This is in ReStructuredText format, and single backticks is a syntax error.

reviewboard/admin/read_only.py (Diff revision 5)

Show all issues

This method gets called a lot, so it's going to be important for it to be fast and not have to re-calculate all the time.
What you can do is store a caching variable on user and return it, like this:

if not hasattr(user, '_cache_site_is_read_only'):
    user._cache_site_is_read_only = ...

return user._cache_site_is_read_only

khp Feb. 26, 2017, 5:12 a.m.

This is cool, didn't know you could create an instance variable from outside of the class file! And because the user object is one per request, we don't have to worry about the cache being invalidated, I presume. We'd lose the user object after every page load.

reviewboard/static/rb/js/pages/views/datagridPageView.js (Diff revision 5)

Show all issues

Should be aligned like:

var showMenu = (count > 0 &&
                !RB.UserSession.instance.get(...));

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 5)

Show all issues

This should be computed only once. You can do so earlier in the file by defining a variable.

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 5)
Show all issues
```
Missing space after the comma.
```

reviewboard/static/rb/js/views/reviewRequestEditorView.js (Diff revision 5)

Show all issues

Indentation on the loop should be fixed.

reviewboard/static/rb/js/views/starManagerView.js (Diff revision 5)
Show all issues
```
Blank line between these.
```

reviewboard/templates/base.html (Diff revision 5)

Show all issues

We're going to want the logic to be identical between here (and other template code) and is_user_read_only, now and in the future. Instead of doing a check here, you can add a function to reviewboard/admin/context_processors.py that you'd then add in the list of context processors in reviewboard/settings.py. This would call out to is_user_read_only and return the result as a variable that can be used in the templates.

khp Feb. 26, 2017, 5:12 a.m.

Thanks, was wanting to ask whether something like this was possible!

Change Summary:

Updated with responses to some comments

Diff:

Revision 6 (+127 -32)

Show changes

	reviewboard/settings.py
	reviewboard/accounts/views.py
	reviewboard/admin/context_processors.py
	reviewboard/admin/read_only.py
	reviewboard/reviews/default_actions.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/base_comment.py
	reviewboard/reviews/models/review_request.py
	13 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/read_only.py
    reviewboard/webapi/tests/test_base.py
    reviewboard/reviews/models/base_comment.py
    reviewboard/webapi/base.py
    reviewboard/accounts/views.py
    reviewboard/reviews/default_actions.py
    reviewboard/reviews/models/review_request.py
    reviewboard/admin/context_processors.py
    reviewboard/settings.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/static/rb/js/views/starManagerView.js
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/base/navbar.html
    reviewboard/templates/base.html
    reviewboard/templates/base/_nav_support_menu.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/pages/views/datagridPageView.js
    reviewboard/static/rb/js/models/commentEditorModel.js



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/read_only.py
    reviewboard/webapi/tests/test_base.py
    reviewboard/reviews/models/base_comment.py
    reviewboard/webapi/base.py
    reviewboard/accounts/views.py
    reviewboard/reviews/default_actions.py
    reviewboard/reviews/models/review_request.py
    reviewboard/admin/context_processors.py
    reviewboard/settings.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/static/rb/js/views/starManagerView.js
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/base/navbar.html
    reviewboard/templates/base.html
    reviewboard/templates/base/_nav_support_menu.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/pages/views/datagridPageView.js
    reviewboard/static/rb/js/models/commentEditorModel.js

reviewboard/admin/context_processors.py (Diff revision 6)
Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
reviewboard/admin/context_processors.py (Diff revision 6)
Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/admin/context_processors.py (Diff revision 6)
Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
reviewboard/admin/context_processors.py (Diff revision 6)
Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/admin/context_processors.py (Diff revision 6)
Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/admin/context_processors.py (Diff revision 6)
Show all issues
```
Col: 1
 W191 indentation contains tabs
```
reviewboard/settings.py (Diff revision 6)
Show all issues
```
 'django_reset' imported but unused
```

reviewboard/settings.py (Diff revision 6)

Show all issues

 'from settings_local import *' used; unable to detect undefined names

Change Summary:

Updates from comments.

Diff:

Revision 7 (+157 -32)

Show changes

	reviewboard/settings.py
	reviewboard/accounts/views.py
	reviewboard/admin/context_processors.py
	reviewboard/admin/read_only.py
	reviewboard/datagrids/grids.py
	reviewboard/reviews/default_actions.py
	reviewboard/reviews/views.py
	reviewboard/reviews/models/base_comment.py
	15 more

Tool: Pyflakes
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/read_only.py
    reviewboard/reviews/models/base_comment.py
    reviewboard/webapi/base.py
    reviewboard/accounts/views.py
    reviewboard/reviews/default_actions.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/admin/context_processors.py
    reviewboard/settings.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/static/rb/js/pages/views/dashboardView.js
    reviewboard/static/rb/js/views/starManagerView.js
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/base/navbar.html
    reviewboard/static/rb/js/utils/apiUtils.es6.js
    reviewboard/templates/base.html
    reviewboard/templates/base/_nav_support_menu.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/models/commentEditorModel.js

reviewboard/settings.py (Diff revision 7)
Show all issues
```
 'django_reset' imported but unused
```

reviewboard/settings.py (Diff revision 7)

Show all issues

 'from settings_local import *' used; unable to detect undefined names

Tool: PEP8 Style Checker
Processed Files:
    reviewboard/reviews/views.py
    reviewboard/admin/read_only.py
    reviewboard/reviews/models/base_comment.py
    reviewboard/webapi/base.py
    reviewboard/accounts/views.py
    reviewboard/reviews/default_actions.py
    reviewboard/reviews/models/review_request.py
    reviewboard/datagrids/grids.py
    reviewboard/admin/context_processors.py
    reviewboard/settings.py
    reviewboard/reviews/templatetags/reviewtags.py

Ignored Files:
    reviewboard/static/rb/js/pages/views/dashboardView.js
    reviewboard/static/rb/js/views/starManagerView.js
    reviewboard/templates/reviews/review_reply_section.html
    reviewboard/templates/base/navbar.html
    reviewboard/static/rb/js/utils/apiUtils.es6.js
    reviewboard/templates/base.html
    reviewboard/templates/base/_nav_support_menu.html
    reviewboard/static/rb/js/models/userSessionModel.js
    reviewboard/static/rb/js/views/reviewRequestEditorView.js
    reviewboard/static/rb/js/models/reviewRequestEditorModel.js
    reviewboard/static/rb/js/views/commentDialogView.js
    reviewboard/static/rb/js/models/commentEditorModel.js

Review Board 6.0 beta 3 (dev)

[WIP] Figuring out how to affect front-end to enable read-only mode

Change Summary:

Description:

Diff:

Change Summary:

Diff:

Description:

Change Summary:

Diff:

Change Summary:

Diff:

Change Summary:

Diff:

Change Summary:

Diff:

Status: Discarded