Summary

Added new ratelimit file for rate limiting authentication (in progress)

Review Request #8674 — Created Jan. 27, 2017 and discarded March 6, 2017, 6:53 p.m.

Information

Owner

rkdhatt

Repository

Djblets

Branch

master

Bugs

Depends On

Reviewers

Groups

djblets, students

People

Description

Not done for review. Currently trying to understand django-ratelimit utils.py in order to implement a simpler version.

Testing Done

None at the moment.

Issues

Description	From	Last Updated
'settings' imported but unused	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 E302 expected 2 blank lines, found 1	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 4 W291 trailing whitespace	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 2 W191 indentation contains tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 E101 indentation contains mixed spaces and tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 W293 blank line contains whitespace	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 W191 indentation contains tabs	reviewbot	Jan. 27, 2017, 8:12 p.m.
Col: 1 W391 blank line at end of file	reviewbot	Jan. 27, 2017, 8:12 p.m.

Fix it!

Tool: Pyflakes
Processed Files:
    djblets/auth/ratelimit.py
    djblets/settings.py



Tool: PEP8 Style Checker
Processed Files:
    djblets/auth/ratelimit.py
    djblets/settings.py

djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
 'settings' imported but unused
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 E302 expected 2 blank lines, found 1
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 4
 W291 trailing whitespace
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 2
 W191 indentation contains tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 E101 indentation contains mixed spaces and tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W293 blank line contains whitespace
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W191 indentation contains tabs
```
djblets/auth/ratelimit.py (Diff revision 1)
An issue was opened. Show all issues
```
Col: 1
 W391 blank line at end of file
```

Description:

~		Not done for review. Currently trying to understand django-ratelimit utils.py ain order to implement a simpler version.
	~	Not done for review. Currently trying to understand django-ratelimit utils.py in order to implement a simpler version.

Review Board 7.0 alpha 0 (dev)

Added new ratelimit file for rate limiting authentication (in progress)

Information

Reviewers

Description:

Status: Discarded

djblets/auth/ratelimit.py (Diff revision 1)

djblets/auth/ratelimit.py (Diff revision 1)

djblets/auth/ratelimit.py (Diff revision 1)

djblets/auth/ratelimit.py (Diff revision 1)