-
-
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 1) Col: 5 E265 block comment should start with '# '
-
reviewboard/reviews/templatetags/reviewtags.py (Diff revision 1) Col: 5 E265 block comment should start with '# '
-
-
Add visual indicators to new page entries and new comments, in order to highlight active/new discussions.
Review Request #8673 — Created Jan. 28, 2017 and discarded
| Information | |
|---|---|
| szhang | |
| Review Board | |
| master | |
| Reviewers | |
| reviewboard, students | |
On review requests, it can be difficult to discern new discussion from the old. This particularly pertains to finding new reviews and new comments on review requests with a lot of discussion.
This set of changes adds visual indicators/highlighting to all page entries and all comments that were posted since the user last visited the review request.
It essentially does this by adding reviews and comments to a CSS class if they were posted since the user last visited the review request. It then applies the visual indicators to the page using only LessCSS.
- Checked if
last_visitedis passed down to the appropriate templates correctly. - Checked if the
new-page-entryclass and thenew-commentclass are applied when the conditional is true. - Checked if the page is updated with the correct styling when page-entries and comments are newer than
last_visited(ie. indicators are added). - Checked if the visual indicators are removed when page-entries and comments are older than
last_visited(ie. page refreshed on a page with page-entries/comments with the indicators). - Checked if the visual indicators are added and removed correctly in spite of any caching that might happen (ie. caching does not interfere with addition/removal).
- Ran unit tests for checking if
new-page-entryandnew-commentare both added and removed correctly.
| Description | From | Last Updated |
|---|---|---|
|
I think if both the review and replies are new, we can just leave the whole box shaded and avoid … |
 david
|
|
|
Col: 5 E265 block comment should start with '# ' |
 reviewbot
|
|
|
Col: 5 E265 block comment should start with '# ' |
reviewbot
|
|
|
Col: 80 E501 line too long (116 > 79 characters) |
reviewbot
|
|
|
Col: 114 E202 whitespace before ')' |
reviewbot
|
|
|
Col: 77 W291 trailing whitespace |
reviewbot
|
|
|
Col: 9 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 74 W291 trailing whitespace |
reviewbot
|
|
|
Undo this change. |
 brennie
|
|
|
No newline here. |
brennie
|
|
|
CSS selectors should be ordered as: &.foo {} a {} .foo {} #foo{} Within each group the selectors should be … |
brennie
|
|
|
I do not know that this comment. is necessary. |
brennie
|
|
|
Alphabetize. |
brennie
|
|
|
The draft rendering and the new-comment rendering should be mutually exclusive. Additionally, producing an element with two different class= attribtues … |
brennie
|
|
|
This line looks like it got unintentionally indented 1 space. |
david
|
|
|
It doesn't seem useful to have separate definitions for entry and comment which are the same. Can we merge these? |
david
|
|
|
The #reviews .review-request-page-entry part can be consolidated, like: #reviews .review-request-page-entry { &.new-page-entry { ... } &:not(.new-page-entry) { ... } } |
 chipx86
|
|
|
The 4px should also be in a constant. |
chipx86
|
|
|
What's this here for? |
chipx86
|
|
|
Maybe when wrapping and using multiple keyword arguments, you can have one keyword argument per line since there are lots … |
RK rkdhatt | |
|
'FileAttachment' imported but unused |
reviewbot
|
|
|
'Screenshot' imported but unused |
reviewbot
|
|
|
'ReviewRequest' imported but unused |
reviewbot
|
|
|
'ReviewRequestDraft' imported but unused |
reviewbot
|
|
|
For unit test descriptions (modern ones, anyway), we try to start off with the component/page that's being tested, followed by … |
chipx86
|
|
|
self.client.login will return the user, so you can use that directly. Same below. |
chipx86
|
|
|
These can be one statement. Same below. |
chipx86
|
|
|
local variable 'review' is assigned to but never used |
reviewbot
|
|
|
Older tests don't do this, but we should actually use local_site_reverse to get the URL instead of hard-coding it. Also, … |
chipx86
|
|
|
It would be better to check for something more specific here (and below), since "new-page-entry" could theoretically be anywhere. |
chipx86
|
|
|
Can you wrap the comparison in parenthesis? Helps to visually distinguish those. |
chipx86
|
|
|
Let's put the ( on the line with the format strings. That way, all entries have a nice 4 space … |
chipx86
|
|
|
Can you add a comment about this? I know we talked about this a bit, but wouldn't we want this … |
chipx86
|
|
|
There's actually a little template tag you can use here for the class building: <li{% attr "class" %}{% if draft … |
chipx86
|
|
|
'FileAttachment' imported but unused |
reviewbot
|
|
|
'ReviewRequestDraft' imported but unused |
reviewbot
|
|
|
'ReviewRequest' imported but unused |
reviewbot
|
|
|
'Screenshot' imported but unused |
reviewbot
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
'FileAttachment' imported but unused |
reviewbot
|
|
|
'ReviewRequestDraft' imported but unused |
reviewbot
|
|
|
'ReviewRequest' imported but unused |
reviewbot
|
|
|
'Screenshot' imported but unused |
reviewbot
|
|
|
I would use docstring comment here (triple quotes) |
MO Mons | |
|
maybe you should remove this blank line (unless that's the style guideline used elsewhere) |
MO Mons | |
|
I like the fact that you put these on new lines. Makes it more readable in my opinion. |
MO Mons | |
|
I would add a new blank line here. Seems like that's the general style in this file (blank line after … |
MO Mons | |
|
is it possible to split this div into two lines? |
MO Mons | |
|
same here. |
MO Mons | |
|
is it possible to split this li tag into two lines? |
MO Mons | |
|
'FileAttachment' imported but unused |
reviewbot
|
|
|
'Screenshot' imported but unused |
reviewbot
|
|
|
'ReviewRequest' imported but unused |
reviewbot
|
|
|
'ReviewRequestDraft' imported but unused |
reviewbot
|
|
|
We prefer to format formatting statements like this as : text = ( ' .... ' % foo ) |
brennie
|
|
|
Same here. |
brennie
|
|
|
And here. |
brennie
|
|
|
Here too. |
brennie
|
|
|
ETag |
brennie
|
|
|
'FileAttachment' imported but unused |
reviewbot
|
|
|
'ReviewRequestDraft' imported but unused |
reviewbot
|
|
|
'ReviewRequest' imported but unused |
reviewbot
|
|
|
'Screenshot' imported but unused |
reviewbot
|
|
|
'FileAttachment' imported but unused |
reviewbot
|
|
|
'ReviewRequestDraft' imported but unused |
reviewbot
|
|
|
'ReviewRequest' imported but unused |
reviewbot
|
|
|
'Screenshot' imported but unused |
reviewbot
|
|
|
'FileAttachment' imported but unused |
reviewbot
|
|
|
'search' imported but unused |
reviewbot
|
|
|
Col: 17 E126 continuation line over-indented for hanging indent |
reviewbot
|
|
|
Col: 17 E126 continuation line over-indented for hanging indent |
reviewbot
|
|
|
Col: 17 E126 continuation line over-indented for hanging indent |
reviewbot
|
|
|
Col: 17 E126 continuation line over-indented for hanging indent |
reviewbot
|
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 2 (+17 -3) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/templates/reviews/review_reply.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/templates/reviews/review_reply.html -
-
reviewboard/reviews/views.py (Diff revision 2) Col: 9 E128 continuation line under-indented for visual indent
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 3 (+18 -4) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/templates/reviews/review_reply.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/templates/reviews/review_reply.html -
Change Summary:
Add LessCSS styling changes
Clean up code (eg. removing debug output)
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+42 -5) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html
Change Summary:
- Remove WIP from this review request. :)
- Update Description and Testing Done.
- Add screenshots of the change
- Remove statement for debugging
- Clean up other small code style-related issues.
Summary: |
|
|||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||
Testing Done: |
|
|||||||||||||||||||||
Commit: |
|
|||||||||||||||||||||
Diff: |
Revision 5 (+40 -5) |
|||||||||||||||||||||
Added Files: |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html
-
-
-
-
reviewboard/static/rb/css/pages/reviews.less (Diff revision 5) CSS selectors should be ordered as:
&.foo {} a {} .foo {} #foo{}Within each group the selectors should be ordered alphabetically.
-
reviewboard/static/rb/css/pages/reviews.less (Diff revision 5) I do not know that this comment. is necessary.
-
-
reviewboard/templates/reviews/review_reply.html (Diff revision 5) The
draftrendering and thenew-commentrendering should be mutually exclusive. Additionally, producing an element with two differentclass=attribtues is not valid. Move the class attribute generation into anif-elif.
Change Summary:
Address the issues raised by Barret.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 6 (+38 -4) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html
-
-
I think if both the review and replies are new, we can just leave the whole box shaded and avoid the extra border in the middle.
-
reviewboard/templates/reviews/boxes/review.html (Diff revision 6) This line looks like it got unintentionally indented 1 space.
Change Summary:
Fix issues raised in David's review
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 7 (+37 -3) |
||||
Added Files: |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html
-
-
reviewboard/static/rb/css/pages/reviews.less (Diff revision 7) It doesn't seem useful to have separate definitions for entry and comment which are the same. Can we merge these?
Change Summary:
- Fix the caption in the updated image.
- Make page-entries and comments use the same LESS variables, as they were using the same colours.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 8 (+35 -3) |
||||
Added Files: |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html
-
-
reviewboard/static/rb/css/pages/reviews.less (Diff revision 8) The
#reviews .review-request-page-entrypart can be consolidated, like:#reviews .review-request-page-entry { &.new-page-entry { ... } &:not(.new-page-entry) { ... } } -
reviewboard/static/rb/css/pages/reviews.less (Diff revision 8) The 4px should also be in a constant.
-
Change Summary:
- Update etag set before the review request page is rendered to include whether an entry has been posted since the user last visited the review request.
- Address issues raised by Christian.
- Update summary/description/testing done for clarification.
Summary: |
|
|||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Description: |
|
|||||||||||||||||||||
Testing Done: |
|
|||||||||||||||||||||
Commit: |
|
|||||||||||||||||||||
Diff: |
Revision 9 (+51 -7) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html
RK
-
-
reviewboard/reviews/views.py (Diff revision 9) Maybe when wrapping and using multiple keyword arguments, you can have one keyword argument per line since there are lots of arguments (better readability).
ex:
etag = encode_tag(
'%s:%s:%s:%s:%s:%s:%s:%s:%s:%s:%s' %
request.user,
last_activity_time,
draft_timestamp,
...
)
Change Summary:
Fix styling related issue raised by Raman.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 10 (+60 -12) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html
Change Summary:
- Add unit tests for checking if
new-page-entryandnew-commentare both added and removed correctly.
Testing Done: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||||||||
Diff: |
Revision 11 (+118 -12) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html -
-
-
-
-
reviewboard/reviews/tests/test_views.py (Diff revision 11) local variable 'review' is assigned to but never used
-
This is looking great! Some recommendations for styling and just some conventions we have in our codebase, but this is close to landing!
-
reviewboard/reviews/tests/test_views.py (Diff revision 11) For unit test descriptions (modern ones, anyway), we try to start off with the component/page that's being tested, followed by the condition. So, something more like: "Testing review_detail view sets new-page-entry CSS class on reviews when ..."
("CSS class" helps distinguish from Python classes.)
There should also be one unit test per condition, so one for ensuring the class is set when it should be, one for ensuring the class is not set when it you've visited since. It's fine to repeat some of the setup logic that may have been covered in another unit test. What having multiple tests ultimately does is help when things go wrong. For instance, if the latter case fails, but the former doesn't, there's less diagnostics that have to happen to know what actually failed.
Same applies below.
-
reviewboard/reviews/tests/test_views.py (Diff revision 11) self.client.loginwill return the user, so you can use that directly.Same below.
-
-
reviewboard/reviews/tests/test_views.py (Diff revision 11) Older tests don't do this, but we should actually use
local_site_reverseto get the URL instead of hard-coding it.Also, when referencing IDs, you should use
.pkinstead of.id. With review requests, though, when you're dealing with URLs or for display purposes, you should always use.display_id.Same below.
-
reviewboard/reviews/tests/test_views.py (Diff revision 11) It would be better to check for something more specific here (and below), since "new-page-entry" could theoretically be anywhere.
-
reviewboard/reviews/views.py (Diff revision 11) Can you wrap the comparison in parenthesis? Helps to visually distinguish those.
-
reviewboard/reviews/views.py (Diff revision 11) Let's put the
(on the line with the format strings. That way, all entries have a nice 4 space indentation. -
reviewboard/static/rb/css/pages/reviews.less (Diff revision 11) Can you add a comment about this?
I know we talked about this a bit, but wouldn't we want this to actually be in the base CSS for this element, rather than right here? It seems like we'd need to be consistent. Either always have it or never.
-
reviewboard/templates/reviews/review_reply.html (Diff revision 11) There's actually a little template tag you can use here for the class building:
<li{% attr "class" %}{% if draft %}draft{% elif last_visited <= timestamp %}new-comment{% endif %}{% endattr %} ...>That will conditionally add the "class" attribute if there's any content to put in it.
Change Summary:
- Resolve issues raised by Christian.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 12 (+212 -12) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html -
-
-
-
-
reviewboard/reviews/tests/test_views.py (Diff revision 12) Col: 80 E501 line too long (80 > 79 characters)
-
reviewboard/reviews/tests/test_views.py (Diff revision 12) Col: 80 E501 line too long (80 > 79 characters)
Change Summary:
- Resolve issues raised by Review Bot.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 13 (+215 -12) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html -
-
-
-
MO
-
-
reviewboard/reviews/tests/test_views.py (Diff revision 13) I would use docstring comment here (triple quotes)
-
reviewboard/reviews/views.py (Diff revision 13) maybe you should remove this blank line (unless that's the style guideline used elsewhere)
-
reviewboard/reviews/views.py (Diff revision 13) I like the fact that you put these on new lines. Makes it more readable in my opinion.
-
reviewboard/static/rb/css/pages/reviews.less (Diff revision 13) I would add a new blank line here. Seems like that's the general style in this file (blank line after a multiline comment).
-
reviewboard/templates/reviews/boxes/change.html (Diff revision 13) is it possible to split this
divinto two lines? -
-
reviewboard/templates/reviews/review_reply.html (Diff revision 13) is it possible to split this
litag into two lines?
Change Summary:
- Small style fixes to issues raised by Mons.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 14 (+215 -12) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html -
-
-
-
-
-
reviewboard/reviews/tests/test_views.py (Diff revision 14) We prefer to format formatting statements like this as :
text = ( ' .... ' % foo ) -
-
-
-
Change Summary:
- Resolve issues raised by Barret.
Description: |
|
||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
||||||||||||||||||
Diff: |
Revision 15 (+225 -12) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html -
-
-
-
Change Summary:
- Remove
clear: bothfrom#reviews .review .bodyas mentioned in Christian's review. This is old code that is unnecessary now.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 16 (+215 -14) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html -
-
-
-
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 17 (+216 -15) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html -
Change Summary:
- Merge rebasing.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 18 (+215 -14) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html
Change Summary:
- Use regular expressions to make checking for CSS classes more general yet still precise.
- Note that the unit tests for the review replies have been changed from
..._new_repliesto..._new_review_replies.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 19 (+232 -14) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html -
-
reviewboard/reviews/tests/test_views.py (Diff revision 19) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/reviews/tests/test_views.py (Diff revision 19) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/reviews/tests/test_views.py (Diff revision 19) Col: 17 E126 continuation line over-indented for hanging indent
-
reviewboard/reviews/tests/test_views.py (Diff revision 19) Col: 17 E126 continuation line over-indented for hanging indent
Change Summary:
- Fix issues raised by ReviewBot.
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 20 (+232 -14) |
-
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/tests/test_views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/static/rb/css/pages/reviews.less reviewboard/templates/reviews/review_reply.html reviewboard/templates/reviews/boxes/change.html
Tool: Pyflakes Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/templates/reviews/review_reply.html Tool: PEP8 Style Checker Processed Files: reviewboard/reviews/views.py reviewboard/reviews/templatetags/reviewtags.py Ignored Files: reviewboard/templates/reviews/boxes/review.html reviewboard/templates/reviews/review_reply.html