Allow inactive users to be fetched from the API
Review Request #8667 — Created Jan. 26, 2017 and submitted
Previously attempting to retrieve a user from the API who had been set
to inactive would result in a 404 Not Found, which was an issue for any
review requests or reviews they had created (as the link included would
not work). Now we return a user from the/api/users/<username>/
API
regardless of whether or not they are active. However, we still filter
out users from the/api/users/
API unlessinclude-inactive=1
is
provided as a GET parameter to the request.
Ran unit tests.
Description | From | Last Updated |
---|---|---|
Oh, one small typo in your description: /api/user/<username>/ should be /api/users/<username>/ |
david | |
Missing a trailing period. I'd also maybe have this maybe clarify in some form that active means the account is … |
chipx86 | |
Instead of this query, let's use a queryset that checks against is_active. |
chipx86 | |
Same here. |
chipx86 | |
Set literals are only available in Python 2.7, but this change is on release-2.5.x. We should just make this a … |
david | |
Set literals are only available in Python 2.7, but this change is on release-2.5.x. We should just make this a … |
david |
-
-
reviewboard/webapi/resources/user.py (Diff revision 1) Missing a trailing period.
I'd also maybe have this maybe clarify in some form that active means the account is enabled. It's kind of odd terminology.
-
reviewboard/webapi/tests/test_user.py (Diff revision 1) Instead of this query, let's use a queryset that checks against
is_active
. -
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 2 (+68 -2) |
-
Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/user.py reviewboard/webapi/tests/test_user.py Tool: Pyflakes Processed Files: reviewboard/webapi/resources/user.py reviewboard/webapi/tests/test_user.py
-
-
reviewboard/webapi/tests/test_user.py (Diff revision 2) Set literals are only available in Python 2.7, but this change is on release-2.5.x. We should just make this a list.
-
reviewboard/webapi/tests/test_user.py (Diff revision 2) Set literals are only available in Python 2.7, but this change is on release-2.5.x. We should just make this a list.
Change Summary:
Do not use set literals in Python 2.6 supported version of Review Board.
Commit: |
|
||||
---|---|---|---|---|---|
Diff: |
Revision 3 (+68 -2) |
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/user.py reviewboard/webapi/tests/test_user.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/user.py reviewboard/webapi/tests/test_user.py
Description: |
|
---|