Allow inactive users to be fetched from the API
Review Request #8667 — Created Jan. 26, 2017 and submitted
Previously attempting to retrieve a user from the API who had been set
to inactive would result in a 404 Not Found, which was an issue for any
review requests or reviews they had created (as the link included would
not work). Now we return a user from the/api/users/<username>/API
regardless of whether or not they are active. However, we still filter
out users from the/api/users/API unlessinclude-inactive=1is
provided as a GET parameter to the request.
Ran unit tests.
| Description | From | Last Updated |
|---|---|---|
|
Oh, one small typo in your description: /api/user/<username>/ should be /api/users/<username>/ |
 david
|
|
|
Missing a trailing period. I'd also maybe have this maybe clarify in some form that active means the account is … |
 chipx86
|
|
|
Instead of this query, let's use a queryset that checks against is_active. |
chipx86
|
|
|
Same here. |
chipx86
|
|
|
Set literals are only available in Python 2.7, but this change is on release-2.5.x. We should just make this a … |
david
|
|
|
Set literals are only available in Python 2.7, but this change is on release-2.5.x. We should just make this a … |
david
|
-
Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/user.py reviewboard/webapi/tests/test_user.py Tool: Pyflakes Processed Files: reviewboard/webapi/resources/user.py reviewboard/webapi/tests/test_user.py
- Change Summary:
-
Do not use set literals in Python 2.6 supported version of Review Board.
- Commit:
-
0a62330a9ef68527f589b35c6be9041cf3e0420a39bab3c14cbbf997968de8f01650838442b57d57
-
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/user.py reviewboard/webapi/tests/test_user.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/user.py reviewboard/webapi/tests/test_user.py
- Description:
-
Previously attempting to retrieve a user from the API who had been set
to inactive would result in a 404 Not Found, which was an issue for any review requests or reviews they had created (as the link included would ~ not work). Now we return a user from the /api/user/<username>/API~ not work). Now we return a user from the /api/users/<username>/APIregardless of whether or not they are active. However, we still filter out users from the /api/users/API unlessinclude-inactive=1isprovided as a GET parameter to the request.
Tool: Pyflakes Processed Files: reviewboard/webapi/resources/user.py reviewboard/webapi/tests/test_user.py Tool: PEP8 Style Checker Processed Files: reviewboard/webapi/resources/user.py reviewboard/webapi/tests/test_user.py