Validate the bug tracker URLs for Jira and VersionOne.

Review Request #8664 — Created Jan. 24, 2017 and submitted

Information

Review Board
release-2.5.x
ed362ce...

Reviewers

Both Jira and VersionOne were allowing for URLs containing a "%s", which
were incorrect. The URLs were supposed to be the URLs to the service,
rather than a specific ticket. This ultimately led to crashes when
trying to navigate to the bug.

This change adds the missing validators for these fields.

Tested that I could no longer specify bug trackers containing "%s", which
was otherwise causing crashes.

reviewbot
  1. Tool: PEP8 Style Checker
    Processed Files:
        reviewboard/hostingsvcs/versionone.py
        reviewboard/hostingsvcs/jira.py
    
    
    
    Tool: Pyflakes
    Processed Files:
        reviewboard/hostingsvcs/versionone.py
        reviewboard/hostingsvcs/jira.py
    
    
  2. 
      
david
  1. Ship It!
  2. 
      
chipx86
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-2.5.x (9b11d43)
Loading...