Viewing a reply to a comment on the diff page now properly scrolls down to that reply

Review Request #8640 — Created Jan. 20, 2017 and submitted

Information

Review Board
release-2.5.x
f9c9401...

Reviewers

When clicking on the "View" button on a comment that is a reply to
another top-level comment, the browser redirected, but it didn't scroll
down to that specific reply you were trying to review.

I added an anchor tag in review_reply.html such that when clicking on the
view button, it now properly scrolls down to that comment.

I reloaded the page on the dev-server (using MacOS Sierra, Chrome), clicked the
view button, and it redirected to the diff page and properly scrolled down
to the corresponding comment.

Description From Last Updated

Make sure the description and testing text wraps to ideally <= 70 characters (a standard line length for Git commits), …

chipx86chipx86
reviewbot
  1. Tool: Pyflakes
    Ignored Files:
        reviewboard/templates/reviews/review_reply.html
    
    
    
    Tool: PEP8 Style Checker
    Ignored Files:
        reviewboard/templates/reviews/review_reply.html
    
    
  2. 
      
DA
  1. Add testing

  2. 
      
MO
chipx86
  1. 
      
  2. Make sure the description and testing text wraps to ideally <= 70 characters (a standard line length for Git commits), as this will be used for the Git commit.

  3. 
      
MO
david
  1. Ship It!
  2. 
      
MO
Review request changed

Status: Closed (submitted)

Change Summary:

Pushed to release-3.0.x (e866ae4)
Loading...