Viewing a reply to a comment on the diff page now properly scrolls down to that reply
Review Request #8640 — Created Jan. 20, 2017 and submitted
Information | |
---|---|
Mons | |
Review Board | |
release-2.5.x | |
4085 | |
f9c9401... | |
Reviewers | |
reviewboard, students | |
When clicking on the "View" button on a comment that is a reply to
another top-level comment, the browser redirected, but it didn't scroll
down to that specific reply you were trying to review.I added an anchor tag in review_reply.html such that when clicking on the
view button, it now properly scrolls down to that comment.
I reloaded the page on the dev-server (using MacOS Sierra, Chrome), clicked the
view button, and it redirected to the diff page and properly scrolled down
to the corresponding comment.
Description | From | Last Updated |
---|---|---|
Make sure the description and testing text wraps to ideally <= 70 characters (a standard line length for Git commits), … |
|
Change Summary:
Description and testing no longer text-wraps (<= 70 chars)
Description: |
|
||||||||||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|