Summary

Viewing a reply to a comment on the diff page now properly scrolls down to that reply

Review Request #8640 — Created Jan. 20, 2017 and submitted Jan. 22, 2017, 8:39 a.m.

Information

Owner

Mons

Repository

Review Board

Branch

release-2.5.x

Bugs

4085

Depends On

Commit

f9c9401...

Reviewers

Groups

reviewboard, students

People

Description

When clicking on the "View" button on a comment that is a reply to
another top-level comment, the browser redirected, but it didn't scroll
down to that specific reply you were trying to review.

I added an anchor tag in review_reply.html such that when clicking on the
view button, it now properly scrolls down to that comment.

Testing Done

I reloaded the page on the dev-server (using MacOS Sierra, Chrome), clicked the
view button, and it redirected to the diff page and properly scrolled down
to the corresponding comment.

Issues

Description	From	Last Updated
Make sure the description and testing text wraps to ideally <= 70 characters (a standard line length for Git commits), …	chipx86	Jan. 21, 2017, 9:25 a.m.

Tool: Pyflakes
Ignored Files:
    reviewboard/templates/reviews/review_reply.html



Tool: PEP8 Style Checker
Ignored Files:
    reviewboard/templates/reviews/review_reply.html

```
Add testing
```

Testing Done:: +
I reloaded the page on the dev-server (using MacOS Sierra, Chrome), clicked the view button, and it redirected to the diff page and properly scrolled down to the corresponding comment.
Branch:: master
release-2.5.x

The issue has been resolved. Show all issues

Make sure the description and testing text wraps to ideally <= 70 characters (a standard line length for Git commits), as this will be used for the Git commit.

Change Summary:: Description and testing no longer text-wraps (<= 70 chars)
Description:: ~
When clicking on the "View" button on a comment that is a reply to another top-level comment, the browser redirected, but it didn't scroll down to that specific reply you were trying to review.
~
When clicking on the "View" button on a comment that is a reply to
+ another top-level comment, the browser redirected, but it didn't scroll
+ down to that specific reply you were trying to review.

~
I added an anchor tag in review_reply.html such that when clicking on the view button, it now properly scrolls down to that comment.
~
I added an anchor tag in review_reply.html such that when clicking on the
+ view button, it now properly scrolls down to that comment.
Testing Done:: ~
I reloaded the page on the dev-server (using MacOS Sierra, Chrome), clicked the view button, and it redirected to the diff page and properly scrolled down to the corresponding comment.
~
I reloaded the page on the dev-server (using MacOS Sierra, Chrome), clicked the
+ view button, and it redirected to the diff page and properly scrolled down
+ to the corresponding comment.

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-3.0.x (e866ae4)

~		When clicking on the "View" button on a comment that is a reply to another top-level comment, the browser redirected, but it didn't scroll down to that specific reply you were trying to review.
	~	When clicking on the "View" button on a comment that is a reply to
	+	another top-level comment, the browser redirected, but it didn't scroll
	+	down to that specific reply you were trying to review.

~		I added an anchor tag in review_reply.html such that when clicking on the view button, it now properly scrolls down to that comment.
	~	I added an anchor tag in review_reply.html such that when clicking on the
	+	view button, it now properly scrolls down to that comment.

~		I reloaded the page on the dev-server (using MacOS Sierra, Chrome), clicked the view button, and it redirected to the diff page and properly scrolled down to the corresponding comment.
	~	I reloaded the page on the dev-server (using MacOS Sierra, Chrome), clicked the
	+	view button, and it redirected to the diff page and properly scrolled down
	+	to the corresponding comment.