Fixed Localization in the Admin UI Settings forms
Review Request #8639 — Created Jan. 20, 2017 and submitted — Latest diff uploaded
The forms in reviewboard.admin.forms use ugettext (as _(...)) for the form fields, which means they're not localized at page render time. To fix this, I updated the _ alias to be for ugettext_lazy instead of ugettext and imported ugettext.
I compared translations in the webpage with django's translation log (reviewboard/locale/it_IT/LC_MESSAGES/django.po:msgstr), and ensured translations from the log are also visible in the webpage.
Diff Revision 6 (Latest)
orig
1
2
3
4
5
6
| reviewboard/admin/forms.py |
|---|
| reviewboard/reviews/models/default_reviewer.py |
|---|
| reviewboard/reviews/models/diff_comment.py |
|---|
| reviewboard/reviews/models/file_attachment_comment.py |
|---|
| reviewboard/reviews/models/general_comment.py |
|---|
| reviewboard/reviews/models/group.py |
|---|
| reviewboard/reviews/models/review.py |
|---|
| reviewboard/reviews/models/review_request.py |
|---|
| reviewboard/reviews/models/review_request_draft.py |
|---|
| reviewboard/reviews/models/screenshot.py |
|---|
| reviewboard/reviews/models/screenshot_comment.py |
|---|
| reviewboard/reviews/models/status_update.py |
|---|
| reviewboard/scmtools/admin.py |
|---|
| reviewboard/scmtools/models.py |
|---|