-
-
-
reviewboard/reviews/models/screenshot_comment.py (Diff revision 1) Col: 55 W292 no newline at end of file
Fixed Localization in the Admin UI Settings forms
Review Request #8639 — Created Jan. 20, 2017 and submitted
The forms in reviewboard.admin.forms use ugettext (as _(...)) for the form fields, which means they're not localized at page render time. To fix this, I updated the _ alias to be for ugettext_lazy instead of ugettext and imported ugettext.
I compared translations in the webpage with django's translation log (reviewboard/locale/it_IT/LC_MESSAGES/django.po:msgstr), and ensured translations from the log are also visible in the webpage.
| Description | From | Last Updated |
|---|---|---|
|
Make sure the description and testing text wraps to ideally <= 70 characters (a standard line length for Git commits), … |
 chipx86
|
|
|
This is happening within a method (not the top-level class), so we should make it use the regular ugettext(). |
 david
|
|
|
Should use ugettext(). |
david
|
|
|
Should use ugettext(). |
david
|
|
|
Should use ugettext(). |
david
|
|
|
Should use ugettext(). |
david
|
|
|
Should use ugettext(). |
david
|
|
|
Should use ugettext(). |
david
|
|
|
Should use ugettext(). |
david
|
|
|
Should use ugettext(). |
david
|
|
|
Col: 44 W292 no newline at end of file |
 reviewbot
|
|
|
Col: 55 W292 no newline at end of file |
reviewbot
|
|
|
Can you remove this blank line? (so the function definition is adjacent to the property set) |
david
|
|
|
There's no ugettext import. The code as up for review cannot work. Make sure you test every code path! |
chipx86
|
|
|
undefined name 'ugettext' |
reviewbot
|
|
|
undefined name 'ugettext' |
reviewbot
|
|
|
undefined name 'ugettext' |
reviewbot
|
|
|
undefined name 'ugettext' |
reviewbot
|
|
|
undefined name 'ugettext' |
reviewbot
|
|
|
Make sure text is aligned properly. |
chipx86
|
|
|
Col: 80 E501 line too long (86 > 79 characters) |
reviewbot
|
|
|
undefined name 'ugettext' |
reviewbot
|
|
|
undefined name 'ugettext' |
reviewbot
|
|
|
undefined name 'ugettext' |
reviewbot
|
|
|
undefined name 'ugettext' |
reviewbot
|
|
|
undefined name 'ugettext' |
reviewbot
|
|
|
undefined name 'ugettext' |
reviewbot
|
|
|
undefined name 'ugettext' |
reviewbot
|
|
|
undefined name 'ugettext' |
reviewbot
|
|
|
undefined name 'ugettext' |
reviewbot
|
|
|
undefined name 'ugettext' |
reviewbot
|
|
|
Col: 80 E501 line too long (81 > 79 characters) |
reviewbot
|
|
|
Make sure text is aligned properly. |
chipx86
|
|
|
Col: 44 W292 no newline at end of file |
reviewbot
|
|
|
django is a third-party module, so it should be in its own import group, above reviewboard, separated by a blank … |
chipx86
|
|
|
Strings should ideally be single quotes. Can you fix up the old one as well? |
chipx86
|
|
|
Col: 55 W292 no newline at end of file |
reviewbot
|
|
|
Strings should ideally be single quotes. |
chipx86
|
|
|
Strings should ideally be single quotes. |
chipx86
|
|
|
Col: 25 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 19 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
Col: 19 E128 continuation line under-indented for visual indent |
reviewbot
|
|
|
There shouldn't be a blank line here (both "django" and "djblets" are "3rd party libraries" from the perspective of the … |
david
|
|
|
Col: 80 E501 line too long (80 > 79 characters) |
reviewbot
|
|
|
It was already like this, but can you fix this string to only end in a single period? |
david
|
|
|
Please undo this line addition. |
david
|
-
There's a number of comments here, but it's really all just the same issue: any call to
_()within a method should useugettext(). -
reviewboard/admin/forms.py (Diff revision 1) This is happening within a method (not the top-level class), so we should make it use the regular
ugettext(). -
-
-
-
-
-
-
-
-
reviewboard/scmtools/admin.py (Diff revision 1) Can you remove this blank line? (so the function definition is adjacent to the property set)
RK
Change Summary:
"Replaced _() with ugettext() in forms.py methods and removed blank line."
Testing Done: |
|
|||||||||
|---|---|---|---|---|---|---|---|---|---|---|
Commit: |
|
|||||||||
Diff: |
Revision 2 (+53 -18) |
-
Tool: Pyflakes Processed Files: reviewboard/admin/forms.py reviewboard/reviews/models/screenshot.py reviewboard/reviews/models/review_request_draft.py reviewboard/scmtools/models.py reviewboard/scmtools/admin.py reviewboard/reviews/models/file_attachment_comment.py reviewboard/reviews/models/group.py reviewboard/reviews/models/diff_comment.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/status_update.py reviewboard/reviews/models/default_reviewer.py reviewboard/reviews/models/general_comment.py reviewboard/reviews/models/screenshot_comment.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/admin/forms.py reviewboard/reviews/models/screenshot.py reviewboard/reviews/models/review_request_draft.py reviewboard/scmtools/models.py reviewboard/scmtools/admin.py reviewboard/reviews/models/file_attachment_comment.py reviewboard/reviews/models/group.py reviewboard/reviews/models/diff_comment.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/status_update.py reviewboard/reviews/models/default_reviewer.py reviewboard/reviews/models/general_comment.py reviewboard/reviews/models/screenshot_comment.py reviewboard/reviews/models/review.py -
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
reviewboard/reviews/models/screenshot_comment.py (Diff revision 2) Col: 55 W292 no newline at end of file
-
-
Make sure the description and testing text wraps to ideally <= 70 characters (a standard line length for Git commits), as this will be used for the Git commit.
The description should also tell a story about your change, rather than being effectively a bullet point list of the changes made. See https://www.notion.so/reviewboard/Writing-Good-Change-Descriptions-10529e7c207743fa8ca90153d4b21fea for information on requirements and examples.
-
reviewboard/admin/forms.py (Diff revision 2) There's no
ugettextimport. The code as up for review cannot work. Make sure you test every code path! -
-
-
reviewboard/reviews/models/general_comment.py (Diff revision 2) djangois a third-party module, so it should be in its own import group, abovereviewboard, separated by a blank line. -
reviewboard/reviews/models/group.py (Diff revision 2) Strings should ideally be single quotes.
Can you fix up the old one as well?
-
-
RK
Description: |
|
||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Testing Done: |
|
||||||||||||
Commit: |
|
||||||||||||
Diff: |
Revision 3 (+61 -22) |
-
Tool: Pyflakes Processed Files: reviewboard/admin/forms.py reviewboard/reviews/models/screenshot.py reviewboard/reviews/models/review_request_draft.py reviewboard/scmtools/models.py reviewboard/scmtools/admin.py reviewboard/reviews/models/file_attachment_comment.py reviewboard/reviews/models/group.py reviewboard/reviews/models/diff_comment.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/status_update.py reviewboard/reviews/models/default_reviewer.py reviewboard/reviews/models/general_comment.py reviewboard/reviews/models/screenshot_comment.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/admin/forms.py reviewboard/reviews/models/screenshot.py reviewboard/reviews/models/review_request_draft.py reviewboard/scmtools/models.py reviewboard/scmtools/admin.py reviewboard/reviews/models/file_attachment_comment.py reviewboard/reviews/models/group.py reviewboard/reviews/models/diff_comment.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/status_update.py reviewboard/reviews/models/default_reviewer.py reviewboard/reviews/models/general_comment.py reviewboard/reviews/models/screenshot_comment.py reviewboard/reviews/models/review.py -
reviewboard/admin/forms.py (Diff revision 3) Col: 25 E128 continuation line under-indented for visual indent
-
reviewboard/admin/forms.py (Diff revision 3) Col: 19 E128 continuation line under-indented for visual indent
-
reviewboard/admin/forms.py (Diff revision 3) Col: 19 E128 continuation line under-indented for visual indent
RK
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 4 (+61 -22) |
-
Tool: Pyflakes Processed Files: reviewboard/admin/forms.py reviewboard/reviews/models/screenshot.py reviewboard/reviews/models/review_request_draft.py reviewboard/scmtools/models.py reviewboard/scmtools/admin.py reviewboard/reviews/models/file_attachment_comment.py reviewboard/reviews/models/group.py reviewboard/reviews/models/diff_comment.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/status_update.py reviewboard/reviews/models/default_reviewer.py reviewboard/reviews/models/general_comment.py reviewboard/reviews/models/screenshot_comment.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/admin/forms.py reviewboard/reviews/models/screenshot.py reviewboard/reviews/models/review_request_draft.py reviewboard/scmtools/models.py reviewboard/scmtools/admin.py reviewboard/reviews/models/file_attachment_comment.py reviewboard/reviews/models/group.py reviewboard/reviews/models/diff_comment.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/status_update.py reviewboard/reviews/models/default_reviewer.py reviewboard/reviews/models/general_comment.py reviewboard/reviews/models/screenshot_comment.py reviewboard/reviews/models/review.py -
RK
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 5 (+62 -22) |
-
Tool: Pyflakes Processed Files: reviewboard/admin/forms.py reviewboard/reviews/models/screenshot.py reviewboard/reviews/models/review_request_draft.py reviewboard/scmtools/models.py reviewboard/scmtools/admin.py reviewboard/reviews/models/file_attachment_comment.py reviewboard/reviews/models/group.py reviewboard/reviews/models/diff_comment.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/status_update.py reviewboard/reviews/models/default_reviewer.py reviewboard/reviews/models/general_comment.py reviewboard/reviews/models/screenshot_comment.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/admin/forms.py reviewboard/reviews/models/screenshot.py reviewboard/reviews/models/review_request_draft.py reviewboard/scmtools/models.py reviewboard/scmtools/admin.py reviewboard/reviews/models/file_attachment_comment.py reviewboard/reviews/models/group.py reviewboard/reviews/models/diff_comment.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/status_update.py reviewboard/reviews/models/default_reviewer.py reviewboard/reviews/models/general_comment.py reviewboard/reviews/models/screenshot_comment.py reviewboard/reviews/models/review.py
-
Just a few trivial comments:
-
reviewboard/admin/forms.py (Diff revision 4) There shouldn't be a blank line here (both "django" and "djblets" are "3rd party libraries" from the perspective of the reviewboard module).
-
reviewboard/admin/forms.py (Diff revision 4) It was already like this, but can you fix this string to only end in a single period?
-
RK
Commit: |
|
||||
|---|---|---|---|---|---|
Diff: |
Revision 6 (+60 -22) |
-
Tool: Pyflakes Processed Files: reviewboard/admin/forms.py reviewboard/reviews/models/screenshot.py reviewboard/reviews/models/review_request_draft.py reviewboard/scmtools/models.py reviewboard/scmtools/admin.py reviewboard/reviews/models/file_attachment_comment.py reviewboard/reviews/models/group.py reviewboard/reviews/models/diff_comment.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/status_update.py reviewboard/reviews/models/default_reviewer.py reviewboard/reviews/models/general_comment.py reviewboard/reviews/models/screenshot_comment.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/admin/forms.py reviewboard/reviews/models/screenshot.py reviewboard/reviews/models/review_request_draft.py reviewboard/scmtools/models.py reviewboard/scmtools/admin.py reviewboard/reviews/models/file_attachment_comment.py reviewboard/reviews/models/group.py reviewboard/reviews/models/diff_comment.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/status_update.py reviewboard/reviews/models/default_reviewer.py reviewboard/reviews/models/general_comment.py reviewboard/reviews/models/screenshot_comment.py reviewboard/reviews/models/review.py
Tool: Pyflakes Processed Files: reviewboard/admin/forms.py reviewboard/reviews/models/screenshot.py reviewboard/reviews/models/review_request_draft.py reviewboard/scmtools/models.py reviewboard/scmtools/admin.py reviewboard/reviews/models/file_attachment_comment.py reviewboard/reviews/models/group.py reviewboard/reviews/models/diff_comment.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/status_update.py reviewboard/reviews/models/default_reviewer.py reviewboard/reviews/models/general_comment.py reviewboard/reviews/models/screenshot_comment.py reviewboard/reviews/models/review.py Tool: PEP8 Style Checker Processed Files: reviewboard/admin/forms.py reviewboard/reviews/models/screenshot.py reviewboard/reviews/models/review_request_draft.py reviewboard/scmtools/models.py reviewboard/scmtools/admin.py reviewboard/reviews/models/file_attachment_comment.py reviewboard/reviews/models/group.py reviewboard/reviews/models/diff_comment.py reviewboard/reviews/models/review_request.py reviewboard/reviews/models/status_update.py reviewboard/reviews/models/default_reviewer.py reviewboard/reviews/models/general_comment.py reviewboard/reviews/models/screenshot_comment.py reviewboard/reviews/models/review.py