Summary

Fixed Localization in the Admin UI Settings forms

Review Request #8639 — Created Jan. 20, 2017 and submitted Jan. 24, 2017, 2:44 p.m.

Information

Owner

rkdhatt

Repository

Review Board

Branch

master

Bugs

4512

Depends On

Commit

60573e8...

Reviewers

Groups

reviewboard, students

People

Description

The forms in reviewboard.admin.forms use ugettext (as _(...)) for the form fields, which means they're not localized at page render time. To fix this, I updated the _ alias to be for ugettext_lazy instead of ugettext and imported ugettext.

Testing Done

I compared translations in the webpage with django's translation log (reviewboard/locale/it_IT/LC_MESSAGES/django.po:msgstr), and ensured translations from the log are also visible in the webpage.

Issues

Description	From	Last Updated
Make sure the description and testing text wraps to ideally <= 70 characters (a standard line length for Git commits), …	chipx86	Jan. 21, 2017, 2:53 p.m.
This is happening within a method (not the top-level class), so we should make it use the regular ugettext().	david	Jan. 21, 2017, 12:31 p.m.
Should use ugettext().	david	Jan. 21, 2017, 12:32 p.m.
Should use ugettext().	david	Jan. 21, 2017, 12:32 p.m.
Should use ugettext().	david	Jan. 21, 2017, 12:32 p.m.
Should use ugettext().	david	Jan. 21, 2017, 12:32 p.m.
Should use ugettext().	david	Jan. 21, 2017, 12:32 p.m.
Should use ugettext().	david	Jan. 21, 2017, 12:32 p.m.
Should use ugettext().	david	Jan. 21, 2017, 12:32 p.m.
Should use ugettext().	david	Jan. 21, 2017, 12:32 p.m.
Col: 44 W292 no newline at end of file	reviewbot	Jan. 21, 2017, 12:31 p.m.
Col: 55 W292 no newline at end of file	reviewbot	Jan. 21, 2017, 12:31 p.m.
Can you remove this blank line? (so the function definition is adjacent to the property set)	david	Jan. 21, 2017, 12:32 p.m.
There's no ugettext import. The code as up for review cannot work. Make sure you test every code path!	chipx86	Jan. 21, 2017, 12:57 p.m.
undefined name 'ugettext'	reviewbot	Jan. 21, 2017, 12:59 p.m.
undefined name 'ugettext'	reviewbot	Jan. 21, 2017, 12:59 p.m.
undefined name 'ugettext'	reviewbot	Jan. 21, 2017, 12:59 p.m.
undefined name 'ugettext'	reviewbot	Jan. 21, 2017, 12:59 p.m.
undefined name 'ugettext'	reviewbot	Jan. 21, 2017, 12:59 p.m.
Make sure text is aligned properly.	chipx86	Jan. 21, 2017, 12:57 p.m.
Col: 80 E501 line too long (86 > 79 characters)	reviewbot	Jan. 21, 2017, 12:59 p.m.
undefined name 'ugettext'	reviewbot	Jan. 21, 2017, 12:59 p.m.
undefined name 'ugettext'	reviewbot	Jan. 21, 2017, 12:58 p.m.
undefined name 'ugettext'	reviewbot	Jan. 21, 2017, 12:58 p.m.
undefined name 'ugettext'	reviewbot	Jan. 21, 2017, 12:58 p.m.
undefined name 'ugettext'	reviewbot	Jan. 21, 2017, 12:58 p.m.
undefined name 'ugettext'	reviewbot	Jan. 21, 2017, 12:58 p.m.
undefined name 'ugettext'	reviewbot	Jan. 21, 2017, 12:58 p.m.
undefined name 'ugettext'	reviewbot	Jan. 21, 2017, 12:58 p.m.
undefined name 'ugettext'	reviewbot	Jan. 21, 2017, 12:58 p.m.
undefined name 'ugettext'	reviewbot	Jan. 21, 2017, 12:58 p.m.
Col: 80 E501 line too long (81 > 79 characters)	reviewbot	Jan. 21, 2017, 12:58 p.m.
Make sure text is aligned properly.	chipx86	Jan. 21, 2017, 1 p.m.
Col: 44 W292 no newline at end of file	reviewbot	Jan. 21, 2017, 12:58 p.m.
django is a third-party module, so it should be in its own import group, above reviewboard, separated by a blank …	chipx86	Jan. 21, 2017, 12:57 p.m.
Strings should ideally be single quotes. Can you fix up the old one as well?	chipx86	Jan. 21, 2017, 12:57 p.m.
Col: 55 W292 no newline at end of file	reviewbot	Jan. 21, 2017, 12:57 p.m.
Strings should ideally be single quotes.	chipx86	Jan. 21, 2017, 12:57 p.m.
Strings should ideally be single quotes.	chipx86	Jan. 21, 2017, 12:57 p.m.
Col: 25 E128 continuation line under-indented for visual indent	reviewbot	Jan. 21, 2017, 1:08 p.m.
Col: 19 E128 continuation line under-indented for visual indent	reviewbot	Jan. 21, 2017, 1:07 p.m.
Col: 19 E128 continuation line under-indented for visual indent	reviewbot	Jan. 21, 2017, 1:07 p.m.
There shouldn't be a blank line here (both "django" and "djblets" are "3rd party libraries" from the perspective of the …	david	Jan. 21, 2017, 1:19 p.m.
Col: 80 E501 line too long (80 > 79 characters)	reviewbot	Jan. 21, 2017, 1:12 p.m.
It was already like this, but can you fix this string to only end in a single period?	david	Jan. 21, 2017, 1:19 p.m.
Please undo this line addition.	david	Jan. 21, 2017, 1:19 p.m.

Tool: Pyflakes
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/reviews/models/screenshot.py
    reviewboard/reviews/models/review_request_draft.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/admin.py
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/reviews/models/group.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/status_update.py
    reviewboard/reviews/models/default_reviewer.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/reviews/models/screenshot_comment.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/reviews/models/screenshot.py
    reviewboard/reviews/models/review_request_draft.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/admin.py
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/reviews/models/group.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/status_update.py
    reviewboard/reviews/models/default_reviewer.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/reviews/models/screenshot_comment.py
    reviewboard/reviews/models/review.py

reviewboard/reviews/models/diff_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 44
 W292 no newline at end of file
```
reviewboard/reviews/models/screenshot_comment.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Col: 55
 W292 no newline at end of file
```

There's a number of comments here, but it's really all just the same issue: any call to _() within a method should use ugettext().

reviewboard/admin/forms.py (Diff revision 1)

The issue has been resolved. Show all issues

This is happening within a method (not the top-level class), so we should make it use the regular ugettext().

reviewboard/admin/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should use ugettext().
```
reviewboard/admin/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should use ugettext().
```
reviewboard/admin/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should use ugettext().
```
reviewboard/admin/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should use ugettext().
```

reviewboard/admin/forms.py (Diff revision 1)

The issue has been resolved. Show all issues

Should use ugettext().

reviewboard/admin/forms.py (Diff revision 1)

The issue has been resolved. Show all issues

Should use ugettext().

reviewboard/admin/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should use ugettext().
```
reviewboard/admin/forms.py (Diff revision 1)
The issue has been resolved. Show all issues
```
Should use ugettext().
```

reviewboard/scmtools/admin.py (Diff revision 1)

The issue has been resolved. Show all issues

Can you remove this blank line? (so the function definition is adjacent to the property set)

Change Summary:

"Replaced _() with ugettext() in forms.py methods and removed blank line."

Testing Done:

		Compared translations in the webpage with django's translation log (reviewboard/locale/it_IT/LC_MESSAGES/django.po:msgstr)
		Ensured translations from the log are also visible in the webpage.
	+	"Replaced _() with ugettext() in forms.py methods and removed blank line."

Commit:

30e9d58b4ba3592ec2fe223bafab9cb2f525bfaa

c5d63b15f5ddbe3796e1459a2b6bb84475f48349

Diff:

Revision 2 (+53 -18)

Show changes

	reviewboard/admin/forms.py
	reviewboard/reviews/models/default_reviewer.py
	reviewboard/reviews/models/diff_comment.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/general_comment.py
	reviewboard/reviews/models/group.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/reviews/models/screenshot.py
    reviewboard/reviews/models/review_request_draft.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/admin.py
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/reviews/models/group.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/status_update.py
    reviewboard/reviews/models/default_reviewer.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/reviews/models/screenshot_comment.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/reviews/models/screenshot.py
    reviewboard/reviews/models/review_request_draft.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/admin.py
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/reviews/models/group.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/status_update.py
    reviewboard/reviews/models/default_reviewer.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/reviews/models/screenshot_comment.py
    reviewboard/reviews/models/review.py

reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'ugettext'
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'ugettext'
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'ugettext'
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'ugettext'
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'ugettext'
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (86 > 79 characters)
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'ugettext'
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'ugettext'
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'ugettext'
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'ugettext'
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'ugettext'
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'ugettext'
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'ugettext'
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'ugettext'
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'ugettext'
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
 undefined name 'ugettext'
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (81 > 79 characters)
```
reviewboard/reviews/models/diff_comment.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 44
 W292 no newline at end of file
```
reviewboard/reviews/models/screenshot_comment.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Col: 55
 W292 no newline at end of file
```

Bugs:: 4512

The issue has been resolved. Show all issues

Make sure the description and testing text wraps to ideally <= 70 characters (a standard line length for Git commits), as this will be used for the Git commit.

The description should also tell a story about your change, rather than being effectively a bullet point list of the changes made. See https://www.notion.so/reviewboard/Writing-Good-Change-Descriptions-10529e7c207743fa8ca90153d4b21fea for information on requirements and examples.

rkdhatt Jan. 21, 2017, 1:14 p.m.

Hi Christian,
I thought that the description and testing text can be a little longer depending on the complexity of the bug. I tried to make it shorter, let me know if I still need to make it shorter. Thanks!

david Jan. 21, 2017, 1:14 p.m.

Any length is fine, we just want to wrap it.

chipx86 Jan. 21, 2017, 1:16 p.m.

They should definitely be as detailed as needed to properly convey what the change is about (imagine you're writing this for a friend who doesn't know what you're working on, and you're telling them about it). You just want to make sure the lines wrap.

Best tip is to write this when doing the commit, making sure it's wrapping at the right place, and then use that for the review request. This will automatically be pulled in from the commit message, and you can always update from the review request with:

rbt post -g yes <other arguments you pass>

reviewboard/admin/forms.py (Diff revision 2)

The issue has been resolved. Show all issues

There's no ugettext import. The code as up for review cannot work. Make sure you test every code path!

reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Make sure text is aligned properly.
```
reviewboard/admin/forms.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Make sure text is aligned properly.
```

reviewboard/reviews/models/general_comment.py (Diff revision 2)

The issue has been resolved. Show all issues

django is a third-party module, so it should be in its own import group, above reviewboard, separated by a blank line.

reviewboard/reviews/models/group.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Strings should ideally be single quotes.
Can you fix up the old one as well?
```
reviewboard/scmtools/admin.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Strings should ideally be single quotes.
```
reviewboard/scmtools/models.py (Diff revision 2)
The issue has been resolved. Show all issues
```
Strings should ideally be single quotes.
```

Description:

~		Replaced django.utils.translation's ugettext module with ugettext_lazy in admin forms.py.
	~	The forms in reviewboard.admin.forms use ugettext (as _(...)) for the form fields, which means they're not localized at page render time. To fix this, I updated the _ alias to be for ugettext_lazy instead of ugettext and imported ugettext.
-		Added attributes verbose_name and verbose_name_plural in class Meta for each non-base .py file in reviews/models.

Testing Done:

~		Compared translations in the webpage with django's translation log (reviewboard/locale/it_IT/LC_MESSAGES/django.po:msgstr)
	~	I compared translations in the webpage with django's translation log (reviewboard/locale/it_IT/LC_MESSAGES/django.po:msgstr), and ensured translations from the log are also visible in the webpage.
-		Ensured translations from the log are also visible in the webpage.
-		"Replaced _() with ugettext() in forms.py methods and removed blank line."

Commit:

c5d63b15f5ddbe3796e1459a2b6bb84475f48349

3be18ab7a5ea0d6915b7e651327414320aa1dc46

Diff:

Revision 3 (+61 -22)

Show changes

	reviewboard/admin/forms.py
	reviewboard/reviews/models/default_reviewer.py
	reviewboard/reviews/models/diff_comment.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/general_comment.py
	reviewboard/reviews/models/group.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/reviews/models/screenshot.py
    reviewboard/reviews/models/review_request_draft.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/admin.py
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/reviews/models/group.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/status_update.py
    reviewboard/reviews/models/default_reviewer.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/reviews/models/screenshot_comment.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/reviews/models/screenshot.py
    reviewboard/reviews/models/review_request_draft.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/admin.py
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/reviews/models/group.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/status_update.py
    reviewboard/reviews/models/default_reviewer.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/reviews/models/screenshot_comment.py
    reviewboard/reviews/models/review.py

reviewboard/admin/forms.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 25
 E128 continuation line under-indented for visual indent
```
reviewboard/admin/forms.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 19
 E128 continuation line under-indented for visual indent
```
reviewboard/admin/forms.py (Diff revision 3)
The issue has been resolved. Show all issues
```
Col: 19
 E128 continuation line under-indented for visual indent
```

Commit:

3be18ab7a5ea0d6915b7e651327414320aa1dc46

dc601ff3aad4c518bbb3ec5be0994d1f45641305

Diff:

Revision 4 (+61 -22)

Show changes

	reviewboard/admin/forms.py
	reviewboard/reviews/models/default_reviewer.py
	reviewboard/reviews/models/diff_comment.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/general_comment.py
	reviewboard/reviews/models/group.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/reviews/models/screenshot.py
    reviewboard/reviews/models/review_request_draft.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/admin.py
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/reviews/models/group.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/status_update.py
    reviewboard/reviews/models/default_reviewer.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/reviews/models/screenshot_comment.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/reviews/models/screenshot.py
    reviewboard/reviews/models/review_request_draft.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/admin.py
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/reviews/models/group.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/status_update.py
    reviewboard/reviews/models/default_reviewer.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/reviews/models/screenshot_comment.py
    reviewboard/reviews/models/review.py

reviewboard/admin/forms.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Col: 80
 E501 line too long (80 > 79 characters)
```

Commit:

dc601ff3aad4c518bbb3ec5be0994d1f45641305

0e908a7dcd3d38f24a99ed418effb8fa39ef5805

Diff:

Revision 5 (+62 -22)

Show changes

	reviewboard/admin/forms.py
	reviewboard/reviews/models/default_reviewer.py
	reviewboard/reviews/models/diff_comment.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/general_comment.py
	reviewboard/reviews/models/group.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/reviews/models/screenshot.py
    reviewboard/reviews/models/review_request_draft.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/admin.py
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/reviews/models/group.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/status_update.py
    reviewboard/reviews/models/default_reviewer.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/reviews/models/screenshot_comment.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/reviews/models/screenshot.py
    reviewboard/reviews/models/review_request_draft.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/admin.py
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/reviews/models/group.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/status_update.py
    reviewboard/reviews/models/default_reviewer.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/reviews/models/screenshot_comment.py
    reviewboard/reviews/models/review.py

```
Just a few trivial comments:
```

reviewboard/admin/forms.py (Diff revision 4)

The issue has been resolved. Show all issues

There shouldn't be a blank line here (both "django" and "djblets" are "3rd party libraries" from the perspective of the reviewboard module).

reviewboard/admin/forms.py (Diff revision 4)

The issue has been resolved. Show all issues

It was already like this, but can you fix this string to only end in a single period?

reviewboard/reviews/models/screenshot_comment.py (Diff revision 4)
The issue has been resolved. Show all issues
```
Please undo this line addition.
```

Commit:

0e908a7dcd3d38f24a99ed418effb8fa39ef5805

60573e8eac9bf187702fee85c0a6e7ae8b2638a3

Diff:

Revision 6 (+60 -22)

Show changes

	reviewboard/admin/forms.py
	reviewboard/reviews/models/default_reviewer.py
	reviewboard/reviews/models/diff_comment.py
	reviewboard/reviews/models/file_attachment_comment.py
	reviewboard/reviews/models/general_comment.py
	reviewboard/reviews/models/group.py
	reviewboard/reviews/models/review.py
	reviewboard/reviews/models/review_request.py
	6 more

Tool: Pyflakes
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/reviews/models/screenshot.py
    reviewboard/reviews/models/review_request_draft.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/admin.py
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/reviews/models/group.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/status_update.py
    reviewboard/reviews/models/default_reviewer.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/reviews/models/screenshot_comment.py
    reviewboard/reviews/models/review.py



Tool: PEP8 Style Checker
Processed Files:
    reviewboard/admin/forms.py
    reviewboard/reviews/models/screenshot.py
    reviewboard/reviews/models/review_request_draft.py
    reviewboard/scmtools/models.py
    reviewboard/scmtools/admin.py
    reviewboard/reviews/models/file_attachment_comment.py
    reviewboard/reviews/models/group.py
    reviewboard/reviews/models/diff_comment.py
    reviewboard/reviews/models/review_request.py
    reviewboard/reviews/models/status_update.py
    reviewboard/reviews/models/default_reviewer.py
    reviewboard/reviews/models/general_comment.py
    reviewboard/reviews/models/screenshot_comment.py
    reviewboard/reviews/models/review.py

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed
Change Summary:: Pushed to release-2.0.x (72483db)